Github messages for voidlinux
 help / color / mirror / Atom feed
From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] audacious: enable Qt interface
Date: Tue, 03 Sep 2019 12:09:02 +0200	[thread overview]
Message-ID: <20190903100902.lALJymkg_iOqOSCDq6yMHrG4vNbFHU9AHBOVNB7-_R4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-14178@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

There is an updated pull request by bra1nwave against master on the void-packages repository

https://github.com/bra1nwave/void-packages audacious
https://github.com/void-linux/void-packages/pull/14178

audacious: enable Qt interface
closes  https://github.com/void-linux/void-packages/issues/14171

Should I add a build option for Qt/GTK?

A patch file from https://github.com/void-linux/void-packages/pull/14178.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-audacious-14178.patch --]
[-- Type: text/x-diff, Size: 4129 bytes --]

From d2cf21a4d2fec013bd3b703e464ceecdb58a6b8a Mon Sep 17 00:00:00 2001
From: bra1nwave <brainwave@openmailbox.org>
Date: Tue, 3 Sep 2019 09:16:37 +0200
Subject: [PATCH 1/2] audacious: enable Qt interface

---
 common/shlibs              |  1 +
 srcpkgs/audacious/template | 17 +++++++++++++----
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index e29b965c040..6850c6d3e6a 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -1149,6 +1149,7 @@ libguess.so.1 libguess-1.1_1
 libaudcore.so.5 audacious-3.9_1
 libaudgui.so.5 audacious-3.9_1
 libaudtag.so.3 audacious-3.8_1
+libaudqt.so.2 audacious-3.10.1_2
 libgstreamer-1.0.so.0 gstreamer1-1.0.0_1
 libgstbase-1.0.so.0 gstreamer1-1.0.0_1
 libgstcontroller-1.0.so.0 gstreamer1-1.0.0_1
diff --git a/srcpkgs/audacious/template b/srcpkgs/audacious/template
index 69528553607..316e7f202ba 100644
--- a/srcpkgs/audacious/template
+++ b/srcpkgs/audacious/template
@@ -1,11 +1,12 @@
 # Template file for 'audacious'
 pkgname=audacious
 version=3.10.1
-revision=1
+revision=2
 build_style=gnu-configure
-configure_args="--enable-thunar"
+configure_args="$(vopt_enable qt) $(vopt_if gtk2 --enable-gtk --disable-gtk)"
 hostmakedepends="pkg-config glib-devel"
-makedepends="libSM-devel gtk+-devel dbus-glib-devel libguess-devel"
+makedepends="libSM-devel dbus-glib-devel libguess-devel $(vopt_if gtk2 gtk+-devel)
+$(vopt_if qt qt5-devel)"
 depends="desktop-file-utils hicolor-icon-theme"
 short_desc="Lightweight, advanced audio player focused on audio quality"
 maintainer="Orphaned <orphan@voidlinux.org>"
@@ -14,6 +15,14 @@ homepage="https://audacious-media-player.org/"
 distfiles="https://distfiles.${pkgname}-media-player.org/${pkgname}-${version}.tar.bz2"
 checksum=8366e840bb3c9448c2cf0cf9a0800155b0bd7cc212a28ba44990c3d2289c6b93
 
+build_options="gtk2 qt"
+build_options_default="gtk2 qt"
+desc_option_gtk2="Enable support for the GTK+2 GUI toolkit"
+
+if [ "$CROSS_BUILD" ]; then
+	hostmakedepends+=" qt5-host-tools"
+fi
+
 post_install() {
 	vlicense COPYING
 }
@@ -24,6 +33,6 @@ audacious-devel_package() {
 	pkg_install() {
 		vmove usr/include
 		vmove usr/lib/pkgconfig
-		vmove usr/lib/*.so
+		vmove "usr/lib/*.so"
 	}
 }

From efbe60ee37c01b567e4fdf026f0900dc7e2e4040 Mon Sep 17 00:00:00 2001
From: bra1nwave <brainwave@openmailbox.org>
Date: Tue, 3 Sep 2019 09:16:53 +0200
Subject: [PATCH 2/2] audacious-plugins: enable Qt interface - add cue support

---
 srcpkgs/audacious-plugins/template | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/audacious-plugins/template b/srcpkgs/audacious-plugins/template
index d97bf72f30e..f5d73412d62 100644
--- a/srcpkgs/audacious-plugins/template
+++ b/srcpkgs/audacious-plugins/template
@@ -1,14 +1,16 @@
 # Template file for 'audacious-plugins'
 pkgname=audacious-plugins
 version=3.10.1
-revision=3
+revision=4
 build_style=gnu-configure
+configure_args="$(vopt_enable qt) $(vopt_if gtk2 --enable-gtk --disable-gtk)"
 hostmakedepends="pkg-config"
 makedepends="audacious-devel alsa-lib-devel pulseaudio-devel jack-devel
  lame-devel libvorbis-devel libflac-devel mpg123-devel faad2-devel ffmpeg-devel
  libmodplug-devel fluidsynth-devel libcdio-paranoia-devel wavpack-devel libnotify-devel
- libcurl-devel libmtp-devel neon-devel libmms-devel gtk+-devel libxml2-devel
- libbs2b-devel libsoxr-devel libsidplayfp-devel"
+ libcurl-devel libmtp-devel neon-devel libmms-devel libxml2-devel
+ libbs2b-devel libsoxr-devel libsidplayfp-devel qt5-devel libcue-devel
+ $(vopt_if gtk2 gtk+-devel) $(vopt_if qt 'qt5-devel qt5-multimedia-devel')"
 short_desc="Plugins for the Audacious media player"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-2-Clause"
@@ -16,6 +18,10 @@ homepage="https://audacious-media-player.org/"
 distfiles="https://distfiles.audacious-media-player.org/${pkgname}-${version}.tar.bz2"
 checksum=eec3177631f99729bf0e94223b627406cc648c70e6646e35613c7b55040a2642
 
+build_options="gtk2 qt"
+build_options_default="gtk2 qt"
+desc_option_gtk2="Enable support for the GTK+2 GUI toolkit"
+
 post_install() {
 	vlicense COPYING
 }

  parent reply	other threads:[~2019-09-03 10:09 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-03  7:35 [PR PATCH] " voidlinux-github
2019-09-03  9:05 ` voidlinux-github
2019-09-03 10:09 ` [PR PATCH] [Updated] " voidlinux-github
2019-09-03 10:09 ` voidlinux-github [this message]
2019-09-03 10:12 ` voidlinux-github
2019-09-03 10:12 ` voidlinux-github
2019-09-03 10:16 ` voidlinux-github
2019-09-03 10:16 ` voidlinux-github
2019-09-03 10:21 ` voidlinux-github
2019-09-03 10:21 ` voidlinux-github
2019-09-03 10:25 ` voidlinux-github
2019-09-04 16:35 ` voidlinux-github
2019-09-04 16:47 ` voidlinux-github
2019-09-04 16:52 ` voidlinux-github
2019-09-04 16:56 ` voidlinux-github
2019-09-04 17:01 ` voidlinux-github
2019-09-05  7:24 ` voidlinux-github
2019-09-09 12:12 ` voidlinux-github
2019-09-09 12:16 ` voidlinux-github
2019-09-09 12:25 ` voidlinux-github
2019-09-11 16:03 ` [PR PATCH] [Updated] " voidlinux-github
2019-09-11 16:03 ` voidlinux-github
2019-09-11 16:04 ` voidlinux-github
2019-09-13  8:34 ` [PR PATCH] [Updated] " voidlinux-github
2019-09-13  8:34 ` voidlinux-github
2019-09-13 22:06 ` [PR PATCH] [Merged]: " voidlinux-github

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190903100902.lALJymkg_iOqOSCDq6yMHrG4vNbFHU9AHBOVNB7-_R4@z \
    --to=voidlinux-github@inbox.vuxu.org \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).