* Re: WIP: Openjdk 11
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-13721@inbox.vuxu.org>
@ 2019-09-03 18:05 ` voidlinux-github
2019-09-03 21:08 ` voidlinux-github
` (6 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2019-09-03 18:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 208 bytes --]
New comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/13721#issuecomment-527572551
Comment:
@void-linux/pkg-committers Anyone wanna give this a 2nd review?
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: WIP: Openjdk 11
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-13721@inbox.vuxu.org>
2019-09-03 18:05 ` WIP: Openjdk 11 voidlinux-github
@ 2019-09-03 21:08 ` voidlinux-github
2019-09-03 21:29 ` voidlinux-github
` (5 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2019-09-03 21:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 244 bytes --]
New comment by Vaelatern on void-packages repository
https://github.com/void-linux/void-packages/pull/13721#issuecomment-527641351
Comment:
I'd like a source for the patches before just adding them, a source tracked in the patch file itself.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: WIP: Openjdk 11
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-13721@inbox.vuxu.org>
2019-09-03 18:05 ` WIP: Openjdk 11 voidlinux-github
2019-09-03 21:08 ` voidlinux-github
@ 2019-09-03 21:29 ` voidlinux-github
2019-09-03 21:44 ` voidlinux-github
` (4 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2019-09-03 21:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
New comment by knusbaum on void-packages repository
https://github.com/void-linux/void-packages/pull/13721#issuecomment-527648176
Comment:
Source seems to be from alpine linux:
https://git.alpinelinux.org/aports/commit/?id=8a1ae17d4a9af54285c7891a680620e7e24c6280
If I add a link to that commit to the patches, is that sufficient?
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: WIP: Openjdk 11
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-13721@inbox.vuxu.org>
` (2 preceding siblings ...)
2019-09-03 21:29 ` voidlinux-github
@ 2019-09-03 21:44 ` voidlinux-github
2019-09-03 22:02 ` voidlinux-github
` (3 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2019-09-03 21:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 146 bytes --]
New comment by Vaelatern on void-packages repository
https://github.com/void-linux/void-packages/pull/13721#issuecomment-527652844
Comment:
Yes
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: WIP: Openjdk 11
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-13721@inbox.vuxu.org>
` (3 preceding siblings ...)
2019-09-03 21:44 ` voidlinux-github
@ 2019-09-03 22:02 ` voidlinux-github
2019-09-04 1:02 ` voidlinux-github
` (2 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2019-09-03 22:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 158 bytes --]
New comment by knusbaum on void-packages repository
https://github.com/void-linux/void-packages/pull/13721#issuecomment-527658384
Comment:
@Vaelatern Done.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: WIP: Openjdk 11
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-13721@inbox.vuxu.org>
` (4 preceding siblings ...)
2019-09-03 22:02 ` voidlinux-github
@ 2019-09-04 1:02 ` voidlinux-github
2019-09-04 21:11 ` voidlinux-github
2019-09-04 21:12 ` voidlinux-github
7 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2019-09-04 1:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 255 bytes --]
New comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/13721#issuecomment-527696547
Comment:
The cacerts script is quite large, would it be possible to fetch that dynamically and have it as a distfile?
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: WIP: Openjdk 11
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-13721@inbox.vuxu.org>
` (5 preceding siblings ...)
2019-09-04 1:02 ` voidlinux-github
@ 2019-09-04 21:11 ` voidlinux-github
2019-09-04 21:12 ` voidlinux-github
7 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2019-09-04 21:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 608 bytes --]
New comment by knusbaum on void-packages repository
https://github.com/void-linux/void-packages/pull/13721#issuecomment-528089029
Comment:
@the-maldridge I did you (what I think is) one better. The source of mkcacerts (LFS) now instead recommends a package that contains a slightly different script, `make-ca`. I packaged that and made it a dependency. I think that's good since the package can be useful on its own. Instead of stuffing `mkcacerts` into the java `bin` directory, we can just let users install `make-ca` if they want. If that's no good, I can just pull it in as part of the openjdk build.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: WIP: Openjdk 11
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-13721@inbox.vuxu.org>
` (6 preceding siblings ...)
2019-09-04 21:11 ` voidlinux-github
@ 2019-09-04 21:12 ` voidlinux-github
7 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2019-09-04 21:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 610 bytes --]
New comment by knusbaum on void-packages repository
https://github.com/void-linux/void-packages/pull/13721#issuecomment-528089029
Comment:
@the-maldridge I did you (what I think is) one better. The source of `mkcacerts` (LFS) now instead recommends a package that contains a slightly different script, `make-ca`. I packaged that and made it a dependency. I think that's good since the package can be useful on its own. Instead of stuffing `mkcacerts` into the java `bin` directory, we can just let users install `make-ca` if they want. If that's no good, I can just pull it in as part of the openjdk build.
^ permalink raw reply [flat|nested] 8+ messages in thread