Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] libvirt: fix control socket path
@ 2019-09-06 21:44 voidlinux-github
  2019-09-07  8:39 ` [PR PATCH] [Updated] " voidlinux-github
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: voidlinux-github @ 2019-09-06 21:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 721 bytes --]

There is a new pull request by the-eater against master on the void-packages repository

https://github.com/the-eater/neo-void-packages fix/libvirt/socket-path
https://github.com/void-linux/void-packages/pull/14274

libvirt: fix control socket path
If you use unix control sockets instead of TCP the path of the socket will be incorrectly build and you'll get errors like:

```
Failed to bind socket to 'libvirt//var/run/libvirt/-sock': No such file or directory
```

Included patch fixes that. is also send to upstream but idk how this ancient system of patches via mailing lists work tbh, so don't know if it came through

A patch file from https://github.com/void-linux/void-packages/pull/14274.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/libvirt/socket-path-14274.patch --]
[-- Type: text/x-diff, Size: 2111 bytes --]

From 6ca97eac7556a98f3650b925ee0c0bc82ba37d31 Mon Sep 17 00:00:00 2001
From: eater <=@eater.me>
Date: Fri, 6 Sep 2019 23:38:17 +0200
Subject: [PATCH] libvirt: fix control socket path

---
 .../patches/socket-url-arguments.patch        | 22 +++++++++++++++++++
 srcpkgs/libvirt/template                      |  2 +-
 2 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/libvirt/patches/socket-url-arguments.patch

diff --git a/srcpkgs/libvirt/patches/socket-url-arguments.patch b/srcpkgs/libvirt/patches/socket-url-arguments.patch
new file mode 100644
index 00000000000..a734bfd29f3
--- /dev/null
+++ b/srcpkgs/libvirt/patches/socket-url-arguments.patch
@@ -0,0 +1,22 @@
+diff --git src/remote/remote_daemon.c src/remote/remote_daemon.c
+index 546328b24d..5d64397062 100644
+--- src/remote/remote_daemon.c
++++ src/remote/remote_daemon.c
+@@ -226,14 +226,14 @@ daemonUnixSocketPaths(struct daemonConfig *config,
+ 
+     if (config->unix_sock_dir) {
+         if (virAsprintf(sockfile, "%s/%s-sock",
+-                        SOCK_PREFIX, config->unix_sock_dir) < 0)
++                        config->unix_sock_dir, SOCK_PREFIX) < 0)
+             goto cleanup;
+ 
+         if (privileged) {
+             if (virAsprintf(rosockfile, "%s/%s-sock-ro",
+-                            SOCK_PREFIX, config->unix_sock_dir) < 0 ||
++                            config->unix_sock_dir, SOCK_PREFIX) < 0 ||
+                 virAsprintf(admsockfile, "%s/%s-admin-sock",
+-                            SOCK_PREFIX, config->unix_sock_dir) < 0)
++                            config->unix_sock_dir, SOCK_PREFIX) < 0)
+                 goto cleanup;
+         }
+     } else {
diff --git a/srcpkgs/libvirt/template b/srcpkgs/libvirt/template
index 123b9ee6a4a..0e7f8df0e1c 100644
--- a/srcpkgs/libvirt/template
+++ b/srcpkgs/libvirt/template
@@ -1,7 +1,7 @@
 # Template file for 'libvirt'
 pkgname=libvirt
 version=5.7.0
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--without-hal --with-storage-lvm --with-qemu
  --with-qemu-user=libvirt --with-qemu-group=libvirt --without-netcf

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] libvirt: fix control socket path
  2019-09-06 21:44 [PR PATCH] libvirt: fix control socket path voidlinux-github
@ 2019-09-07  8:39 ` voidlinux-github
  2019-09-07  8:39 ` voidlinux-github
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2019-09-07  8:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

There is an updated pull request by the-eater against master on the void-packages repository

https://github.com/the-eater/neo-void-packages fix/libvirt/socket-path
https://github.com/void-linux/void-packages/pull/14274

libvirt: fix control socket path
If you use unix control sockets instead of TCP the path of the socket will be incorrectly build and you'll get errors like:

```
Failed to bind socket to 'libvirt//var/run/libvirt/-sock': No such file or directory
```

Included patch fixes that. is also send to upstream but idk how this ancient system of patches via mailing lists work tbh, so don't know if it came through

A patch file from https://github.com/void-linux/void-packages/pull/14274.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/libvirt/socket-path-14274.patch --]
[-- Type: text/x-diff, Size: 2111 bytes --]

From 4b21fbecfe62a219797432da0ca9638a8bb9396e Mon Sep 17 00:00:00 2001
From: eater <=@eater.me>
Date: Fri, 6 Sep 2019 23:38:17 +0200
Subject: [PATCH] libvirt: fix control socket path

---
 .../patches/socket-url-arguments.patch        | 22 +++++++++++++++++++
 srcpkgs/libvirt/template                      |  2 +-
 2 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/libvirt/patches/socket-url-arguments.patch

diff --git a/srcpkgs/libvirt/patches/socket-url-arguments.patch b/srcpkgs/libvirt/patches/socket-url-arguments.patch
new file mode 100644
index 00000000000..a734bfd29f3
--- /dev/null
+++ b/srcpkgs/libvirt/patches/socket-url-arguments.patch
@@ -0,0 +1,22 @@
+diff --git src/remote/remote_daemon.c src/remote/remote_daemon.c
+index 546328b24d..5d64397062 100644
+--- src/remote/remote_daemon.c
++++ src/remote/remote_daemon.c
+@@ -226,14 +226,14 @@ daemonUnixSocketPaths(struct daemonConfig *config,
+ 
+     if (config->unix_sock_dir) {
+         if (virAsprintf(sockfile, "%s/%s-sock",
+-                        SOCK_PREFIX, config->unix_sock_dir) < 0)
++                        config->unix_sock_dir, SOCK_PREFIX) < 0)
+             goto cleanup;
+ 
+         if (privileged) {
+             if (virAsprintf(rosockfile, "%s/%s-sock-ro",
+-                            SOCK_PREFIX, config->unix_sock_dir) < 0 ||
++                            config->unix_sock_dir, SOCK_PREFIX) < 0 ||
+                 virAsprintf(admsockfile, "%s/%s-admin-sock",
+-                            SOCK_PREFIX, config->unix_sock_dir) < 0)
++                            config->unix_sock_dir, SOCK_PREFIX) < 0)
+                 goto cleanup;
+         }
+     } else {
diff --git a/srcpkgs/libvirt/template b/srcpkgs/libvirt/template
index 123b9ee6a4a..0e7f8df0e1c 100644
--- a/srcpkgs/libvirt/template
+++ b/srcpkgs/libvirt/template
@@ -1,7 +1,7 @@
 # Template file for 'libvirt'
 pkgname=libvirt
 version=5.7.0
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--without-hal --with-storage-lvm --with-qemu
  --with-qemu-user=libvirt --with-qemu-group=libvirt --without-netcf

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] libvirt: fix control socket path
  2019-09-06 21:44 [PR PATCH] libvirt: fix control socket path voidlinux-github
  2019-09-07  8:39 ` [PR PATCH] [Updated] " voidlinux-github
@ 2019-09-07  8:39 ` voidlinux-github
  2019-09-07  8:41 ` voidlinux-github
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2019-09-07  8:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

There is an updated pull request by the-eater against master on the void-packages repository

https://github.com/the-eater/neo-void-packages fix/libvirt/socket-path
https://github.com/void-linux/void-packages/pull/14274

libvirt: fix control socket path
If you use unix control sockets instead of TCP the path of the socket will be incorrectly build and you'll get errors like:

```
Failed to bind socket to 'libvirt//var/run/libvirt/-sock': No such file or directory
```

Included patch fixes that. is also send to upstream but idk how this ancient system of patches via mailing lists work tbh, so don't know if it came through

A patch file from https://github.com/void-linux/void-packages/pull/14274.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/libvirt/socket-path-14274.patch --]
[-- Type: text/x-diff, Size: 2111 bytes --]

From 4b21fbecfe62a219797432da0ca9638a8bb9396e Mon Sep 17 00:00:00 2001
From: eater <=@eater.me>
Date: Fri, 6 Sep 2019 23:38:17 +0200
Subject: [PATCH] libvirt: fix control socket path

---
 .../patches/socket-url-arguments.patch        | 22 +++++++++++++++++++
 srcpkgs/libvirt/template                      |  2 +-
 2 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/libvirt/patches/socket-url-arguments.patch

diff --git a/srcpkgs/libvirt/patches/socket-url-arguments.patch b/srcpkgs/libvirt/patches/socket-url-arguments.patch
new file mode 100644
index 00000000000..a734bfd29f3
--- /dev/null
+++ b/srcpkgs/libvirt/patches/socket-url-arguments.patch
@@ -0,0 +1,22 @@
+diff --git src/remote/remote_daemon.c src/remote/remote_daemon.c
+index 546328b24d..5d64397062 100644
+--- src/remote/remote_daemon.c
++++ src/remote/remote_daemon.c
+@@ -226,14 +226,14 @@ daemonUnixSocketPaths(struct daemonConfig *config,
+ 
+     if (config->unix_sock_dir) {
+         if (virAsprintf(sockfile, "%s/%s-sock",
+-                        SOCK_PREFIX, config->unix_sock_dir) < 0)
++                        config->unix_sock_dir, SOCK_PREFIX) < 0)
+             goto cleanup;
+ 
+         if (privileged) {
+             if (virAsprintf(rosockfile, "%s/%s-sock-ro",
+-                            SOCK_PREFIX, config->unix_sock_dir) < 0 ||
++                            config->unix_sock_dir, SOCK_PREFIX) < 0 ||
+                 virAsprintf(admsockfile, "%s/%s-admin-sock",
+-                            SOCK_PREFIX, config->unix_sock_dir) < 0)
++                            config->unix_sock_dir, SOCK_PREFIX) < 0)
+                 goto cleanup;
+         }
+     } else {
diff --git a/srcpkgs/libvirt/template b/srcpkgs/libvirt/template
index 123b9ee6a4a..0e7f8df0e1c 100644
--- a/srcpkgs/libvirt/template
+++ b/srcpkgs/libvirt/template
@@ -1,7 +1,7 @@
 # Template file for 'libvirt'
 pkgname=libvirt
 version=5.7.0
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--without-hal --with-storage-lvm --with-qemu
  --with-qemu-user=libvirt --with-qemu-group=libvirt --without-netcf

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: libvirt: fix control socket path
  2019-09-06 21:44 [PR PATCH] libvirt: fix control socket path voidlinux-github
  2019-09-07  8:39 ` [PR PATCH] [Updated] " voidlinux-github
  2019-09-07  8:39 ` voidlinux-github
@ 2019-09-07  8:41 ` voidlinux-github
  2019-09-07  8:46 ` [PR PATCH] [Updated] " voidlinux-github
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2019-09-07  8:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

New comment by the-eater on void-packages repository

https://github.com/void-linux/void-packages/pull/14274#issuecomment-529087605

Comment:
Original build failed on `The job exceeded the maximum log length, and has been terminated.` and it tried to compile it's dependencies instead of installing them???

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] libvirt: fix control socket path
  2019-09-06 21:44 [PR PATCH] libvirt: fix control socket path voidlinux-github
                   ` (3 preceding siblings ...)
  2019-09-07  8:46 ` [PR PATCH] [Updated] " voidlinux-github
@ 2019-09-07  8:46 ` voidlinux-github
  2019-09-07 12:59 ` voidlinux-github
  2019-09-08  8:59 ` [PR PATCH] [Merged]: " voidlinux-github
  6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2019-09-07  8:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

There is an updated pull request by the-eater against master on the void-packages repository

https://github.com/the-eater/neo-void-packages fix/libvirt/socket-path
https://github.com/void-linux/void-packages/pull/14274

libvirt: fix control socket path
If you use unix control sockets instead of TCP the path of the socket will be incorrectly build and you'll get errors like:

```
Failed to bind socket to 'libvirt//var/run/libvirt/-sock': No such file or directory
```

Included patch fixes that. is also send to upstream but idk how this ancient system of patches via mailing lists work tbh, so don't know if it came through

A patch file from https://github.com/void-linux/void-packages/pull/14274.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/libvirt/socket-path-14274.patch --]
[-- Type: text/x-diff, Size: 2111 bytes --]

From 0e0a032d4e8fec8f03c0408a5f416578a6a4d62c Mon Sep 17 00:00:00 2001
From: eater <=@eater.me>
Date: Fri, 6 Sep 2019 23:38:17 +0200
Subject: [PATCH] libvirt: fix control socket path

---
 .../patches/socket-url-arguments.patch        | 22 +++++++++++++++++++
 srcpkgs/libvirt/template                      |  2 +-
 2 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/libvirt/patches/socket-url-arguments.patch

diff --git a/srcpkgs/libvirt/patches/socket-url-arguments.patch b/srcpkgs/libvirt/patches/socket-url-arguments.patch
new file mode 100644
index 00000000000..a734bfd29f3
--- /dev/null
+++ b/srcpkgs/libvirt/patches/socket-url-arguments.patch
@@ -0,0 +1,22 @@
+diff --git src/remote/remote_daemon.c src/remote/remote_daemon.c
+index 546328b24d..5d64397062 100644
+--- src/remote/remote_daemon.c
++++ src/remote/remote_daemon.c
+@@ -226,14 +226,14 @@ daemonUnixSocketPaths(struct daemonConfig *config,
+ 
+     if (config->unix_sock_dir) {
+         if (virAsprintf(sockfile, "%s/%s-sock",
+-                        SOCK_PREFIX, config->unix_sock_dir) < 0)
++                        config->unix_sock_dir, SOCK_PREFIX) < 0)
+             goto cleanup;
+ 
+         if (privileged) {
+             if (virAsprintf(rosockfile, "%s/%s-sock-ro",
+-                            SOCK_PREFIX, config->unix_sock_dir) < 0 ||
++                            config->unix_sock_dir, SOCK_PREFIX) < 0 ||
+                 virAsprintf(admsockfile, "%s/%s-admin-sock",
+-                            SOCK_PREFIX, config->unix_sock_dir) < 0)
++                            config->unix_sock_dir, SOCK_PREFIX) < 0)
+                 goto cleanup;
+         }
+     } else {
diff --git a/srcpkgs/libvirt/template b/srcpkgs/libvirt/template
index 123b9ee6a4a..0e7f8df0e1c 100644
--- a/srcpkgs/libvirt/template
+++ b/srcpkgs/libvirt/template
@@ -1,7 +1,7 @@
 # Template file for 'libvirt'
 pkgname=libvirt
 version=5.7.0
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--without-hal --with-storage-lvm --with-qemu
  --with-qemu-user=libvirt --with-qemu-group=libvirt --without-netcf

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] libvirt: fix control socket path
  2019-09-06 21:44 [PR PATCH] libvirt: fix control socket path voidlinux-github
                   ` (2 preceding siblings ...)
  2019-09-07  8:41 ` voidlinux-github
@ 2019-09-07  8:46 ` voidlinux-github
  2019-09-07  8:46 ` voidlinux-github
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2019-09-07  8:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

There is an updated pull request by the-eater against master on the void-packages repository

https://github.com/the-eater/neo-void-packages fix/libvirt/socket-path
https://github.com/void-linux/void-packages/pull/14274

libvirt: fix control socket path
If you use unix control sockets instead of TCP the path of the socket will be incorrectly build and you'll get errors like:

```
Failed to bind socket to 'libvirt//var/run/libvirt/-sock': No such file or directory
```

Included patch fixes that. is also send to upstream but idk how this ancient system of patches via mailing lists work tbh, so don't know if it came through

A patch file from https://github.com/void-linux/void-packages/pull/14274.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/libvirt/socket-path-14274.patch --]
[-- Type: text/x-diff, Size: 2111 bytes --]

From 0e0a032d4e8fec8f03c0408a5f416578a6a4d62c Mon Sep 17 00:00:00 2001
From: eater <=@eater.me>
Date: Fri, 6 Sep 2019 23:38:17 +0200
Subject: [PATCH] libvirt: fix control socket path

---
 .../patches/socket-url-arguments.patch        | 22 +++++++++++++++++++
 srcpkgs/libvirt/template                      |  2 +-
 2 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/libvirt/patches/socket-url-arguments.patch

diff --git a/srcpkgs/libvirt/patches/socket-url-arguments.patch b/srcpkgs/libvirt/patches/socket-url-arguments.patch
new file mode 100644
index 00000000000..a734bfd29f3
--- /dev/null
+++ b/srcpkgs/libvirt/patches/socket-url-arguments.patch
@@ -0,0 +1,22 @@
+diff --git src/remote/remote_daemon.c src/remote/remote_daemon.c
+index 546328b24d..5d64397062 100644
+--- src/remote/remote_daemon.c
++++ src/remote/remote_daemon.c
+@@ -226,14 +226,14 @@ daemonUnixSocketPaths(struct daemonConfig *config,
+ 
+     if (config->unix_sock_dir) {
+         if (virAsprintf(sockfile, "%s/%s-sock",
+-                        SOCK_PREFIX, config->unix_sock_dir) < 0)
++                        config->unix_sock_dir, SOCK_PREFIX) < 0)
+             goto cleanup;
+ 
+         if (privileged) {
+             if (virAsprintf(rosockfile, "%s/%s-sock-ro",
+-                            SOCK_PREFIX, config->unix_sock_dir) < 0 ||
++                            config->unix_sock_dir, SOCK_PREFIX) < 0 ||
+                 virAsprintf(admsockfile, "%s/%s-admin-sock",
+-                            SOCK_PREFIX, config->unix_sock_dir) < 0)
++                            config->unix_sock_dir, SOCK_PREFIX) < 0)
+                 goto cleanup;
+         }
+     } else {
diff --git a/srcpkgs/libvirt/template b/srcpkgs/libvirt/template
index 123b9ee6a4a..0e7f8df0e1c 100644
--- a/srcpkgs/libvirt/template
+++ b/srcpkgs/libvirt/template
@@ -1,7 +1,7 @@
 # Template file for 'libvirt'
 pkgname=libvirt
 version=5.7.0
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--without-hal --with-storage-lvm --with-qemu
  --with-qemu-user=libvirt --with-qemu-group=libvirt --without-netcf

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: libvirt: fix control socket path
  2019-09-06 21:44 [PR PATCH] libvirt: fix control socket path voidlinux-github
                   ` (4 preceding siblings ...)
  2019-09-07  8:46 ` voidlinux-github
@ 2019-09-07 12:59 ` voidlinux-github
  2019-09-08  8:59 ` [PR PATCH] [Merged]: " voidlinux-github
  6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2019-09-07 12:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New comment by the-eater on void-packages repository

https://github.com/void-linux/void-packages/pull/14274#issuecomment-529106109

Comment:
package templates and repo are out of sync for x86-64 and I have 0 control over it

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Merged]: libvirt: fix control socket path
  2019-09-06 21:44 [PR PATCH] libvirt: fix control socket path voidlinux-github
                   ` (5 preceding siblings ...)
  2019-09-07 12:59 ` voidlinux-github
@ 2019-09-08  8:59 ` voidlinux-github
  6 siblings, 0 replies; 8+ messages in thread
From: voidlinux-github @ 2019-09-08  8:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

There's a merged pull request on the void-packages repository

libvirt: fix control socket path
https://github.com/void-linux/void-packages/pull/14274

Description:
If you use unix control sockets instead of TCP the path of the socket will be incorrectly build and you'll get errors like:

```
Failed to bind socket to 'libvirt//var/run/libvirt/-sock': No such file or directory
```

Included patch fixes that. is also send to upstream but idk how this ancient system of patches via mailing lists work tbh, so don't know if it came through

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-09-08  8:59 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-06 21:44 [PR PATCH] libvirt: fix control socket path voidlinux-github
2019-09-07  8:39 ` [PR PATCH] [Updated] " voidlinux-github
2019-09-07  8:39 ` voidlinux-github
2019-09-07  8:41 ` voidlinux-github
2019-09-07  8:46 ` [PR PATCH] [Updated] " voidlinux-github
2019-09-07  8:46 ` voidlinux-github
2019-09-07 12:59 ` voidlinux-github
2019-09-08  8:59 ` [PR PATCH] [Merged]: " voidlinux-github

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).