Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] webkit2gtk: update to 2.26.0
@ 2019-09-09 16:55 voidlinux-github
  2019-09-10 10:35 ` voidlinux-github
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: voidlinux-github @ 2019-09-09 16:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 725 bytes --]

There is a new pull request by q66 against master on the void-packages repository

https://github.com/void-ppc/void-packages webkit226
https://github.com/void-linux/void-packages/pull/14366

webkit2gtk: update to 2.26.0
The new stable webkit2gtk series was released today, sooner than expected.

Needed building and testing:

- [ ] ppc64le*
- [ ] ppc64*
- [ ] ppc*
- [ ] x86_64
- [ ] x86_64-musl
- [ ] aarch64
- [ ] armv7l

I particularly need someone to test the x86_64 stuff again, and especially musl. 32-bit ARM builds would be nice too, I don't have any way to do them from there. I can test building aarch64, though

A patch file from https://github.com/void-linux/void-packages/pull/14366.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-webkit226-14366.patch --]
[-- Type: text/x-diff, Size: 5520 bytes --]

From 192fed47c3cdee095cde96974ef0baa5e56c206a Mon Sep 17 00:00:00 2001
From: q66 <daniel@octaforge.org>
Date: Sun, 8 Sep 2019 16:46:36 +0200
Subject: [PATCH] webkit2gtk: update to 2.26.0

This reenables the bubblewrap sandbox as was in the 2.25.x update.

[ci skip]
---
 .../patches/fix-fast-memory-disabled.patch    | 14 ----------
 .../patches/fix-musl-javascriptcore.patch     | 28 +++++++++----------
 srcpkgs/webkit2gtk/template                   | 22 +++++++++------
 3 files changed, 28 insertions(+), 36 deletions(-)
 delete mode 100644 srcpkgs/webkit2gtk/patches/fix-fast-memory-disabled.patch

diff --git a/srcpkgs/webkit2gtk/patches/fix-fast-memory-disabled.patch b/srcpkgs/webkit2gtk/patches/fix-fast-memory-disabled.patch
deleted file mode 100644
index 4b5e507274a..00000000000
--- a/srcpkgs/webkit2gtk/patches/fix-fast-memory-disabled.patch
+++ /dev/null
@@ -1,14 +0,0 @@
---- Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp.orig	2017-09-14 10:03:40.908890971 +0200
-+++ Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp	2017-09-14 10:04:17.084859537 +0200
-@@ -112,7 +112,11 @@ void unregisterCode(void* start, void* e
- 
- bool fastMemoryEnabled()
- {
-+#if ENABLE(WEBASSEMBLY_FAST_MEMORY)
-     return fastHandlerInstalled;
-+#else
-+    return false;
-+#endif // ENABLE(WEBASSEMBLY_FAST_MEMORY)
- }
- 
- void enableFastMemory()
diff --git a/srcpkgs/webkit2gtk/patches/fix-musl-javascriptcore.patch b/srcpkgs/webkit2gtk/patches/fix-musl-javascriptcore.patch
index 94294e65b95..129ea037849 100644
--- a/srcpkgs/webkit2gtk/patches/fix-musl-javascriptcore.patch
+++ b/srcpkgs/webkit2gtk/patches/fix-musl-javascriptcore.patch
@@ -85,23 +85,23 @@ Updated for latest webkit2gtk.
      v(unsigned, jitMemoryReservationSize, 0, Normal, "Set this number to change the executable allocation size in ExecutableAllocatorFixedVMPool. (In bytes.)") \
 --- Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp
 +++ Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp
-@@ -836,7 +836,7 @@
+@@ -728,7 +728,7 @@ int yydebug;
  #if YYERROR_VERBOSE
  
- # ifndef yystrlen
--#  if defined __GLIBC__ && defined _STRING_H
-+#  if defined __linux__ && defined _STRING_H
- #   define yystrlen strlen
- #  else
+ #    ifndef yystrlen
+-#        if defined __GLIBC__ && defined _STRING_H
++#        if defined __linux__ && defined _STRING_H
+ #            define yystrlen strlen
+ #        else
  /* Return the length of YYSTR.  */
-@@ -852,7 +852,7 @@
- # endif
- 
- # ifndef yystpcpy
--#  if defined __GLIBC__ && defined _STRING_H && defined _GNU_SOURCE
-+#  if defined __linux__ && defined _STRING_H && defined _GNU_SOURCE
- #   define yystpcpy stpcpy
- #  else
+@@ -743,7 +743,7 @@ static YYSIZE_T yystrlen(const char *yystr)
+ #    endif
+ 
+ #    ifndef yystpcpy
+-#        if defined __GLIBC__ && defined _STRING_H && defined _GNU_SOURCE
++#        if defined __linux__ && defined _STRING_H && defined _GNU_SOURCE
+ #            define yystpcpy stpcpy
+ #        else
  /* Copy YYSRC to YYDEST, returning the address of the terminating '\0' in
 --- Source/WTF/wtf/Platform.h
 +++ Source/WTF/wtf/Platform.h
diff --git a/srcpkgs/webkit2gtk/template b/srcpkgs/webkit2gtk/template
index 26211fca208..1c4f93ccae0 100644
--- a/srcpkgs/webkit2gtk/template
+++ b/srcpkgs/webkit2gtk/template
@@ -1,7 +1,6 @@
 # Template file for 'webkit2gtk'
 pkgname=webkit2gtk
-reverts="2.25.4_1"
-version=2.24.4
+version=2.26.0
 revision=1
 wrksrc="webkitgtk-${version}"
 build_style=cmake
@@ -16,13 +15,14 @@ configure_args="-DPORT=GTK -DUSE_LD_GOLD=OFF
  -DCMAKE_LINKER=${XBPS_CROSS_TRIPLET}-gcc
  -DRUBY_VERSION=2.6
  -DRUBY_CONFIG_INCLUDE_DIR=${XBPS_CROSS_BASE}/usr/include/ruby-2.6.0
- -DENABLE_GTKDOC=OFF -DUSE_GSTREAMER_GL=OFF
+ -DENABLE_GTKDOC=OFF -DUSE_GSTREAMER_GL=OFF -DUSE_WPE_RENDERER=OFF
  -DENABLE_JIT=$(vopt_if jit ON OFF)
  -DENABLE_C_LOOP=$(vopt_if jit OFF ON)
  -DENABLE_INTROSPECTION=$(vopt_if gir ON OFF)
  -DENABLE_WAYLAND_TARGET=$(vopt_if wayland ON OFF)
  -DENABLE_X11_TARGET=$(vopt_if x11 ON OFF)
- -DENABLE_SAMPLING_PROFILER=$(vopt_if sampling_profiler ON OFF)"
+ -DENABLE_SAMPLING_PROFILER=$(vopt_if sampling_profiler ON OFF)
+ -DENABLE_BUBBLEWRAP_SANDBOX=$(vopt_if bubblewrap ON OFF)"
 hostmakedepends="perl python pkg-config gperf flex ruby glib-devel geoclue2
  $(vopt_if wayland wayland-devel)"
 makedepends="at-spi2-core-devel libjpeg-turbo-devel libpng-devel
@@ -38,15 +38,21 @@ maintainer="Enno Boland <gottox@voidlinux.org>"
 license="LGPL-2.1-or-later, BSD-2-Clause"
 homepage="https://webkitgtk.org/"
 distfiles="${homepage}/releases/webkitgtk-${version}.tar.xz"
-checksum=8668b129c026624ec226a4cccf4995f9d26f3e88fc28ab75b0e965f3c32b7dd8
+checksum=d210c0ecd1a89a22c9f8f1f450334f3489c5c50159b3a5e14dd93d5f349dcced
 
-build_options="gir wayland x11 jit sampling_profiler"
-build_options_default="gir wayland x11"
+build_options="gir wayland x11 bubblewrap jit sampling_profiler"
+build_options_default="gir wayland x11 bubblewrap"
 
+desc_option_bubblewrap="Enable bubblewrap sandbox"
 desc_option_jit="JavaScript JIT (Only some architectures)"
 desc_option_sampling_profiler="Sampling profiler support (JIT + glibc only)"
 
-CXXFLAGS="-Wno-expansion-to-defined -Wno-redundant-move -Wno-deprecated-copy"
+# detection + runtime
+if [ "$build_option_bubblewrap" ]; then
+	hostmakedepends+=" bubblewrap xdg-dbus-proxy"
+	makedepends+=" libseccomp-devel"
+	depends+=" bubblewrap xdg-dbus-proxy"
+fi
 
 # only a few platform support JIT
 case "$XBPS_TARGET_MACHINE" in

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: webkit2gtk: update to 2.26.0
  2019-09-09 16:55 [PR PATCH] webkit2gtk: update to 2.26.0 voidlinux-github
@ 2019-09-10 10:35 ` voidlinux-github
  2019-09-10 10:37 ` voidlinux-github
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-09-10 10:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/14366#issuecomment-529876704

Comment:
x86_64 builds and runs fine. x86_64-musl and armv7l compile successfully.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: webkit2gtk: update to 2.26.0
  2019-09-09 16:55 [PR PATCH] webkit2gtk: update to 2.26.0 voidlinux-github
  2019-09-10 10:35 ` voidlinux-github
@ 2019-09-10 10:37 ` voidlinux-github
  2019-09-10 11:46 ` voidlinux-github
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-09-10 10:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/14366#issuecomment-529877192

Comment:
Alright. Just need someone to actually test on musl then... if you've got a binary package somewhere, I can test that myself

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: webkit2gtk: update to 2.26.0
  2019-09-09 16:55 [PR PATCH] webkit2gtk: update to 2.26.0 voidlinux-github
  2019-09-10 10:35 ` voidlinux-github
  2019-09-10 10:37 ` voidlinux-github
@ 2019-09-10 11:46 ` voidlinux-github
  2019-09-10 13:02 ` voidlinux-github
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-09-10 11:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/14366#issuecomment-529897928

Comment:
Sure, the package is here:
https://owncloud.helmut-pozimski.de/index.php/s/os4XXLk2mjWnQme
and the -devel package:
https://owncloud.helmut-pozimski.de/index.php/s/gzpyQa9SKeLpiYT

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: webkit2gtk: update to 2.26.0
  2019-09-09 16:55 [PR PATCH] webkit2gtk: update to 2.26.0 voidlinux-github
                   ` (2 preceding siblings ...)
  2019-09-10 11:46 ` voidlinux-github
@ 2019-09-10 13:02 ` voidlinux-github
  2019-09-10 13:21 ` voidlinux-github
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-09-10 13:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/14366#issuecomment-529923612

Comment:
Well, appears to be OK in my VM... better testing in a native environment would be good though.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: webkit2gtk: update to 2.26.0
  2019-09-09 16:55 [PR PATCH] webkit2gtk: update to 2.26.0 voidlinux-github
                   ` (3 preceding siblings ...)
  2019-09-10 13:02 ` voidlinux-github
@ 2019-09-10 13:21 ` voidlinux-github
  2019-09-10 18:07 ` voidlinux-github
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-09-10 13:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/14366#issuecomment-529931800

Comment:
Seems like YouTube/video playback doesn't work on `x86_64-musl` with 2.26 (it works just fine on non-musl), at least in my VM (in 2.24 it works). I think the problem is not in webkit itself though, i think it has something to do with gstreamer (it seems to use playbin3 now, and i got some assertion failures from that). No way to fix this from my side though...

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: webkit2gtk: update to 2.26.0
  2019-09-09 16:55 [PR PATCH] webkit2gtk: update to 2.26.0 voidlinux-github
                   ` (4 preceding siblings ...)
  2019-09-10 13:21 ` voidlinux-github
@ 2019-09-10 18:07 ` voidlinux-github
  2019-09-10 23:19 ` voidlinux-github
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-09-10 18:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/14366#issuecomment-530054903

Comment:
My findings mostly show that gstreamer is indeed at fault here, more specifically the audio stream. I can seek in the video when paused, but when I try to play it out, it dies; it it dies on not being able play out a stream, completely on the gstreamer side...

So I kinda assume the problem is actually not webkit here... I even managed to get it to play the video for about a second, under some circumstances, before gst aborts the playback.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: webkit2gtk: update to 2.26.0
  2019-09-09 16:55 [PR PATCH] webkit2gtk: update to 2.26.0 voidlinux-github
                   ` (5 preceding siblings ...)
  2019-09-10 18:07 ` voidlinux-github
@ 2019-09-10 23:19 ` voidlinux-github
  2019-09-11  4:36 ` voidlinux-github
  2019-09-11  6:29 ` [PR PATCH] [Merged]: " voidlinux-github
  8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-09-10 23:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 636 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/14366#issuecomment-530156533

Comment:
Alright. Turns out my suspicion was right, and video playback works on machines with working audio. Most likely gstreamer craps out at getting access to audio device in my VM, which 2.24 ignored but 2.26 no longer ignores (probably because it uses a different gstreamer player abstraction, playbin3, for MSE sources like youtube). Testing by another person with a functional audio setup reveals that youtube playback is in fact completely fine.

Therefore, there are no more blockers from my side.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: webkit2gtk: update to 2.26.0
  2019-09-09 16:55 [PR PATCH] webkit2gtk: update to 2.26.0 voidlinux-github
                   ` (6 preceding siblings ...)
  2019-09-10 23:19 ` voidlinux-github
@ 2019-09-11  4:36 ` voidlinux-github
  2019-09-11  6:29 ` [PR PATCH] [Merged]: " voidlinux-github
  8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-09-11  4:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/14366#issuecomment-530215926

Comment:
I can't currently help much with that, gstreamer behaves totally borked on my system. But judging by your comment, the issue should be unrelated to Musl and is probably fine.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Merged]: webkit2gtk: update to 2.26.0
  2019-09-09 16:55 [PR PATCH] webkit2gtk: update to 2.26.0 voidlinux-github
                   ` (7 preceding siblings ...)
  2019-09-11  4:36 ` voidlinux-github
@ 2019-09-11  6:29 ` voidlinux-github
  8 siblings, 0 replies; 10+ messages in thread
From: voidlinux-github @ 2019-09-11  6:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

There's a merged pull request on the void-packages repository

webkit2gtk: update to 2.26.0
https://github.com/void-linux/void-packages/pull/14366

Description:
The new stable webkit2gtk series was released today, sooner than expected.

Needed building and testing:

- [x] ppc64le*
- [x] ppc64*
- [x] ppc*
- [x] x86_64
- [x] x86_64-musl
- [x] aarch64 (build)
- [x] armv7l (build)

I particularly need someone to test the x86_64 stuff again, and especially musl. 32-bit ARM builds would be nice too, I don't have any way to do them from there. I can test building aarch64, though

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-09-11  6:29 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-09 16:55 [PR PATCH] webkit2gtk: update to 2.26.0 voidlinux-github
2019-09-10 10:35 ` voidlinux-github
2019-09-10 10:37 ` voidlinux-github
2019-09-10 11:46 ` voidlinux-github
2019-09-10 13:02 ` voidlinux-github
2019-09-10 13:21 ` voidlinux-github
2019-09-10 18:07 ` voidlinux-github
2019-09-10 23:19 ` voidlinux-github
2019-09-11  4:36 ` voidlinux-github
2019-09-11  6:29 ` [PR PATCH] [Merged]: " voidlinux-github

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).