From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: Re: [WIP] qt5: update to 5.13.1.
Date: Thu, 26 Sep 2019 02:40:05 +0200 [thread overview]
Message-ID: <20190926004005.TYUqrrcz3Jt4jTpEpUhhZofuwlUk93I55ToZ7Qap5Ag@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-14701@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/14701#issuecomment-535279104
Comment:
Looks like `qt5dxcb-plugin` needs this:
```
--- a/srcpkgs/qt5dxcb-plugin/template
+++ b/srcpkgs/qt5dxcb-plugin/template
@@ -29,6 +29,11 @@ pre_configure() {
msg_red "${_qt5_version%_*} does not match ${_qt5_dep_ver}\\n"
exit 1
fi
+
+ # no headers for 5.13.1 yet; 5.13.0 headers are the same for this
+ # remove on next version upgrade (after upstream has added them)
+ ln -s ${wrksrc}/platformplugin/libqt5xcbqpa-dev/5.13.0 \
+ ${wrksrc}/platformplugin/libqt5xcbqpa-dev/5.13.1
}
if [ "$CROSS_BUILD" ]; then
```
The reason for that is that the headers weren't added for 5.13.1 yet. I diffed the 5.13.0 headers against the ones from 5.13.1 Qt source, and the only change was that 5.13.1 added some non-virtual private method in a place which is irrelevant for this, so for now this is perfectly okay.
Should be removed for next bump afterwards, though.
next prev parent reply other threads:[~2019-09-26 0:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 12:33 [PR PATCH] " voidlinux-github
2019-09-25 14:34 ` [WIP] " voidlinux-github
2019-09-25 14:42 ` [PR PATCH] [Updated] " voidlinux-github
2019-09-25 14:42 ` voidlinux-github
2019-09-25 17:21 ` voidlinux-github
2019-09-25 17:21 ` voidlinux-github
2019-09-26 0:40 ` voidlinux-github [this message]
2019-09-26 9:40 ` voidlinux-github
2019-09-26 9:40 ` voidlinux-github
2019-09-26 9:43 ` voidlinux-github
2019-09-26 17:42 ` voidlinux-github
2019-09-26 21:11 ` [PR PATCH] [Merged]: " voidlinux-github
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926004005.TYUqrrcz3Jt4jTpEpUhhZofuwlUk93I55ToZ7Qap5Ag@z \
--to=voidlinux-github@inbox.vuxu.org \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).