Github messages for voidlinux
 help / color / Atom feed
* [PR PATCH] girara: update 0.3.3 and fix open
@ 2019-10-08 14:20 voidlinux-github
  2019-10-08 14:39 ` [PR PATCH] [Updated] " voidlinux-github
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: voidlinux-github @ 2019-10-08 14:20 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

There is a new pull request by concatime against master on the void-packages repository

https://github.com/concatime/void-packages girara
https://github.com/void-linux/void-packages/pull/15254

girara: update 0.3.3 and fix open
Because girara already depends on glib, I replaced `xdg-open` by `gio open` instead of adding yet another dependency.

A patch file from https://github.com/void-linux/void-packages/pull/15254.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-girara-15254.patch --]
[-- Type: text/x-diff, Size: 2252 bytes --]

From 7d7ed8c289dd5b57cdc7d652ff5a2a02332f355b Mon Sep 17 00:00:00 2001
From: Issam Maghni <me@concati.me>
Date: Tue, 8 Oct 2019 10:19:27 -0400
Subject: [PATCH] girara: update 0.3.3 and fix open

---
 .../girara/patches/xdg-open-to-gio-open.patch  | 18 ++++++++++++++++++
 srcpkgs/girara/template                        |  6 +++---
 2 files changed, 21 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/girara/patches/xdg-open-to-gio-open.patch

diff --git a/srcpkgs/girara/patches/xdg-open-to-gio-open.patch b/srcpkgs/girara/patches/xdg-open-to-gio-open.patch
new file mode 100644
index 00000000000..3bdce90c252
--- /dev/null
+++ b/srcpkgs/girara/patches/xdg-open-to-gio-open.patch
@@ -0,0 +1,18 @@
++++ girara/utils.c
+@@ -68,7 +68,7 @@ girara_xdg_open_with_working_directory(const char* uri, const char* working_dire
+   }
+
+   /* g_spawn_async expects char** */
+-  char* argv[] = { g_strdup("xdg-open"), g_strdup(uri), NULL };
++  char* argv[] = { g_strdup("gio"), g_strdup("open"), g_strdup(uri), NULL };
+
+   GError* error = NULL;
+   const bool res = g_spawn_async(working_directory, argv, NULL, G_SPAWN_SEARCH_PATH, NULL,
+@@ -78,6 +78,7 @@ girara_xdg_open_with_working_directory(const char* uri, const char* working_dire
+     g_error_free(error);
+   }
+
++  g_free(argv[2]);
+   g_free(argv[1]);
+   g_free(argv[0]);
+
diff --git a/srcpkgs/girara/template b/srcpkgs/girara/template
index 23657857b6b..2b2f016fff5 100644
--- a/srcpkgs/girara/template
+++ b/srcpkgs/girara/template
@@ -1,6 +1,6 @@
 # Template file for 'girara'
 pkgname=girara
-version=0.3.2
+version=0.3.3
 revision=1
 build_style=meson
 configure_args="-Dnotify=auto -Dtests=disabled"
@@ -10,8 +10,8 @@ short_desc="A library implementing a user interface that focuses on minimalism"
 maintainer="lemmi <lemmi@nerd2nerd.org>"
 license="Zlib"
 homepage="https://pwmt.org/projects/girara/"
-distfiles="https://pwmt.org/projects/${pkgname}/download/${pkgname}-${version}.tar.xz"
-checksum=1700353a101f3c520f9b22e79d71ea5b268a9ec324796cf9e64775d96bb086cd
+distfiles="https://git.pwmt.org/pwmt/${pkgname}/-/archive/${version}/${pkgname}-${version}.tar.gz"
+checksum=4456ddd6f0420fa6f1677a4a8f438f0401c38c2521585db3ee42e339a730798f
 
 post_install() {
 	vlicense LICENSE

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] girara: update 0.3.3 and fix open
  2019-10-08 14:20 [PR PATCH] girara: update 0.3.3 and fix open voidlinux-github
  2019-10-08 14:39 ` [PR PATCH] [Updated] " voidlinux-github
@ 2019-10-08 14:39 ` voidlinux-github
  2019-10-08 19:08 ` voidlinux-github
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2019-10-08 14:39 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

There is an updated pull request by concatime against master on the void-packages repository

https://github.com/concatime/void-packages girara
https://github.com/void-linux/void-packages/pull/15254

girara: update 0.3.3 and fix open
Because girara already depends on glib, I replaced `xdg-open` by `gio open` instead of adding yet another dependency.

A patch file from https://github.com/void-linux/void-packages/pull/15254.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-girara-15254.patch --]
[-- Type: text/x-diff, Size: 3160 bytes --]

From 7d7ed8c289dd5b57cdc7d652ff5a2a02332f355b Mon Sep 17 00:00:00 2001
From: Issam Maghni <me@concati.me>
Date: Tue, 8 Oct 2019 10:19:27 -0400
Subject: [PATCH 1/2] girara: update 0.3.3 and fix open

---
 .../girara/patches/xdg-open-to-gio-open.patch  | 18 ++++++++++++++++++
 srcpkgs/girara/template                        |  6 +++---
 2 files changed, 21 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/girara/patches/xdg-open-to-gio-open.patch

diff --git a/srcpkgs/girara/patches/xdg-open-to-gio-open.patch b/srcpkgs/girara/patches/xdg-open-to-gio-open.patch
new file mode 100644
index 00000000000..3bdce90c252
--- /dev/null
+++ b/srcpkgs/girara/patches/xdg-open-to-gio-open.patch
@@ -0,0 +1,18 @@
++++ girara/utils.c
+@@ -68,7 +68,7 @@ girara_xdg_open_with_working_directory(const char* uri, const char* working_dire
+   }
+
+   /* g_spawn_async expects char** */
+-  char* argv[] = { g_strdup("xdg-open"), g_strdup(uri), NULL };
++  char* argv[] = { g_strdup("gio"), g_strdup("open"), g_strdup(uri), NULL };
+
+   GError* error = NULL;
+   const bool res = g_spawn_async(working_directory, argv, NULL, G_SPAWN_SEARCH_PATH, NULL,
+@@ -78,6 +78,7 @@ girara_xdg_open_with_working_directory(const char* uri, const char* working_dire
+     g_error_free(error);
+   }
+
++  g_free(argv[2]);
+   g_free(argv[1]);
+   g_free(argv[0]);
+
diff --git a/srcpkgs/girara/template b/srcpkgs/girara/template
index 23657857b6b..2b2f016fff5 100644
--- a/srcpkgs/girara/template
+++ b/srcpkgs/girara/template
@@ -1,6 +1,6 @@
 # Template file for 'girara'
 pkgname=girara
-version=0.3.2
+version=0.3.3
 revision=1
 build_style=meson
 configure_args="-Dnotify=auto -Dtests=disabled"
@@ -10,8 +10,8 @@ short_desc="A library implementing a user interface that focuses on minimalism"
 maintainer="lemmi <lemmi@nerd2nerd.org>"
 license="Zlib"
 homepage="https://pwmt.org/projects/girara/"
-distfiles="https://pwmt.org/projects/${pkgname}/download/${pkgname}-${version}.tar.xz"
-checksum=1700353a101f3c520f9b22e79d71ea5b268a9ec324796cf9e64775d96bb086cd
+distfiles="https://git.pwmt.org/pwmt/${pkgname}/-/archive/${version}/${pkgname}-${version}.tar.gz"
+checksum=4456ddd6f0420fa6f1677a4a8f438f0401c38c2521585db3ee42e339a730798f
 
 post_install() {
 	vlicense LICENSE

From ac0b62bc2ad73aafdf999348a65d6515e31a7842 Mon Sep 17 00:00:00 2001
From: Issam Maghni <me@concati.me>
Date: Tue, 8 Oct 2019 10:41:24 -0400
Subject: [PATCH 2/2] girara: fix xlint

---
 srcpkgs/girara/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/girara/template b/srcpkgs/girara/template
index 2b2f016fff5..8dcb84f51d5 100644
--- a/srcpkgs/girara/template
+++ b/srcpkgs/girara/template
@@ -6,7 +6,7 @@ build_style=meson
 configure_args="-Dnotify=auto -Dtests=disabled"
 hostmakedepends="pkg-config intltool doxygen glib-devel"
 makedepends="gtk+3-devel libnotify-devel libglib-devel json-c-devel"
-short_desc="A library implementing a user interface that focuses on minimalism"
+short_desc="Library implementing a user interface that focuses on minimalism"
 maintainer="lemmi <lemmi@nerd2nerd.org>"
 license="Zlib"
 homepage="https://pwmt.org/projects/girara/"

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] girara: update 0.3.3 and fix open
  2019-10-08 14:20 [PR PATCH] girara: update 0.3.3 and fix open voidlinux-github
@ 2019-10-08 14:39 ` voidlinux-github
  2019-10-08 14:39 ` voidlinux-github
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2019-10-08 14:39 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

There is an updated pull request by concatime against master on the void-packages repository

https://github.com/concatime/void-packages girara
https://github.com/void-linux/void-packages/pull/15254

girara: update 0.3.3 and fix open
Because girara already depends on glib, I replaced `xdg-open` by `gio open` instead of adding yet another dependency.

A patch file from https://github.com/void-linux/void-packages/pull/15254.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-girara-15254.patch --]
[-- Type: text/x-diff, Size: 3160 bytes --]

From 7d7ed8c289dd5b57cdc7d652ff5a2a02332f355b Mon Sep 17 00:00:00 2001
From: Issam Maghni <me@concati.me>
Date: Tue, 8 Oct 2019 10:19:27 -0400
Subject: [PATCH 1/2] girara: update 0.3.3 and fix open

---
 .../girara/patches/xdg-open-to-gio-open.patch  | 18 ++++++++++++++++++
 srcpkgs/girara/template                        |  6 +++---
 2 files changed, 21 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/girara/patches/xdg-open-to-gio-open.patch

diff --git a/srcpkgs/girara/patches/xdg-open-to-gio-open.patch b/srcpkgs/girara/patches/xdg-open-to-gio-open.patch
new file mode 100644
index 00000000000..3bdce90c252
--- /dev/null
+++ b/srcpkgs/girara/patches/xdg-open-to-gio-open.patch
@@ -0,0 +1,18 @@
++++ girara/utils.c
+@@ -68,7 +68,7 @@ girara_xdg_open_with_working_directory(const char* uri, const char* working_dire
+   }
+
+   /* g_spawn_async expects char** */
+-  char* argv[] = { g_strdup("xdg-open"), g_strdup(uri), NULL };
++  char* argv[] = { g_strdup("gio"), g_strdup("open"), g_strdup(uri), NULL };
+
+   GError* error = NULL;
+   const bool res = g_spawn_async(working_directory, argv, NULL, G_SPAWN_SEARCH_PATH, NULL,
+@@ -78,6 +78,7 @@ girara_xdg_open_with_working_directory(const char* uri, const char* working_dire
+     g_error_free(error);
+   }
+
++  g_free(argv[2]);
+   g_free(argv[1]);
+   g_free(argv[0]);
+
diff --git a/srcpkgs/girara/template b/srcpkgs/girara/template
index 23657857b6b..2b2f016fff5 100644
--- a/srcpkgs/girara/template
+++ b/srcpkgs/girara/template
@@ -1,6 +1,6 @@
 # Template file for 'girara'
 pkgname=girara
-version=0.3.2
+version=0.3.3
 revision=1
 build_style=meson
 configure_args="-Dnotify=auto -Dtests=disabled"
@@ -10,8 +10,8 @@ short_desc="A library implementing a user interface that focuses on minimalism"
 maintainer="lemmi <lemmi@nerd2nerd.org>"
 license="Zlib"
 homepage="https://pwmt.org/projects/girara/"
-distfiles="https://pwmt.org/projects/${pkgname}/download/${pkgname}-${version}.tar.xz"
-checksum=1700353a101f3c520f9b22e79d71ea5b268a9ec324796cf9e64775d96bb086cd
+distfiles="https://git.pwmt.org/pwmt/${pkgname}/-/archive/${version}/${pkgname}-${version}.tar.gz"
+checksum=4456ddd6f0420fa6f1677a4a8f438f0401c38c2521585db3ee42e339a730798f
 
 post_install() {
 	vlicense LICENSE

From ac0b62bc2ad73aafdf999348a65d6515e31a7842 Mon Sep 17 00:00:00 2001
From: Issam Maghni <me@concati.me>
Date: Tue, 8 Oct 2019 10:41:24 -0400
Subject: [PATCH 2/2] girara: fix xlint

---
 srcpkgs/girara/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/girara/template b/srcpkgs/girara/template
index 2b2f016fff5..8dcb84f51d5 100644
--- a/srcpkgs/girara/template
+++ b/srcpkgs/girara/template
@@ -6,7 +6,7 @@ build_style=meson
 configure_args="-Dnotify=auto -Dtests=disabled"
 hostmakedepends="pkg-config intltool doxygen glib-devel"
 makedepends="gtk+3-devel libnotify-devel libglib-devel json-c-devel"
-short_desc="A library implementing a user interface that focuses on minimalism"
+short_desc="Library implementing a user interface that focuses on minimalism"
 maintainer="lemmi <lemmi@nerd2nerd.org>"
 license="Zlib"
 homepage="https://pwmt.org/projects/girara/"

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: girara: update 0.3.3 and fix open
  2019-10-08 14:20 [PR PATCH] girara: update 0.3.3 and fix open voidlinux-github
  2019-10-08 14:39 ` [PR PATCH] [Updated] " voidlinux-github
  2019-10-08 14:39 ` voidlinux-github
@ 2019-10-08 19:08 ` voidlinux-github
  2019-10-08 19:47 ` voidlinux-github
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2019-10-08 19:08 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/15254#issuecomment-539658530

Comment:
I think it's unnecessary to patch software just to avoid a small dependency but that's just my two cents.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: girara: update 0.3.3 and fix open
  2019-10-08 14:20 [PR PATCH] girara: update 0.3.3 and fix open voidlinux-github
                   ` (2 preceding siblings ...)
  2019-10-08 19:08 ` voidlinux-github
@ 2019-10-08 19:47 ` voidlinux-github
  2019-10-11  2:51 ` voidlinux-github
  2019-10-11  2:51 ` [PR PATCH] [Closed]: " voidlinux-github
  5 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2019-10-08 19:47 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

New comment by lemmi on void-packages repository

https://github.com/void-linux/void-packages/pull/15254#issuecomment-539672706

Comment:
I didn't notice there were updates to girara and zathura. We should line up the zathura updates as well and get everything merged in one go to maybe avoid some weirdness as happened in the past.
As for the patch: I don't have really anything against it other than i'd rather have upstream integrate it. @concatime could you open an issue upstream for the `gio` thing and in the mean time revert to the old behavior?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: girara: update 0.3.3 and fix open
  2019-10-08 14:20 [PR PATCH] girara: update 0.3.3 and fix open voidlinux-github
                   ` (3 preceding siblings ...)
  2019-10-08 19:47 ` voidlinux-github
@ 2019-10-11  2:51 ` voidlinux-github
  2019-10-11  2:51 ` [PR PATCH] [Closed]: " voidlinux-github
  5 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2019-10-11  2:51 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New comment by concatime on void-packages repository

https://github.com/void-linux/void-packages/pull/15254#issuecomment-540878040

Comment:
Favor #15280.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Closed]: girara: update 0.3.3 and fix open
  2019-10-08 14:20 [PR PATCH] girara: update 0.3.3 and fix open voidlinux-github
                   ` (4 preceding siblings ...)
  2019-10-11  2:51 ` voidlinux-github
@ 2019-10-11  2:51 ` voidlinux-github
  5 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2019-10-11  2:51 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

There's a closed pull request on the void-packages repository

girara: update 0.3.3 and fix open
https://github.com/void-linux/void-packages/pull/15254

Description:
Because girara already depends on glib, I replaced `xdg-open` by `gio open` instead of adding yet another dependency.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-08 14:20 [PR PATCH] girara: update 0.3.3 and fix open voidlinux-github
2019-10-08 14:39 ` [PR PATCH] [Updated] " voidlinux-github
2019-10-08 14:39 ` voidlinux-github
2019-10-08 19:08 ` voidlinux-github
2019-10-08 19:47 ` voidlinux-github
2019-10-11  2:51 ` voidlinux-github
2019-10-11  2:51 ` [PR PATCH] [Closed]: " voidlinux-github

Github messages for voidlinux

Archives are clonable: git clone --mirror http://inbox.vuxu.org/voidlinux-github

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git