[-- Attachment #1: Type: text/plain, Size: 360 bytes --] There is a new pull request by Chocimier against master on the void-packages repository https://github.com/Chocimier/void-packages-org lxdm https://github.com/void-linux/void-packages/pull/15261 [RFC] lxdm: exclude /bin from default PATH Changes analogous to #14267. A patch file from https://github.com/void-linux/void-packages/pull/15261.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-lxdm-15261.patch --] [-- Type: text/x-diff, Size: 2105 bytes --] From ced661f33483c85e3786d29310f792e382e1a7d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20W=C3=B3jcik?= <chocimier@tlen.pl> Date: Tue, 8 Oct 2019 19:42:38 +0200 Subject: [PATCH] lxdm: exclude /bin from default PATH --- srcpkgs/lxdm/patches/default-PATH.patch | 22 ++++++++++++++++++++++ srcpkgs/lxdm/template | 2 +- 2 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 srcpkgs/lxdm/patches/default-PATH.patch diff --git a/srcpkgs/lxdm/patches/default-PATH.patch b/srcpkgs/lxdm/patches/default-PATH.patch new file mode 100644 index 00000000000..515452690dc --- /dev/null +++ b/srcpkgs/lxdm/patches/default-PATH.patch @@ -0,0 +1,22 @@ +From e46c33735f81ca5607247fd0690ebbe9f1565708 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Piotr=20W=C3=B3jcik?= <chocimier@tlen.pl> +Date: Tue, 8 Oct 2019 19:32:15 +0200 +Subject: [PATCH] tweak default PATH + + +diff --git src/lxdm.c src/lxdm.c +index a37f051..8a0e6c6 100644 +--- src/lxdm.c ++++ src/lxdm.c +@@ -1399,7 +1399,7 @@ void lxdm_do_login(struct passwd *pw, char *session, char *lang, char *option) + if( G_UNLIKELY(path) && path[0] ) /* if PATH is specified in config file */ + env=g_environ_setenv(env, "PATH", path, TRUE); /* override current $PATH with config value */ + else /* don't use the global env, they are bad for user */ +- env=g_environ_setenv(env, "PATH", "/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin", TRUE); /* set proper default */ ++ env=g_environ_setenv(env, "PATH", "/usr/local/bin:/usr/bin:/usr/local/sbin", TRUE); /* set proper default */ + g_free(path); + /* optionally override $LANG, $LC_MESSAGES, and $LANGUAGE */ + if( lang && lang[0] ) +-- +2.23.0 + diff --git a/srcpkgs/lxdm/template b/srcpkgs/lxdm/template index 55ae9b5356e..efc7d9101a9 100644 --- a/srcpkgs/lxdm/template +++ b/srcpkgs/lxdm/template @@ -1,7 +1,7 @@ # Template file for 'lxdm' pkgname=lxdm version=0.5.3 -revision=4 +revision=5 build_style=gnu-configure configure_args="--disable-consolekit --with-pam --enable-gtk3" hostmakedepends="automake gettext-devel libtool pkg-config intltool"
[-- Attachment #1: Type: text/plain, Size: 365 bytes --] There is an updated pull request by Chocimier against master on the void-packages repository https://github.com/Chocimier/void-packages-org lxdm https://github.com/void-linux/void-packages/pull/15261 [RFC] lxdm: exclude /bin from default PATH Changes analogous to #14267. A patch file from https://github.com/void-linux/void-packages/pull/15261.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-lxdm-15261.patch --] [-- Type: text/x-diff, Size: 2565 bytes --] From 48f64614cbe8c908f3d786419045f06b19a762af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20W=C3=B3jcik?= <chocimier@tlen.pl> Date: Tue, 8 Oct 2019 19:42:38 +0200 Subject: [PATCH] lxdm: exclude /bin from default PATH --- srcpkgs/lxdm/patches/default-PATH.patch | 22 ++++++++++++++++++++++ srcpkgs/lxdm/template | 4 ++-- 2 files changed, 24 insertions(+), 2 deletions(-) create mode 100644 srcpkgs/lxdm/patches/default-PATH.patch diff --git a/srcpkgs/lxdm/patches/default-PATH.patch b/srcpkgs/lxdm/patches/default-PATH.patch new file mode 100644 index 00000000000..515452690dc --- /dev/null +++ b/srcpkgs/lxdm/patches/default-PATH.patch @@ -0,0 +1,22 @@ +From e46c33735f81ca5607247fd0690ebbe9f1565708 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Piotr=20W=C3=B3jcik?= <chocimier@tlen.pl> +Date: Tue, 8 Oct 2019 19:32:15 +0200 +Subject: [PATCH] tweak default PATH + + +diff --git src/lxdm.c src/lxdm.c +index a37f051..8a0e6c6 100644 +--- src/lxdm.c ++++ src/lxdm.c +@@ -1399,7 +1399,7 @@ void lxdm_do_login(struct passwd *pw, char *session, char *lang, char *option) + if( G_UNLIKELY(path) && path[0] ) /* if PATH is specified in config file */ + env=g_environ_setenv(env, "PATH", path, TRUE); /* override current $PATH with config value */ + else /* don't use the global env, they are bad for user */ +- env=g_environ_setenv(env, "PATH", "/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin", TRUE); /* set proper default */ ++ env=g_environ_setenv(env, "PATH", "/usr/local/bin:/usr/bin:/usr/local/sbin", TRUE); /* set proper default */ + g_free(path); + /* optionally override $LANG, $LC_MESSAGES, and $LANGUAGE */ + if( lang && lang[0] ) +-- +2.23.0 + diff --git a/srcpkgs/lxdm/template b/srcpkgs/lxdm/template index 55ae9b5356e..d9e532be58a 100644 --- a/srcpkgs/lxdm/template +++ b/srcpkgs/lxdm/template @@ -1,7 +1,7 @@ # Template file for 'lxdm' pkgname=lxdm version=0.5.3 -revision=4 +revision=5 build_style=gnu-configure configure_args="--disable-consolekit --with-pam --enable-gtk3" hostmakedepends="automake gettext-devel libtool pkg-config intltool" @@ -16,13 +16,13 @@ conf_files=" /etc/lxdm/Xsession /etc/lxdm/lxdm.conf /etc/pam.d/lxdm" -system_groups="lxdm" short_desc="GUI login manager for LXDE" maintainer="Orphaned <orphan@voidlinux.org>" license="GPL-3.0-or-later" homepage="https://lxde.org" distfiles="${SOURCEFORGE_SITE}/lxdm/lxdm-${version}.tar.xz" checksum=4891efee81c72a400cc6703e40aa76f3f3853833d048b72ec805da0f93567f2f +system_groups="lxdm" pre_configure() { autoreconf -fi
[-- Attachment #1: Type: text/plain, Size: 365 bytes --] There is an updated pull request by Chocimier against master on the void-packages repository https://github.com/Chocimier/void-packages-org lxdm https://github.com/void-linux/void-packages/pull/15261 [RFC] lxdm: exclude /bin from default PATH Changes analogous to #14267. A patch file from https://github.com/void-linux/void-packages/pull/15261.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-lxdm-15261.patch --] [-- Type: text/x-diff, Size: 2565 bytes --] From 48f64614cbe8c908f3d786419045f06b19a762af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20W=C3=B3jcik?= <chocimier@tlen.pl> Date: Tue, 8 Oct 2019 19:42:38 +0200 Subject: [PATCH] lxdm: exclude /bin from default PATH --- srcpkgs/lxdm/patches/default-PATH.patch | 22 ++++++++++++++++++++++ srcpkgs/lxdm/template | 4 ++-- 2 files changed, 24 insertions(+), 2 deletions(-) create mode 100644 srcpkgs/lxdm/patches/default-PATH.patch diff --git a/srcpkgs/lxdm/patches/default-PATH.patch b/srcpkgs/lxdm/patches/default-PATH.patch new file mode 100644 index 00000000000..515452690dc --- /dev/null +++ b/srcpkgs/lxdm/patches/default-PATH.patch @@ -0,0 +1,22 @@ +From e46c33735f81ca5607247fd0690ebbe9f1565708 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Piotr=20W=C3=B3jcik?= <chocimier@tlen.pl> +Date: Tue, 8 Oct 2019 19:32:15 +0200 +Subject: [PATCH] tweak default PATH + + +diff --git src/lxdm.c src/lxdm.c +index a37f051..8a0e6c6 100644 +--- src/lxdm.c ++++ src/lxdm.c +@@ -1399,7 +1399,7 @@ void lxdm_do_login(struct passwd *pw, char *session, char *lang, char *option) + if( G_UNLIKELY(path) && path[0] ) /* if PATH is specified in config file */ + env=g_environ_setenv(env, "PATH", path, TRUE); /* override current $PATH with config value */ + else /* don't use the global env, they are bad for user */ +- env=g_environ_setenv(env, "PATH", "/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin", TRUE); /* set proper default */ ++ env=g_environ_setenv(env, "PATH", "/usr/local/bin:/usr/bin:/usr/local/sbin", TRUE); /* set proper default */ + g_free(path); + /* optionally override $LANG, $LC_MESSAGES, and $LANGUAGE */ + if( lang && lang[0] ) +-- +2.23.0 + diff --git a/srcpkgs/lxdm/template b/srcpkgs/lxdm/template index 55ae9b5356e..d9e532be58a 100644 --- a/srcpkgs/lxdm/template +++ b/srcpkgs/lxdm/template @@ -1,7 +1,7 @@ # Template file for 'lxdm' pkgname=lxdm version=0.5.3 -revision=4 +revision=5 build_style=gnu-configure configure_args="--disable-consolekit --with-pam --enable-gtk3" hostmakedepends="automake gettext-devel libtool pkg-config intltool" @@ -16,13 +16,13 @@ conf_files=" /etc/lxdm/Xsession /etc/lxdm/lxdm.conf /etc/pam.d/lxdm" -system_groups="lxdm" short_desc="GUI login manager for LXDE" maintainer="Orphaned <orphan@voidlinux.org>" license="GPL-3.0-or-later" homepage="https://lxde.org" distfiles="${SOURCEFORGE_SITE}/lxdm/lxdm-${version}.tar.xz" checksum=4891efee81c72a400cc6703e40aa76f3f3853833d048b72ec805da0f93567f2f +system_groups="lxdm" pre_configure() { autoreconf -fi
[-- Attachment #1: Type: text/plain, Size: 269 bytes --] New comment by CameronNemo on void-packages repository https://github.com/void-linux/void-packages/pull/15261#issuecomment-539661818 Comment: I would rather it be included but at a lower priority. Particularly for chroots and containers that do not have usrbinmerge.
[-- Attachment #1: Type: text/plain, Size: 182 bytes --] New comment by Chocimier on void-packages repository https://github.com/void-linux/void-packages/pull/15261#issuecomment-539662561 Comment: Isn't appending by /etc/profile enough?
[-- Attachment #1: Type: text/plain, Size: 160 bytes --] New comment by Chocimier on void-packages repository https://github.com/void-linux/void-packages/pull/15261#issuecomment-810578386 Comment: Moved to #14267.
[-- Attachment #1: Type: text/plain, Size: 204 bytes --] There's a closed pull request on the void-packages repository [RFC] lxdm: exclude /bin from default PATH https://github.com/void-linux/void-packages/pull/15261 Description: Changes analogous to #14267.