From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: Fix empty dir check in i686 masterdirs.
Date: Tue, 22 Oct 2019 16:58:12 +0200 [thread overview]
Message-ID: <20191022145812.wsayPtYCc_WxREavjLydVSaJhRtULrB4e6bZiR5Ep2A@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-15654@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
There's a merged pull request on the void-packages repository
Fix empty dir check in i686 masterdirs.
https://github.com/void-linux/void-packages/pull/15654
Description:
See e.g. https://travis-ci.org/void-linux/void-packages/builds/600443626?utm_source=github_status&utm_medium=notification , all of the builds should have failed, but i686 created a empty package even without the `meta` build_style. The issue was that the `lib32 -> lib` symlink still existed at the point of checking for empty dir, so `/usr` was in fact not empty, but is at `do_pkg`. Reordering the hooks fixes this but reveals another issue, namely that `rmdir -p` will remove even `/destdir` and would therefore break actual meta packages.
prev parent reply other threads:[~2019-10-22 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-20 22:23 [PR PATCH] " voidlinux-github
2019-10-22 14:58 ` voidlinux-github [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022145812.wsayPtYCc_WxREavjLydVSaJhRtULrB4e6bZiR5Ep2A@z \
--to=voidlinux-github@inbox.vuxu.org \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).