Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] astroid: update to 0.15
@ 2019-10-22 13:40 voidlinux-github
  2019-10-30 18:13 ` [PR PATCH] [Closed]: " voidlinux-github
  2019-10-30 21:12 ` voidlinux-github
  0 siblings, 2 replies; 6+ messages in thread
From: voidlinux-github @ 2019-10-22 13:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

There is a new pull request by bitmeise against master on the void-packages repository

https://github.com/bitmeise/void-packages astroid015
https://github.com/void-linux/void-packages/pull/15696

astroid: update to 0.15


A patch file from https://github.com/void-linux/void-packages/pull/15696.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-astroid015-15696.patch --]
[-- Type: text/x-diff, Size: 3403 bytes --]

From cfacf380bf9832e0243b5aae56ce0da5fc9e6260 Mon Sep 17 00:00:00 2001
From: Ameise <ameise@bitparlament.de>
Date: Tue, 22 Oct 2019 17:33:33 +0200
Subject: [PATCH] astroid: update to 0.15

---
 ...5bbdae9939cf4716ca2ff47dee75f1f3f57e.patch | 53 -------------------
 srcpkgs/astroid/template                      |  7 ++-
 2 files changed, 3 insertions(+), 57 deletions(-)
 delete mode 100644 srcpkgs/astroid/patches/03e05bbdae9939cf4716ca2ff47dee75f1f3f57e.patch

diff --git a/srcpkgs/astroid/patches/03e05bbdae9939cf4716ca2ff47dee75f1f3f57e.patch b/srcpkgs/astroid/patches/03e05bbdae9939cf4716ca2ff47dee75f1f3f57e.patch
deleted file mode 100644
index 6368c7e9631..00000000000
--- a/srcpkgs/astroid/patches/03e05bbdae9939cf4716ca2ff47dee75f1f3f57e.patch
+++ /dev/null
@@ -1,53 +0,0 @@
-From 03e05bbdae9939cf4716ca2ff47dee75f1f3f57e Mon Sep 17 00:00:00 2001
-From: Gaute Hope <eg@gaute.vetsj.com>
-Date: Sat, 20 Oct 2018 19:38:01 +0200
-Subject: [PATCH] ae: correctly allocate buffer array (-pedantic)
-
-char[n] is technically not allowed in C++, and seems to cause trouble in
-this case.
----
- .../thread_view/webextension/ae_protocol.cc     | 17 ++++++++++++++---
- 1 file changed, 14 insertions(+), 3 deletions(-)
-
-diff --git a/src/modes/thread_view/webextension/ae_protocol.cc b/src/modes/thread_view/webextension/ae_protocol.cc
-index 735b219b..6687b97b 100644
---- a/src/modes/thread_view/webextension/ae_protocol.cc
-+++ b/src/modes/thread_view/webextension/ae_protocol.cc
-@@ -59,7 +59,12 @@ namespace Astroid {
-     s &= ostream->write_all ((char*) &mt, sizeof (mt), written);
- 
-     /* send message */
--    s &= ostream->write_all (o, written);
-+    try {
-+      s &= ostream->write_all (o, written);
-+    } catch (Gio::Error &ex) {
-+      LOG (error) << "ae: error: " << ex.what ();
-+      throw;
-+    }
-     ostream->flush ();
- 
-     if (!s) {
-@@ -154,8 +159,13 @@ namespace Astroid {
-     }
- 
-     /* read message */
--    gchar buffer[msg_sz + 1]; buffer[msg_sz] = '\0';
--    s = istream->read_all (buffer, msg_sz, read, reader_cancel);
-+    gchar * buffer = new gchar[msg_sz];
-+    try {
-+      s = istream->read_all (buffer, msg_sz, read, reader_cancel);
-+    } catch (Gio::Error &ex) {
-+      LOG (error) << "ae: error (read): " << ex.code() << ", " <<  ex.what ();
-+      throw;
-+    }
- 
-     if (!s || read != msg_sz) {
-       LOG (error) << "reader: error while reading message (size: " << msg_sz << ")";
-@@ -163,6 +173,7 @@ namespace Astroid {
-     }
- 
-     msg_str = std::string (buffer, msg_sz);
-+    delete [] buffer;
-     return mt;
-   }
- 
diff --git a/srcpkgs/astroid/template b/srcpkgs/astroid/template
index 31bd1e6a4f6..34ffa93c83f 100644
--- a/srcpkgs/astroid/template
+++ b/srcpkgs/astroid/template
@@ -1,7 +1,7 @@
 # Template file for 'astroid'
 pkgname=astroid
-version=0.14
-revision=6
+version=0.15
+revision=1
 build_style=cmake
 hostmakedepends="pkg-config scdoc protobuf"
 makedepends="libnotmuch-devel gtkmm-devel webkit2gtk-devel libsass-devel
@@ -12,5 +12,4 @@ maintainer="Ameise <ameise@bitparlament.de>"
 license="GPL-3.0-or-later"
 homepage="http://astroidmail.github.io/"
 distfiles="https://github.com/astroidmail/astroid/archive/v${version}.tar.gz"
-checksum=f2642968919527008d383b4c32d4b038c7b6f785ea084dde1222a65162ebc5ca
-patch_args="-p1"
+checksum=8581bbdbc71bd00d4cdd473cfad8bc604628bb15616fe5eab5c623461f686c65

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: astroid: update to 0.15
  2019-10-22 13:40 [PR PATCH] astroid: update to 0.15 voidlinux-github
@ 2019-10-30 18:13 ` voidlinux-github
  2019-10-30 21:12 ` voidlinux-github
  1 sibling, 0 replies; 6+ messages in thread
From: voidlinux-github @ 2019-10-30 18:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

There's a closed pull request on the void-packages repository

astroid: update to 0.15
https://github.com/void-linux/void-packages/pull/15696

Description:


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: astroid: update to 0.15
  2019-10-22 13:40 [PR PATCH] astroid: update to 0.15 voidlinux-github
  2019-10-30 18:13 ` [PR PATCH] [Closed]: " voidlinux-github
@ 2019-10-30 21:12 ` voidlinux-github
  1 sibling, 0 replies; 6+ messages in thread
From: voidlinux-github @ 2019-10-30 21:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

New comment by bitmeise on void-packages repository

https://github.com/void-linux/void-packages/pull/15696#issuecomment-548114548

Comment:
After some investigation I have the feeling the build errors on some archs are related to cross-compiling libnotmuch package. Anyone able to help out? Maybe @congdanhqx-zz ?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: astroid: update to 0.15
  2021-08-06 14:54 [PR PATCH] " bitmeise
  2021-08-06 16:09 ` paper42
  2021-08-06 20:19 ` bitmeise
@ 2021-08-10 11:53 ` bitmeise
  2 siblings, 0 replies; 6+ messages in thread
From: bitmeise @ 2021-08-10 11:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 772 bytes --]

New comment by bitmeise on void-packages repository

https://github.com/void-linux/void-packages/pull/32364#issuecomment-895965233

Comment:
I'm pretty sure now that checkdepends includes everything necessary for succesfully running the tests. However, the tests only run with X11 (see upstream https://github.com/astroidmail/astroid/issues/516).

By manually bending some stuff to my local X11 I could confirm the tests run 100% fine. However, I don't see how we can run the tests by xbps alone.

The build completes for architectures with disabled tests.

I see three options:
A. Consider upstream to make their tests independent from X (not going to happen soon).
B. Find a way to run tests with some X.
C. Disable tests for now.

Any advice is appreciated.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: astroid: update to 0.15
  2021-08-06 14:54 [PR PATCH] " bitmeise
  2021-08-06 16:09 ` paper42
@ 2021-08-06 20:19 ` bitmeise
  2021-08-10 11:53 ` bitmeise
  2 siblings, 0 replies; 6+ messages in thread
From: bitmeise @ 2021-08-06 20:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New comment by bitmeise on void-packages repository

https://github.com/void-linux/void-packages/pull/32364#issuecomment-894498138

Comment:
Thanks for the hint.
checkdepends is the way to go, but I didn't see it in time. I will fix this soon.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: astroid: update to 0.15
  2021-08-06 14:54 [PR PATCH] " bitmeise
@ 2021-08-06 16:09 ` paper42
  2021-08-06 20:19 ` bitmeise
  2021-08-10 11:53 ` bitmeise
  2 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2021-08-06 16:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32364#issuecomment-894363468

Comment:
tests are failing with `tests/run_test.sh: line 18: gpgconf: command not found`, could you add gnupg to checkdepends?

You can run tests on your computer with
```
./xbps-src check <pkg>
```

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-08-10 11:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-22 13:40 [PR PATCH] astroid: update to 0.15 voidlinux-github
2019-10-30 18:13 ` [PR PATCH] [Closed]: " voidlinux-github
2019-10-30 21:12 ` voidlinux-github
2021-08-06 14:54 [PR PATCH] " bitmeise
2021-08-06 16:09 ` paper42
2021-08-06 20:19 ` bitmeise
2021-08-10 11:53 ` bitmeise

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).