Re: [PR PATCH] [Merged]: git: keep build flag consistent in all stage

[voidlinux-github@inbox.vuxu.org]

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

There's a merged pull request on the void-packages repository

git: keep build flag consistent in all stage
https://github.com/void-linux/void-packages/pull/16019

Description:
git build system will trigger a rebuild if it detects
if flags passed to make changed.

In commit 82a5337c07, ("git: correct utf-16 and utf-32 conversion on
musl", 2019-10-30) , we tried to correct the git-iconv interaction on
musl, but we forget to pass that flag into `make install'.

Hence, on do_install, git build system rebuild git without
ICONV_OMITS_BOM=Yes flag, thus produce faulty binary.

[Save that flag into config.mak][1] in order to keep it consistent across
build stage.

While we're at it, also move other make_*_args into config.mak

[1]: https://public-inbox.org/git/20191031181116.GC2133@sigill.intra.peff.net/

---

git make test isn't fully working in musl right now, so I couldn't find this earlier.

I'm proposing [a series of patch to git][2], if that series get merged,
we can run `./xbps-src check git` on musl. This mistake won't happen again.

[2]: https://public-inbox.org/git/20191101014006.GE30350@danh.dev/T/#re843bfd3d7b4e1592c6546e63d8c65ff57f564ef