Re: dracut: depend on eudev

[voidlinux-github@inbox.vuxu.org]

[-- Attachment #1: Type: text/plain, Size: 1930 bytes --]

New comment by zdtcd on void-packages repository

https://github.com/void-linux/void-packages/pull/16098#issuecomment-551373412

Comment:
On 2019-11-07 18:18:58 -0800, Daniel Kolesa wrote:
> `kpartx` is required by `90multipath` and `90dmraid` modules and is
> a hard dependency in both e.g. debian and the official rpm .spec
> file (plus it's rather tiny), `e2fsprogs` is a hard dep in debian
> but not in the .spec, it's used by multiple modules but i guess
> mostly optionally.

    $ cat /usr/lib/dracut/dracut.conf.d/*.conf
    #
    # Void Linux default settings for dracut.
    #
    # Don't edit this file, it will be overwritten on next update.
    #
    add_dracutmodules+=" drm "
    stdloglvl=4
    add_dracutmodules+=" resume "
    omit_dracutmodules+=" systemd "
    i18n_vars="/etc/rc.conf:KEYMAP,FONT,FONT_MAP,FONT_UNIMAP"

Our default settings for dracut doesn't include multipath and dmraid.
We haven't shipped multipathd, anyway.
The dracut.spec file also put kpartx in the Recommends for fedora and
rhel (or for anything not fedora and rhel, I'm not familiar with spec
grmmar).

But, I think adding kpartx isn't a big deal, since it's a tiny package.

But, if we're gonna add every binary that dracut is using to depends,
I don't think it's a good idea.

How about adding this patch instead:

```
 modules.d/90dmraid/module-setup.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/modules.d/90dmraid/module-setup.sh b/modules.d/90dmraid/module-setup.sh
index 797a58e5..8038899a 100755
--- a/modules.d/90dmraid/module-setup.sh
+++ b/modules.d/90dmraid/module-setup.sh
@@ -6,6 +6,7 @@ check() {
     # if we don't have dmraid installed on the host system, no point
     # in trying to support it in the initramfs.
     require_binaries dmraid || return 1
+    require_binaries kpartx || return 1
 
     [[ $hostonly ]] || [[ $mount_needs ]] && {
         for dev in "${!host_fs_types[@]}"; do
```

-- 
Danh