From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: Re: hedgewars: fix ppc build
Date: Tue, 24 Dec 2019 19:36:20 +0100 [thread overview]
Message-ID: <20191224183620.KsqiSG15CVEQKHCkCE2ar0Weg_HmjcRaACuhdwkQcmY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-17759@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/17759#issuecomment-568788965
Comment:
I think this template could use a better refactor. Also, what are the differences between the C and fpc engine?
Some suggestions:
- only add `fpc` in `hostmakedepends` conditionally instead of sed'ing it away
- don't conditionalize the C engine for `ppc*`, instead use it for everything except `x86_64`, as a single `case`, since `fpc` is only available on x86
- for the cflags removal, conditionalize it with some kind of `$_use_c` variable and set `_use_c=yes` when using the C engine
next prev parent reply other threads:[~2019-12-24 18:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 18:19 [PR PATCH] " voidlinux-github
2019-12-24 18:32 ` voidlinux-github
2019-12-24 18:35 ` voidlinux-github
2019-12-24 18:36 ` voidlinux-github [this message]
2019-12-25 13:28 ` voidlinux-github
2019-12-25 16:45 ` [PR PATCH] [Updated] " voidlinux-github
2019-12-25 23:14 ` voidlinux-github
2019-12-26 1:46 ` [PR PATCH] [Updated] " voidlinux-github
2019-12-26 11:22 ` voidlinux-github
2019-12-26 11:23 ` [PR PATCH] [Merged]: " voidlinux-github
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191224183620.KsqiSG15CVEQKHCkCE2ar0Weg_HmjcRaACuhdwkQcmY@z \
--to=voidlinux-github@inbox.vuxu.org \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).