From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: Re: [WIP] fluidsynth: update to 2.1.0
Date: Thu, 02 Jan 2020 10:37:39 +0100 [thread overview]
Message-ID: <20200102093739.DqX6RGFMxM5ALVDHAFSYRbjW87KkzqYOr0wBjHRE80A@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-14416@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1184 bytes --]
New comment by newbluemoon on void-packages repository
https://github.com/void-linux/void-packages/pull/14416#issuecomment-570156787
Comment:
Just tested ScummVM and ResidualVM on x86_64-musl and have some remarks:
* The error which is addressed by the `__attribute__` patch has been fixed in ScummVM/ResidualVM here: https://github.com/scummvm/scummvm/commit/8593a9e1e4e8dd1f5dfac9b1304a417df9a742e6. So if no other package has a problem with this I think it might be better not to patch fluidsynth but ScummVM/ResidualVM instead and remove that patch when a new stable version is released.
* I don’t think `git` is necessary in `hostmakedepends` for ScummVM. They use it to get a version number for unstable/nightly builds. So the error message can safely be ignored.
* Why did you add `SDL-devel` and `SDL_net-devel` to ScummVM’s `makedepends`? I don’t think mixing SDL versions is a good idea. ;) The problem with finding the headers might be a result of this (e.g. `sdl2-config` vs. `sdl-config`). For me it works just fine with SDL2 only, no patch needed.
Local builds with the changes mentioned above applied work for me without any problem so far. :)
next prev parent reply other threads:[~2020-01-02 9:37 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 8:37 [PR PATCH] [WIP] fluidsynth: update to 2.0.6 voidlinux-github
2019-09-12 11:09 ` voidlinux-github
2019-09-12 20:30 ` voidlinux-github
2019-09-13 7:15 ` [PR PATCH] [Updated] " voidlinux-github
2019-09-13 7:15 ` voidlinux-github
2019-09-13 7:16 ` voidlinux-github
2019-09-13 7:16 ` voidlinux-github
2019-09-13 7:17 ` voidlinux-github
2019-09-21 15:05 ` voidlinux-github
2019-10-14 5:38 ` voidlinux-github
2019-12-29 13:19 ` voidlinux-github
2019-12-29 21:30 ` voidlinux-github
2019-12-29 22:12 ` [PR PATCH] [Updated] " voidlinux-github
2020-01-01 21:46 ` voidlinux-github
2020-01-01 21:50 ` voidlinux-github
2020-01-01 22:11 ` voidlinux-github
2020-01-01 22:26 ` voidlinux-github
2020-01-01 22:27 ` voidlinux-github
2020-01-01 22:28 ` [PR PATCH] [Updated] " voidlinux-github
2020-01-01 22:28 ` voidlinux-github
2020-01-02 3:55 ` [PR PATCH] [Updated] [WIP] fluidsynth: update to 2.1.0 voidlinux-github
2020-01-02 6:38 ` voidlinux-github
2020-01-02 7:01 ` voidlinux-github
2020-01-02 7:01 ` voidlinux-github
2020-01-02 7:17 ` voidlinux-github
2020-01-02 7:17 ` voidlinux-github
2020-01-02 7:17 ` voidlinux-github
2020-01-02 9:37 ` voidlinux-github
2020-01-02 9:37 ` voidlinux-github [this message]
2020-01-02 10:59 ` voidlinux-github
2020-01-03 21:57 ` [PR PATCH] [Updated] " voidlinux-github
2020-01-03 22:05 ` voidlinux-github
2020-01-12 17:05 ` voidlinux-github
2020-01-20 0:42 ` [PR PATCH] [Updated] " voidlinux-github
2020-01-20 1:42 ` voidlinux-github
2020-01-20 1:52 ` [PR PATCH] [Updated] " voidlinux-github
2020-01-27 3:47 ` voidlinux-github
2020-03-23 5:47 ` fosslinux
2020-04-24 23:29 ` fosslinux
2020-04-24 23:29 ` [PR PATCH] [Closed]: " fosslinux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200102093739.DqX6RGFMxM5ALVDHAFSYRbjW87KkzqYOr0wBjHRE80A@z \
--to=voidlinux-github@inbox.vuxu.org \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).