Re: [ISSUE] [CLOSED] common/hooks/do-fetch/00-distfiles.sh: contents checksum broken

[voidlinux-github@inbox.vuxu.org]

[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]

Closed issue by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/issues/18070

Description:
With the switch to `bsdtar` the evaluation of contents checksums (i.e. the ones starting with `@`) is broken. One example is `libaom`. Trying to build it gives the error:
```
=> libaom-1.0.0.1_2: verifying contents checksum for distfile 'v1.0.0-errata1.tar.gz'... bsdtar: Can't specify both -t and -x
```

`bsdtar` as opposed to `tar` does not support `-x extract` together with `-t list`, yet the commands are like `$TAR_CMD xf $filename $TAR_CMD_STDOUT`.

I think we need to get rid of the `TAR_CMD_STDOUT="--list"` vs. `TAR_CMD_STDOUT="--to-stdout"` and rather have the type of command (extract or list) for `bsdtar` and `tar` as part of some `TAR_CMD_STDOUT`

For `bsdtar` that could be `TAR_CMD_STDOUT="bsdtar --list"`, and for GNU `tar` that could be `TAR_CMD_STDOUT="tar --extract --to-stdout"`.

For the single case where there is no redirection from the tar output to stdout, in line 98, then `TAR_CMD="bsdtar"` or `TAR_CMD="tar"` should be defined.

I could try to fix that but perhaps @xtraeme knows better how to fix this and beats me to it?