From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] zfs-auto-snapshot: crontab fixes
Date: Mon, 20 Jan 2020 19:37:55 +0100 [thread overview]
Message-ID: <20200120183755.wH_pzMkx1nKdhr840oZjMECxFuVcgnjbkqHA8sUPA3M@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18424@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 814 bytes --]
There is an updated pull request by ahesford against master on the void-packages repository
https://github.com/ahesford/void-packages zfs-auto-snapshot
https://github.com/void-linux/void-packages/pull/18424
zfs-auto-snapshot: crontab fixes
The zfs-auto-snapshot package installs several crontab files. In this PR, these files are properly marked as conf_files because the user may wish to customize their behavior. Also, I comment out the PATH variable assignment in the etc/cron.d/zfs-auto-snapshot "frequent" file because such variable assignments are not supported in dcron. (In other crond alternatives, the variable assignment is meaningless, because the directories assigned are redundant with the system default.)
A patch file from https://github.com/void-linux/void-packages/pull/18424.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zfs-auto-snapshot-18424.patch --]
[-- Type: text/x-diff, Size: 1449 bytes --]
From b90b5225b63bb0664101a18e06a6037766b6f1c5 Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Mon, 20 Jan 2020 10:58:15 -0500
Subject: [PATCH] zfs-auto-snapshot: crontab improvements
---
srcpkgs/zfs-auto-snapshot/template | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/zfs-auto-snapshot/template b/srcpkgs/zfs-auto-snapshot/template
index 2b6ecfc7caf..113dfd3c30b 100644
--- a/srcpkgs/zfs-auto-snapshot/template
+++ b/srcpkgs/zfs-auto-snapshot/template
@@ -1,16 +1,23 @@
# Template file for 'zfs-auto-snapshot'
pkgname=zfs-auto-snapshot
version=1.2.4
-revision=1
+revision=2
+archs=noarch
wrksrc="${pkgname}-upstream-${version}"
build_style=gnu-makefile
+short_desc="ZFS automatic snapshot service"
maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2"
+license="GPL-2.0-only"
homepage="https://github.com/zfsonlinux/zfs-auto-snapshot"
-short_desc="ZFS automatic snapshot service"
distfiles="${homepage}/archive/upstream/${version}.tar.gz"
checksum=307f71f748cacf5149532891dc3174365a4494337d9cfc8e619d9038080f3e9b
-archs=noarch
+conf_files="/etc/cron.*/zfs-auto-snapshot"
+
+pre_install() {
+ # The "frequent" crontab contais a PATH= directive, which is not
+ # supported with the dcron package and is otherwise unnecessary
+ vsed -i 's/^PATH=/#PATH=/' etc/zfs-auto-snapshot.cron.frequent
+}
post_install() {
mv ${DESTDIR}/usr/sbin ${DESTDIR}/usr/bin
next prev parent reply other threads:[~2020-01-20 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 15:59 [PR PATCH] " voidlinux-github
2020-01-20 18:37 ` voidlinux-github [this message]
2020-01-25 8:06 ` [PR PATCH] [Merged]: " voidlinux-github
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120183755.wH_pzMkx1nKdhr840oZjMECxFuVcgnjbkqHA8sUPA3M@z \
--to=voidlinux-github@inbox.vuxu.org \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).