[PR PATCH] golangci-lint: update to 1.23.0

[PR PATCH] golangci-lint: update to 1.23.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

There is a new pull request by renatoaguiar against master on the void-packages repository

https://github.com/renatoaguiar/void-packages golangci-lint
https://github.com/void-linux/void-packages/pull/18405

golangci-lint: update to 1.23.0


A patch file from https://github.com/void-linux/void-packages/pull/18405.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golangci-lint-18405.patch --]
[-- Type: text/x-diff, Size: 1109 bytes --]

From 58ff962915b6d7b61b81552d28f255cf81ab5089 Mon Sep 17 00:00:00 2001
From: Renato Aguiar <renato@renatoaguiar.net>
Date: Sun, 19 Jan 2020 11:55:52 -0800
Subject: [PATCH] golangci-lint: update to 1.23.0

---
 srcpkgs/golangci-lint/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/golangci-lint/template b/srcpkgs/golangci-lint/template
index 46761ecedcd..1886c008d8d 100644
--- a/srcpkgs/golangci-lint/template
+++ b/srcpkgs/golangci-lint/template
@@ -1,6 +1,6 @@
 # Template file for 'golangci-lint'
 pkgname=golangci-lint
-version=1.22.2
+version=1.23.0
 revision=1
 build_style=go
 go_import_path=github.com/golangci/golangci-lint/cmd/golangci-lint
@@ -9,7 +9,7 @@ maintainer="Renato Aguiar <renato@renatoaguiar.net>"
 license="GPL-3.0-only"
 homepage="https://github.com/golangci/golangci-lint"
 distfiles="https://github.com/golangci/golangci-lint/archive/v${version}.tar.gz"
-checksum=59d4a025e58840fd83ac811d5d24c4cabefd61195b2b6fb5f5e9a5c8102de2f9
+checksum=a6c6199fe59289d6ed4960d6f5011e642740c1aa2852633b85d52a0e64d91dc8
 
 post_install() {
 	vdoc README.md

Re: golangci-lint: update to 1.23.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/18405#issuecomment-576732578

Comment:
This fails to cross build for `arm*` and `aarch64*`. It succeeds for `ppc64le*` but fails for all other cross architectures and also for `i686-musl` here. I wonder if this a problem with the `go` build style or `go` itself.

I think `nocross="Fails to cross build for most targets"` would be a temporary solution.

Re: [PR PATCH] [Updated] golangci-lint: update to 1.23.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

There is an updated pull request by renatoaguiar against master on the void-packages repository

https://github.com/renatoaguiar/void-packages golangci-lint
https://github.com/void-linux/void-packages/pull/18405

golangci-lint: update to 1.23.0


A patch file from https://github.com/void-linux/void-packages/pull/18405.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golangci-lint-18405.patch --]
[-- Type: text/x-diff, Size: 1109 bytes --]

From b90d217dc6119e5f100c7534439e6c26d0ac4686 Mon Sep 17 00:00:00 2001
From: Renato Aguiar <renato@renatoaguiar.net>
Date: Sun, 19 Jan 2020 11:55:52 -0800
Subject: [PATCH] golangci-lint: update to 1.23.1

---
 srcpkgs/golangci-lint/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/golangci-lint/template b/srcpkgs/golangci-lint/template
index 46761ecedcd..8090abd4561 100644
--- a/srcpkgs/golangci-lint/template
+++ b/srcpkgs/golangci-lint/template
@@ -1,6 +1,6 @@
 # Template file for 'golangci-lint'
 pkgname=golangci-lint
-version=1.22.2
+version=1.23.1
 revision=1
 build_style=go
 go_import_path=github.com/golangci/golangci-lint/cmd/golangci-lint
@@ -9,7 +9,7 @@ maintainer="Renato Aguiar <renato@renatoaguiar.net>"
 license="GPL-3.0-only"
 homepage="https://github.com/golangci/golangci-lint"
 distfiles="https://github.com/golangci/golangci-lint/archive/v${version}.tar.gz"
-checksum=59d4a025e58840fd83ac811d5d24c4cabefd61195b2b6fb5f5e9a5c8102de2f9
+checksum=88288446eec89d41cff854b9f6712581b52af03c97327d6218bb9125f3267134
 
 post_install() {
 	vdoc README.md

Re: golangci-lint: update to 1.23.1

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

New comment by renatoaguiar on void-packages repository

https://github.com/void-linux/void-packages/pull/18405#issuecomment-576782894

Comment:
> This fails to cross build for `arm*` and `aarch64*`. It succeeds for `ppc64le*` but fails for all other cross architectures and also for `i686-musl` here. I wonder if this a problem with the `go` build style or `go` itself.
> 
> I think `nocross="Fails to cross build for most targets"` would be a temporary solution.

I just tried cross-compiling using original version from master and it works fine, so it doesn't seem to be related to Go itself. Let me do more debugging before marking it broken.

Re: [PR PATCH] [Updated] golangci-lint: update to 1.23.1

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

There is an updated pull request by renatoaguiar against master on the void-packages repository

https://github.com/renatoaguiar/void-packages golangci-lint
https://github.com/void-linux/void-packages/pull/18405

golangci-lint: update to 1.23.1


A patch file from https://github.com/void-linux/void-packages/pull/18405.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golangci-lint-18405.patch --]
[-- Type: text/x-diff, Size: 1183 bytes --]

From 501bfb7151744f10bf29180be31e9150814c25ff Mon Sep 17 00:00:00 2001
From: Renato Aguiar <renato@renatoaguiar.net>
Date: Sun, 19 Jan 2020 11:55:52 -0800
Subject: [PATCH] golangci-lint: update to 1.23.1

---
 srcpkgs/golangci-lint/template | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/golangci-lint/template b/srcpkgs/golangci-lint/template
index 46761ecedcd..882bd742d06 100644
--- a/srcpkgs/golangci-lint/template
+++ b/srcpkgs/golangci-lint/template
@@ -1,6 +1,6 @@
 # Template file for 'golangci-lint'
 pkgname=golangci-lint
-version=1.22.2
+version=1.23.1
 revision=1
 build_style=go
 go_import_path=github.com/golangci/golangci-lint/cmd/golangci-lint
@@ -9,7 +9,10 @@ maintainer="Renato Aguiar <renato@renatoaguiar.net>"
 license="GPL-3.0-only"
 homepage="https://github.com/golangci/golangci-lint"
 distfiles="https://github.com/golangci/golangci-lint/archive/v${version}.tar.gz"
-checksum=59d4a025e58840fd83ac811d5d24c4cabefd61195b2b6fb5f5e9a5c8102de2f9
+checksum=88288446eec89d41cff854b9f6712581b52af03c97327d6218bb9125f3267134
+
+# Cross builds fail with -fuse-ld=gold
+LDFLAGS="-Wl,-fuse-ld=bfd"
 
 post_install() {
 	vdoc README.md

Re: [PR PATCH] [Updated] golangci-lint: update to 1.23.1

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

There is an updated pull request by renatoaguiar against master on the void-packages repository

https://github.com/renatoaguiar/void-packages golangci-lint
https://github.com/void-linux/void-packages/pull/18405

golangci-lint: update to 1.23.1


A patch file from https://github.com/void-linux/void-packages/pull/18405.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golangci-lint-18405.patch --]
[-- Type: text/x-diff, Size: 1179 bytes --]

From ded46e89b50ae090638ce3c1fd76fb5e1ff25f4d Mon Sep 17 00:00:00 2001
From: Renato Aguiar <renato@renatoaguiar.net>
Date: Sun, 19 Jan 2020 11:55:52 -0800
Subject: [PATCH] golangci-lint: update to 1.23.1

---
 srcpkgs/golangci-lint/template | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/golangci-lint/template b/srcpkgs/golangci-lint/template
index 46761ecedcd..e79b8b755c4 100644
--- a/srcpkgs/golangci-lint/template
+++ b/srcpkgs/golangci-lint/template
@@ -1,6 +1,6 @@
 # Template file for 'golangci-lint'
 pkgname=golangci-lint
-version=1.22.2
+version=1.23.1
 revision=1
 build_style=go
 go_import_path=github.com/golangci/golangci-lint/cmd/golangci-lint
@@ -9,7 +9,10 @@ maintainer="Renato Aguiar <renato@renatoaguiar.net>"
 license="GPL-3.0-only"
 homepage="https://github.com/golangci/golangci-lint"
 distfiles="https://github.com/golangci/golangci-lint/archive/v${version}.tar.gz"
-checksum=59d4a025e58840fd83ac811d5d24c4cabefd61195b2b6fb5f5e9a5c8102de2f9
+checksum=88288446eec89d41cff854b9f6712581b52af03c97327d6218bb9125f3267134
+
+# Cross builds fail with -fuse-ld=gold
+LDFLAGS="-fuse-ld=bfd"
 
 post_install() {
 	vdoc README.md

Re: golangci-lint: update to 1.23.1

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New comment by renatoaguiar on void-packages repository

https://github.com/void-linux/void-packages/pull/18405#issuecomment-577010255

Comment:
Forcing use of ld.bfd instead of ld.gold seem to fix the issue.

Re: golangci-lint: update to 1.23.1

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by renatoaguiar on void-packages repository

https://github.com/void-linux/void-packages/pull/18405#issuecomment-577010255

Comment:
Forcing use of ld.bfd instead of ld.gold seems to fix the issue.

Re: [PR PATCH] [Merged]: golangci-lint: update to 1.23.1

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

There's a merged pull request on the void-packages repository

golangci-lint: update to 1.23.1
https://github.com/void-linux/void-packages/pull/18405

Description: