Github messages for voidlinux
 help / color / mirror / Atom feed
From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: Re: sshguard: support dynamic firewall config and remove iptables dependency
Date: Thu, 23 Jan 2020 02:03:44 +0100	[thread overview]
Message-ID: <20200123010344.RkuoXxsfrXKKOFuSxE2Vy3Js6UWXB8mHIIuxmsn2-_w@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18477@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/18477#issuecomment-577458415

Comment:
> Not sure what to think about the rename, this will kill sshguard from users system, the moment the package is updated.
> Maybe its better to clean this one up, and add a second new service.

If we're going to keep the old service around to avoid breakage, I see no compelling reason to create a duplicate service just to have a different name. Maybe long-term we can find a better solution, but for now, I advocate sticking with the original sshguard-socklog name.

The latest push restores the name, drops the gratuitous service checks and improves the configuration logic. It is now possible to define empty variables for the log source and blacklist databases and, if they are explicitly cleared by the user, defaults will not be subsituted by the run script. However, if the variables are defined by the user or not explicitly cleared, the proper command arguments will be passed. The new behavior allows total customization of the sshguard invocation while still making common configuration alterations straightforward.

  parent reply	other threads:[~2020-01-23  1:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22 21:41 [PR PATCH] " voidlinux-github
2020-01-22 21:49 ` voidlinux-github
2020-01-23  0:54 ` [PR PATCH] [Updated] " voidlinux-github
2020-01-23  1:03 ` voidlinux-github [this message]
2020-01-23 10:53 ` [PR PATCH] [Merged]: " voidlinux-github
2020-01-23 10:53 ` voidlinux-github
2020-01-23 14:31 ` voidlinux-github

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200123010344.RkuoXxsfrXKKOFuSxE2Vy3Js6UWXB8mHIIuxmsn2-_w@z \
    --to=voidlinux-github@inbox.vuxu.org \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).