From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: Re: New Package: Scikit-video 1.1.11
Date: Sun, 02 Feb 2020 00:56:07 +0100 [thread overview]
Message-ID: <20200201235607.3BPbSvf7dsQ_o01U0sjt95MXwqkbvbXbZJIF_eh5skA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18709@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 566 bytes --]
New comment by jnbr on void-packages repository
https://github.com/void-linux/void-packages/pull/18709#issuecomment-581082118
Comment:
Having the force pushes in the PR history is intentional and simplifies reviews.
> Any input? Or can this be merged as is?
According to `/usr/lib/python3.8/site-packages/scikit_video-1.1.11-py3.8.egg-info/requires.txt`, the package depends on numpy, scipy and pillow.
Please add the corresponding packages do `depends`.
You could also use a more informative and less redundant `short_desc`.
Otherwise, looks good to me.
next prev parent reply other threads:[~2020-02-01 23:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 8:30 [PR PATCH] " voidlinux-github
2020-02-01 18:07 ` voidlinux-github
2020-02-01 18:08 ` voidlinux-github
2020-02-01 19:49 ` voidlinux-github
2020-02-01 19:58 ` [PR PATCH] [Updated] " voidlinux-github
2020-02-01 19:58 ` voidlinux-github
2020-02-01 20:33 ` voidlinux-github
2020-02-01 21:59 ` [PR PATCH] [Updated] " voidlinux-github
2020-02-01 22:41 ` voidlinux-github
2020-02-01 23:56 ` voidlinux-github [this message]
2020-02-02 1:22 ` [PR PATCH] [Updated] " voidlinux-github
2020-02-02 19:49 ` voidlinux-github
2020-02-08 19:39 ` voidlinux-github
2020-02-08 21:31 ` [PR PATCH] [Merged]: " voidlinux-github
2020-02-09 16:56 ` voidlinux-github
2020-02-09 17:32 ` voidlinux-github
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200201235607.3BPbSvf7dsQ_o01U0sjt95MXwqkbvbXbZJIF_eh5skA@z \
--to=voidlinux-github@inbox.vuxu.org \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).