Github messages for voidlinux
 help / color / mirror / Atom feed
From: voidlinux-github@inbox.vuxu.org
To: ml@inbox.vuxu.org
Subject: Re: [WIP] New package: dino-0.1.0
Date: Thu, 06 Feb 2020 06:44:24 +0100	[thread overview]
Message-ID: <20200206054424.bpKeWP6LiwgE6Xh0ZT4TfTNGMvE8mwD7J4g3clAmXsc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-18648@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1899 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-582747063

Comment:
So I did take a quick look at it. First for indentation use 1 tab in e.g. functions and 1 space for a newline inside a variable. Secondly as I said USE the build style, it seems like the cmake script generates a not fully working Makefile, but the Ninja one seems to work. Pls apply these changes ontop of what the current PR and work from there.
```diff
diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
index 763e0b05dd..ed6f81e33c 100644
--- a/srcpkgs/dino/template
+++ b/srcpkgs/dino/template
@@ -2,10 +2,14 @@
 pkgname=dino
 version=0.1.0
 revision=1
-hostmakedepends="cmake ninja gettext unzip pkg-config vala"
+build_style=cmake
+configure_args="-G Ninja -DDINO_PLUGIN_ENABLED_notification-sound=ON
+ -DDINO_PLUGIN_ENABLED_omemo=OFF"
+make_cmd=ninja
+hostmakedepends="cmake ninja gettext unzip pkg-config vala glib-devel"
 makedepends="glib-devel qrencode-devel gtk+3-devel gpgme-devel
-			libgee08-devel libgcrypt-devel libsoup-devel
-			libsignal-protocol-c sqlite-devel libcanberra-devel"
+ libgee08-devel libgcrypt-devel libsoup-devel
+ libsignal-protocol-c sqlite-devel libcanberra-devel"
 short_desc="Modern XMPP (\"Jabber\") Chat Client using GTK+/Vala"
 maintainer="Anjandev Momi <anjan@momi.ca>"
 license="GPL-3.0-or-later"
@@ -13,14 +17,6 @@ homepage="https://github.com/dino/dino"
 distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
 checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"
 
-do_build() {
-		cmake -G Ninja -B build -S . \
-					-DCMAKE_INSTALL_PREFIX=/usr \
-					-DDINO_PLUGIN_ENABLED_notification-sound=ON \
-					-DDINO_PLUGIN_ENABLED_omemo=OFF
-		ninja -C build
-}
-
 do_install() {
-		vbin build/dino
+	vbin build/dino
 }
```


  parent reply	other threads:[~2020-02-06  5:44 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-30  2:34 [PR PATCH] " voidlinux-github
2020-01-30  3:11 ` [PR PATCH] [Updated] [WIP] " voidlinux-github
2020-01-30  3:18 ` voidlinux-github
2020-01-30  3:49 ` voidlinux-github
2020-01-30  5:39 ` [PR PATCH] [Updated] " voidlinux-github
2020-01-30  5:46 ` voidlinux-github
2020-01-30  5:50 ` voidlinux-github
2020-01-30  6:59 ` [PR PATCH] [Updated] " voidlinux-github
2020-01-30  7:01 ` voidlinux-github
2020-01-30  7:03 ` voidlinux-github
2020-01-30 21:31 ` voidlinux-github
2020-01-31  4:13 ` [PR PATCH] [Updated] " voidlinux-github
2020-01-31 15:32 ` voidlinux-github
2020-02-01  2:58 ` voidlinux-github
2020-02-01 22:38 ` voidlinux-github
2020-02-01 22:40 ` voidlinux-github
2020-02-01 22:53 ` voidlinux-github
2020-02-03 10:05 ` voidlinux-github
2020-02-03 16:49 ` voidlinux-github
2020-02-04  0:44 ` voidlinux-github
2020-02-04  2:20 ` [PR PATCH] [Updated] " voidlinux-github
2020-02-04  2:29 ` voidlinux-github
2020-02-04  2:55 ` voidlinux-github
2020-02-04  3:03 ` voidlinux-github
2020-02-04 10:19 ` voidlinux-github
2020-02-04 10:20 ` voidlinux-github
2020-02-04 10:22 ` voidlinux-github
2020-02-04 10:24 ` voidlinux-github
2020-02-04 10:25 ` voidlinux-github
2020-02-04 20:42 ` voidlinux-github
2020-02-05 21:09 ` voidlinux-github
2020-02-06  5:44 ` voidlinux-github [this message]
2020-02-06  5:44 ` [PR PATCH] [Closed]: " voidlinux-github
2020-02-06  5:44 ` voidlinux-github
2020-02-06  9:06 ` voidlinux-github
2020-02-06  9:08 ` voidlinux-github
2020-02-06  9:37 ` voidlinux-github
2020-02-06  9:49 ` voidlinux-github
2020-02-06 19:33 ` voidlinux-github
2020-02-07 22:21 ` voidlinux-github
2020-02-07 22:32 ` voidlinux-github
2020-02-07 22:33 ` [PR PATCH] [Merged]: " voidlinux-github

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200206054424.bpKeWP6LiwgE6Xh0ZT4TfTNGMvE8mwD7J4g3clAmXsc@z \
    --to=voidlinux-github@inbox.vuxu.org \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).