New comment by Johnnynator on void-packages repository https://github.com/void-linux/void-packages/pull/18648#issuecomment-582747063 Comment: So I did take a quick look at it. First for indentation use 1 tab in e.g. functions and 1 space for a newline inside a variable. Secondly as I said USE the build style, it seems like the cmake script generates a not fully working Makefile, but the Ninja one seems to work. Pls apply these changes ontop of what the current PR and work from there. ```diff diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template index 763e0b05dd..ed6f81e33c 100644 --- a/srcpkgs/dino/template +++ b/srcpkgs/dino/template @@ -2,10 +2,14 @@ pkgname=dino version=0.1.0 revision=1 -hostmakedepends="cmake ninja gettext unzip pkg-config vala" +build_style=cmake +configure_args="-G Ninja -DDINO_PLUGIN_ENABLED_notification-sound=ON + -DDINO_PLUGIN_ENABLED_omemo=OFF" +make_cmd=ninja +hostmakedepends="cmake ninja gettext unzip pkg-config vala glib-devel" makedepends="glib-devel qrencode-devel gtk+3-devel gpgme-devel - libgee08-devel libgcrypt-devel libsoup-devel - libsignal-protocol-c sqlite-devel libcanberra-devel" + libgee08-devel libgcrypt-devel libsoup-devel + libsignal-protocol-c sqlite-devel libcanberra-devel" short_desc="Modern XMPP (\"Jabber\") Chat Client using GTK+/Vala" maintainer="Anjandev Momi " license="GPL-3.0-or-later" @@ -13,14 +17,6 @@ homepage="https://github.com/dino/dino" distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz" checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d" -do_build() { - cmake -G Ninja -B build -S . \ - -DCMAKE_INSTALL_PREFIX=/usr \ - -DDINO_PLUGIN_ENABLED_notification-sound=ON \ - -DDINO_PLUGIN_ENABLED_omemo=OFF - ninja -C build -} - do_install() { - vbin build/dino + vbin build/dino } ```