[PR PATCH] New Package: Scikit-video 1.1.11

[PR PATCH] New Package: Scikit-video 1.1.11

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

There is a new pull request by ashbhat1 against master on the void-packages repository

https://github.com/ashbhat1/void-packages master
https://github.com/void-linux/void-packages/pull/18709

New Package: Scikit-video 1.1.11
Package for using Scikit-video.

A patch file from https://github.com/void-linux/void-packages/pull/18709.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-18709.patch --]
[-- Type: text/x-diff, Size: 2099 bytes --]

From 07f0dc127817db8eb6dffbbf8e5cf68e615d1c76 Mon Sep 17 00:00:00 2001
From: void_user <void@horribleapps.home>
Date: Sat, 1 Feb 2020 00:25:54 -0800
Subject: [PATCH 1/2] New package: python3-scikit-video-1.1.11

---
 srcpkgs/python3-scikit-video/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/python3-scikit-video/template

diff --git a/srcpkgs/python3-scikit-video/template b/srcpkgs/python3-scikit-video/template
new file mode 100644
index 00000000000..f043d10016b
--- /dev/null
+++ b/srcpkgs/python3-scikit-video/template
@@ -0,0 +1,20 @@
+# Template file for 'python3-scikit-video'
+pkgname=python3-scikit-video
+version=1.1.11
+revision=1
+wrksrc="scikit-video-${version}"
+build_style=python3-module
+pycompile_module="scikit-video"
+hostmakedepends="python3-setuptools"
+makedepends="python3-devel python3-numpy python3-scipy python3-Pillow"
+short_desc="Scikit video for Python"
+maintainer="ash"
+license="BSD-3-Clause"
+homepage="http://www.scikit-video.org/"
+distfiles="https://github.com/scikit-video/scikit-video/archive/${version}.tar.gz"
+checksum=0d28d9c08d43be56bd723c8387e90e599a5ce4b75c389717d190ccde0ef5d56f
+#alternatives="numpy:f2py:/usr/bin/scikit"
+
+post_install() {
+	vlicense COPYING
+}

From 92833ee2e6ec3c52092788e9bb26769318b7fec6 Mon Sep 17 00:00:00 2001
From: void_user <void@horribleapps.home>
Date: Sat, 1 Feb 2020 00:27:17 -0800
Subject: [PATCH 2/2] python3-scikit-video: update to 1.1.11.

---
 srcpkgs/python3-scikit-video/template | 1 -
 1 file changed, 1 deletion(-)

diff --git a/srcpkgs/python3-scikit-video/template b/srcpkgs/python3-scikit-video/template
index f043d10016b..3bec745882e 100644
--- a/srcpkgs/python3-scikit-video/template
+++ b/srcpkgs/python3-scikit-video/template
@@ -13,7 +13,6 @@ license="BSD-3-Clause"
 homepage="http://www.scikit-video.org/"
 distfiles="https://github.com/scikit-video/scikit-video/archive/${version}.tar.gz"
 checksum=0d28d9c08d43be56bd723c8387e90e599a5ce4b75c389717d190ccde0ef5d56f
-#alternatives="numpy:f2py:/usr/bin/scikit"
 
 post_install() {
 	vlicense COPYING

Re: New Package: Scikit-video 1.1.11

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by ashbhat1 on void-packages repository

https://github.com/void-linux/void-packages/pull/18709#issuecomment-581054695

Comment:
How can I rerun xlint on my computer to recreate the error from travis?

Re: New Package: Scikit-video 1.1.11

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

New comment by ashbhat1 on void-packages repository

https://github.com/void-linux/void-packages/pull/18709#issuecomment-581054695

Comment:
How can I run xlint on my computer to recreate the error from travis?
So far I have only run xbps-src, which only builds the package.

Re: New Package: Scikit-video 1.1.11

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/18709#issuecomment-581063347

Comment:
> How can I run xlint on my computer to recreate the error from travis?

xlint is part of the xtools package. After installing run `xlint  srcpkgs/python3-scikit-video/template`.

Re: [PR PATCH] [Updated] New Package: Scikit-video 1.1.11

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

There is an updated pull request by ashbhat1 against master on the void-packages repository

https://github.com/ashbhat1/void-packages master
https://github.com/void-linux/void-packages/pull/18709

New Package: Scikit-video 1.1.11
Package for using Scikit-video.

A patch file from https://github.com/void-linux/void-packages/pull/18709.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-18709.patch --]
[-- Type: text/x-diff, Size: 2190 bytes --]

From 07f0dc127817db8eb6dffbbf8e5cf68e615d1c76 Mon Sep 17 00:00:00 2001
From: void_user <void@horribleapps.home>
Date: Sat, 1 Feb 2020 00:25:54 -0800
Subject: [PATCH 1/2] New package: python3-scikit-video-1.1.11

---
 srcpkgs/python3-scikit-video/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/python3-scikit-video/template

diff --git a/srcpkgs/python3-scikit-video/template b/srcpkgs/python3-scikit-video/template
new file mode 100644
index 00000000000..f043d10016b
--- /dev/null
+++ b/srcpkgs/python3-scikit-video/template
@@ -0,0 +1,20 @@
+# Template file for 'python3-scikit-video'
+pkgname=python3-scikit-video
+version=1.1.11
+revision=1
+wrksrc="scikit-video-${version}"
+build_style=python3-module
+pycompile_module="scikit-video"
+hostmakedepends="python3-setuptools"
+makedepends="python3-devel python3-numpy python3-scipy python3-Pillow"
+short_desc="Scikit video for Python"
+maintainer="ash"
+license="BSD-3-Clause"
+homepage="http://www.scikit-video.org/"
+distfiles="https://github.com/scikit-video/scikit-video/archive/${version}.tar.gz"
+checksum=0d28d9c08d43be56bd723c8387e90e599a5ce4b75c389717d190ccde0ef5d56f
+#alternatives="numpy:f2py:/usr/bin/scikit"
+
+post_install() {
+	vlicense COPYING
+}

From da431727b355dfd94d983b1ac7aebf43689f9321 Mon Sep 17 00:00:00 2001
From: void_user <void@horribleapps.home>
Date: Sat, 1 Feb 2020 00:27:17 -0800
Subject: [PATCH 2/2] python3-scikit-video: update to 1.1.11. fixed xlint
 issues by adding email address under maintainer and removing pycompile_module

---
 srcpkgs/python3-scikit-video/template | 1 -
 1 file changed, 1 deletion(-)

diff --git a/srcpkgs/python3-scikit-video/template b/srcpkgs/python3-scikit-video/template
index f043d10016b..3bec745882e 100644
--- a/srcpkgs/python3-scikit-video/template
+++ b/srcpkgs/python3-scikit-video/template
@@ -13,7 +13,6 @@ license="BSD-3-Clause"
 homepage="http://www.scikit-video.org/"
 distfiles="https://github.com/scikit-video/scikit-video/archive/${version}.tar.gz"
 checksum=0d28d9c08d43be56bd723c8387e90e599a5ce4b75c389717d190ccde0ef5d56f
-#alternatives="numpy:f2py:/usr/bin/scikit"
 
 post_install() {
 	vlicense COPYING

Re: New Package: Scikit-video 1.1.11

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New comment by ashbhat1 on void-packages repository

https://github.com/void-linux/void-packages/pull/18709#issuecomment-581064087

Comment:
@jnbr Thanks! That helped.

Re: New Package: Scikit-video 1.1.11

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

New comment by ashbhat1 on void-packages repository

https://github.com/void-linux/void-packages/pull/18709#issuecomment-581066801

Comment:
ok, It seems the commit didn't implement my change. I need to go back and fix it, I tried using git commit --amend and git push -f. I am trying to see how I won't pollute the merge request.

Re: [PR PATCH] [Updated] New Package: Scikit-video 1.1.11

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

There is an updated pull request by ashbhat1 against master on the void-packages repository

https://github.com/ashbhat1/void-packages master
https://github.com/void-linux/void-packages/pull/18709

New Package: Scikit-video 1.1.11
Package for using Scikit-video.

A patch file from https://github.com/void-linux/void-packages/pull/18709.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-18709.patch --]
[-- Type: text/x-diff, Size: 1189 bytes --]

From b4a45861ad2c86643702d8ecd9b147b6047285af Mon Sep 17 00:00:00 2001
From: void_user <void@horribleapps.home>
Date: Sat, 1 Feb 2020 13:56:15 -0800
Subject: [PATCH] added python scikit-video

---
 srcpkgs/python3-scikit-video/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/python3-scikit-video/template

diff --git a/srcpkgs/python3-scikit-video/template b/srcpkgs/python3-scikit-video/template
new file mode 100644
index 00000000000..536eb2a9ecf
--- /dev/null
+++ b/srcpkgs/python3-scikit-video/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-scikit-video'
+pkgname=python3-scikit-video
+version=1.1.11
+revision=1
+wrksrc="scikit-video-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+makedepends="python3-devel python3-numpy python3-scipy python3-Pillow"
+short_desc="Scikit video for Python"
+maintainer="ash <bhat40436@gmail.com>"
+license="BSD-3-Clause"
+homepage="http://www.scikit-video.org/"
+distfiles="https://github.com/scikit-video/scikit-video/archive/${version}.tar.gz"
+checksum=0d28d9c08d43be56bd723c8387e90e599a5ce4b75c389717d190ccde0ef5d56f
+
+post_install() {
+	vlicense COPYING
+}

Re: New Package: Scikit-video 1.1.11

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

New comment by ashbhat1 on void-packages repository

https://github.com/void-linux/void-packages/pull/18709#issuecomment-581076767

Comment:
ok, I changed my commit history to only include the last commit. For some reason on the pull request all the commits are showing up. Any input? Or can this be merged as is?

Re: New Package: Scikit-video 1.1.11

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/18709#issuecomment-581082118

Comment:
Having the force pushes in the PR history is intentional and simplifies reviews.

> Any input? Or can this be merged as is?

According to `/usr/lib/python3.8/site-packages/scikit_video-1.1.11-py3.8.egg-info/requires.txt`, the package depends on numpy, scipy and pillow.
Please add the corresponding packages do `depends`.
You could also use a more informative and less redundant `short_desc`.
Otherwise, looks good to me.

Re: [PR PATCH] [Updated] New Package: Scikit-video 1.1.11

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

There is an updated pull request by ashbhat1 against master on the void-packages repository

https://github.com/ashbhat1/void-packages master
https://github.com/void-linux/void-packages/pull/18709

New Package: Scikit-video 1.1.11
Package for using Scikit-video.

A patch file from https://github.com/void-linux/void-packages/pull/18709.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-18709.patch --]
[-- Type: text/x-diff, Size: 2225 bytes --]

From b4a45861ad2c86643702d8ecd9b147b6047285af Mon Sep 17 00:00:00 2001
From: void_user <void@horribleapps.home>
Date: Sat, 1 Feb 2020 13:56:15 -0800
Subject: [PATCH 1/2] added python scikit-video

---
 srcpkgs/python3-scikit-video/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/python3-scikit-video/template

diff --git a/srcpkgs/python3-scikit-video/template b/srcpkgs/python3-scikit-video/template
new file mode 100644
index 00000000000..536eb2a9ecf
--- /dev/null
+++ b/srcpkgs/python3-scikit-video/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-scikit-video'
+pkgname=python3-scikit-video
+version=1.1.11
+revision=1
+wrksrc="scikit-video-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+makedepends="python3-devel python3-numpy python3-scipy python3-Pillow"
+short_desc="Scikit video for Python"
+maintainer="ash <bhat40436@gmail.com>"
+license="BSD-3-Clause"
+homepage="http://www.scikit-video.org/"
+distfiles="https://github.com/scikit-video/scikit-video/archive/${version}.tar.gz"
+checksum=0d28d9c08d43be56bd723c8387e90e599a5ce4b75c389717d190ccde0ef5d56f
+
+post_install() {
+	vlicense COPYING
+}

From f9ac6a744dedafe8470c7b71180b35f57b4464cb Mon Sep 17 00:00:00 2001
From: void_user <void@horribleapps.home>
Date: Sat, 1 Feb 2020 17:22:44 -0800
Subject: [PATCH 2/2] added information relevant for requires.txt and add more
 information into short_desc

---
 srcpkgs/python3-scikit-video/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/python3-scikit-video/template b/srcpkgs/python3-scikit-video/template
index 536eb2a9ecf..9aab2425cb5 100644
--- a/srcpkgs/python3-scikit-video/template
+++ b/srcpkgs/python3-scikit-video/template
@@ -6,7 +6,8 @@ wrksrc="scikit-video-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 makedepends="python3-devel python3-numpy python3-scipy python3-Pillow"
-short_desc="Scikit video for Python"
+depends="python3-numpy python3-scipy python3-Pillow"
+short_desc="Video processing in Python. Modeled around scikit packages"
 maintainer="ash <bhat40436@gmail.com>"
 license="BSD-3-Clause"
 homepage="http://www.scikit-video.org/"

Re: New Package: Scikit-video 1.1.11

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/18709#issuecomment-581170105

Comment:
That's better.
Sorry for nitpicking but please keep short_desc down to one sentence.
Also, please squash your commits again.

Re: New Package: Scikit-video 1.1.11

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New comment by ashbhat1 on void-packages repository

https://github.com/void-linux/void-packages/pull/18709#issuecomment-583769732

Comment:
Ok, I believe I made all the fixes.

Re: [PR PATCH] [Merged]: New Package: Scikit-video 1.1.11

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

There's a merged pull request on the void-packages repository

New Package: Scikit-video 1.1.11
https://github.com/void-linux/void-packages/pull/18709

Description:
Package for using Scikit-video.

Re: New Package: Scikit-video 1.1.11

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/18709#issuecomment-583867842

Comment:
bad commit message, should've been fixed first

Re: New Package: Scikit-video 1.1.11

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/18709#issuecomment-583871529

Comment:
Damn, missed that. Sorry.