[-- Attachment #1: Type: text/plain, Size: 226 bytes --] New comment by xtraeme on void-packages repository https://github.com/void-linux/void-packages/pull/18977#issuecomment-583857450 Comment: Sounds good, but as a non native english speaker I can't say if it's ok. any help?
[-- Attachment #1: Type: text/plain, Size: 483 bytes --] New comment by Noah-Huppert on void-packages repository https://github.com/void-linux/void-packages/pull/18977#issuecomment-583858064 Comment: It sounds a small bit awkward to me, native English speaker, but unsure how to fix. Maybe: > wrksrc The directory name where the package sources are extracted, by default set to ${pkgname}-${version}. If the top level directory of a package's distfile is different than the default: wrksrc must be set to the top level directory name.
[-- Attachment #1: Type: text/plain, Size: 200 bytes --] New comment by pullmoll on void-packages repository https://github.com/void-linux/void-packages/pull/18977#issuecomment-583858393 Comment: I'd suggest "different … from" not "different … than".
[-- Attachment #1: Type: text/plain, Size: 222 bytes --] New comment by pullmoll on void-packages repository https://github.com/void-linux/void-packages/pull/18977#issuecomment-583858393 Comment: I'd suggest "different … from" not "different … than". And remove the colon.
[-- Attachment #1: Type: text/plain, Size: 269 bytes --] New comment by pullmoll on void-packages repository https://github.com/void-linux/void-packages/pull/18977#issuecomment-583858393 Comment: I'd suggest "different … from" not "different … than". And remove the colon. Finally I would append ` inside the archive`.
[-- Attachment #1: Type: text/plain, Size: 431 bytes --] New comment by pullmoll on void-packages repository https://github.com/void-linux/void-packages/pull/18977#issuecomment-583858393 Comment: I'd suggest "different … from" not "different … than". And remove the colon. Finally I would append ` inside the archive`. *If the top level directory of a package's `distfile` is different from the default, `wrksrc` must be set to the top level directory name inside the archive.*
[-- Attachment #1: Type: text/plain, Size: 164 bytes --] New comment by q66 on void-packages repository https://github.com/void-linux/void-packages/pull/18977#issuecomment-583866162 Comment: Also, comma after "default"
[-- Attachment #1: Type: text/plain, Size: 164 bytes --] New comment by q66 on void-packages repository https://github.com/void-linux/void-packages/pull/18977#issuecomment-583866162 Comment: Also, comma after "default"
[-- Attachment #1: Type: text/plain, Size: 163 bytes --] New comment by q66 on void-packages repository https://github.com/void-linux/void-packages/pull/18977#issuecomment-583866226 Comment: The above looks good to me
[-- Attachment #1: Type: text/plain, Size: 534 bytes --] New comment by Noah-Huppert on void-packages repository https://github.com/void-linux/void-packages/pull/18977#issuecomment-583867738 Comment: Thanks for the suggestions, now: > wrksrc The directory name where the package sources are extracted, by default set to ${pkgname}-${version}. If the top level directory of a package's distfile is different from the default wrksrc must be set to the top level directory name inside the archive. Should I squash this change into 1 commit similar to how new pkg PRs must be formatted?
[-- Attachment #1: Type: text/plain, Size: 199 bytes --] New comment by pullmoll on void-packages repository https://github.com/void-linux/void-packages/pull/18977#issuecomment-583876835 Comment: Yes, please squash. The comma after *default* is missing.
[-- Attachment #1: Type: text/plain, Size: 168 bytes --] New comment by Noah-Huppert on void-packages repository https://github.com/void-linux/void-packages/pull/18977#issuecomment-583919200 Comment: Added comma, squashed.
[-- Attachment #1: Type: text/plain, Size: 513 bytes --] There's a merged pull request on the void-packages repository Improved wrksrc variable documentation https://github.com/void-linux/void-packages/pull/18977 Description: As a new contributor the behavior of the `wrksrc` variable in package template files confused me and led to some confusing "cannot access wrksrc" errors when a package's `distfiles` are not named what `xbps-src` expects them to be by default. This PR adds what I learned about `wrksrc` and how it ties to `distfiles` to the documentation.