* Re: xbps-src: have cmdline arguments take precedence over config files
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19055@inbox.vuxu.org>
@ 2020-02-12 12:05 ` voidlinux-github
2020-02-12 12:10 ` voidlinux-github
` (5 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2020-02-12 12:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/19055#issuecomment-585174608
Comment:
@xtraeme fixed, also fixed some other things (masterdir/hostdir wasn't properly passed through for reexec e.g. when doing 32-bit builds)... should be good now
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: xbps-src: have cmdline arguments take precedence over config files
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19055@inbox.vuxu.org>
2020-02-12 12:05 ` xbps-src: have cmdline arguments take precedence over config files voidlinux-github
@ 2020-02-12 12:10 ` voidlinux-github
2020-02-12 12:12 ` voidlinux-github
` (4 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2020-02-12 12:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 350 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/19055#issuecomment-585176450
Comment:
Btw, does exporting or not matter much? when you specify them in config file, you generally don't export and they still work; it doesn't seem like it matters if they're exposed to subprocesses in this case or not.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: xbps-src: have cmdline arguments take precedence over config files
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19055@inbox.vuxu.org>
2020-02-12 12:05 ` xbps-src: have cmdline arguments take precedence over config files voidlinux-github
2020-02-12 12:10 ` voidlinux-github
@ 2020-02-12 12:12 ` voidlinux-github
2020-02-12 12:13 ` voidlinux-github
` (3 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2020-02-12 12:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 219 bytes --]
New comment by xtraeme on void-packages repository
https://github.com/void-linux/void-packages/pull/19055#issuecomment-585177034
Comment:
Does not matter much but the env contains stuff that is redundant or useless.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: xbps-src: have cmdline arguments take precedence over config files
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19055@inbox.vuxu.org>
` (2 preceding siblings ...)
2020-02-12 12:12 ` voidlinux-github
@ 2020-02-12 12:13 ` voidlinux-github
2020-02-12 12:14 ` voidlinux-github
` (2 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2020-02-12 12:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 461 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/19055#issuecomment-585177328
Comment:
There may be an edge case when a template wishes to read these variables inside a shell script it executes. Maybe we should just force-export the real vars after the config file is read?
e.g.
```
.... handling of opts....
.... handling of config files...
[ -n "$XBPS_ARG_FOO" ] && XBPS_FOO=bar
export XBPS_FOO
```
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: xbps-src: have cmdline arguments take precedence over config files
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19055@inbox.vuxu.org>
` (3 preceding siblings ...)
2020-02-12 12:13 ` voidlinux-github
@ 2020-02-12 12:14 ` voidlinux-github
2020-02-12 12:14 ` voidlinux-github
2020-02-12 12:21 ` voidlinux-github
6 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2020-02-12 12:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 145 bytes --]
New comment by xtraeme on void-packages repository
https://github.com/void-linux/void-packages/pull/19055#issuecomment-585177613
Comment:
Yeah
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: xbps-src: have cmdline arguments take precedence over config files
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19055@inbox.vuxu.org>
` (4 preceding siblings ...)
2020-02-12 12:14 ` voidlinux-github
@ 2020-02-12 12:14 ` voidlinux-github
2020-02-12 12:21 ` voidlinux-github
6 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2020-02-12 12:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 608 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/19055#issuecomment-585177328
Comment:
There may be an edge case when a template wishes to read these variables inside a shell script it executes. Maybe we should just force-export the real vars after the config file is read?
e.g.
```
.... handling of opts....
.... handling of config files...
[ -n "$XBPS_ARG_FOO" ] && XBPS_FOO=bar
export XBPS_FOO
```
That would ensure consistent behavior with when the var is specified on command line (exported) vs when it's specified in config (not exported)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: xbps-src: have cmdline arguments take precedence over config files
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19055@inbox.vuxu.org>
` (5 preceding siblings ...)
2020-02-12 12:14 ` voidlinux-github
@ 2020-02-12 12:21 ` voidlinux-github
6 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2020-02-12 12:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 164 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/19055#issuecomment-585180452
Comment:
@xtraeme check again please
^ permalink raw reply [flat|nested] 7+ messages in thread