Re: xbps-src: have cmdline arguments take precedence over config files

Re: xbps-src: have cmdline arguments take precedence over config files

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/19055#issuecomment-585176450

Comment:
Btw, does exporting or not matter much? when you specify them in config file, you generally don't export and they still work; it doesn't seem like it matters if they're exposed to subprocesses in this case or not.

Re: xbps-src: have cmdline arguments take precedence over config files

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/19055#issuecomment-585177034

Comment:
Does not matter much but the env contains stuff that is redundant or useless. 

Re: xbps-src: have cmdline arguments take precedence over config files

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/19055#issuecomment-585177328

Comment:
There may be an edge case when a template wishes to read these variables inside a shell script it executes. Maybe we should just force-export the real vars after the config file is read?

e.g.

```
.... handling of opts....
.... handling of config files...
[ -n "$XBPS_ARG_FOO" ] && XBPS_FOO=bar
export XBPS_FOO
```

Re: xbps-src: have cmdline arguments take precedence over config files

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/19055#issuecomment-585177613

Comment:
Yeah

Re: xbps-src: have cmdline arguments take precedence over config files

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 608 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/19055#issuecomment-585177328

Comment:
There may be an edge case when a template wishes to read these variables inside a shell script it executes. Maybe we should just force-export the real vars after the config file is read?

e.g.

```
.... handling of opts....
.... handling of config files...
[ -n "$XBPS_ARG_FOO" ] && XBPS_FOO=bar
export XBPS_FOO
```

That would ensure consistent behavior with when the var is specified on command line (exported) vs when it's specified in config (not exported)

Re: xbps-src: have cmdline arguments take precedence over config files

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/19055#issuecomment-585180452

Comment:
@xtraeme check again please

Re: [PR PATCH] [Merged]: xbps-src: have cmdline arguments take precedence over config files

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 833 bytes --]

There's a merged pull request on the void-packages repository

xbps-src: have cmdline arguments take precedence over config files
https://github.com/void-linux/void-packages/pull/19055

Description:
This way we can e.g. have `XBPS_MAKEJOBS` set in config file while overriding it with `-j`.

This also notably changes some other semantics. Particularly:

1) Links in `hostdir`/`masterdir` are now always resolved regardless of how they are provided (via arg or via config)
2) The `-o` option for `xbps-src` specifying build options merges with whatever was previously specified in config file, instead of overriding. This makes more sense overall as options specified on command line
actually apply to every package built during that run.

This PR is in preparation for support for custom configurations via `-c configname`.

Re: xbps-src: have cmdline arguments take precedence over config files

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/19055#issuecomment-585174608

Comment:
@xtraeme fixed, also fixed some other things (masterdir/hostdir wasn't properly passed through for reexec e.g. when doing 32-bit builds)... should be good now