Github messages for voidlinux
 help / color / mirror / Atom feed
* Re: Update Manual.md
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19013@inbox.vuxu.org>
  2020-02-14  7:49 ` Update Manual.md voidlinux-github
@ 2020-02-15  2:22 ` NeelChotai
  2020-02-15 14:32 ` leahneukirchen
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 7+ messages in thread
From: NeelChotai @ 2020-02-15  2:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New comment by NeelChotai on void-packages repository

https://github.com/void-linux/void-packages/pull/19013#issuecomment-586544241

Comment:
> xbump adds an ending dot by default, I don't agree with this PR.

I've added a pull request to accompany this change: https://github.com/leahneukirchen/xtools/pull/168.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Update Manual.md
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19013@inbox.vuxu.org>
  2020-02-14  7:49 ` Update Manual.md voidlinux-github
  2020-02-15  2:22 ` NeelChotai
@ 2020-02-15 14:32 ` leahneukirchen
  2020-03-03 10:53 ` xtraeme
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 7+ messages in thread
From: leahneukirchen @ 2020-02-15 14:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/19013#issuecomment-586595893

Comment:
xbump adds a dot because that's how commit messages looked since 2010. I see no good reason to change this now.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Update Manual.md
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19013@inbox.vuxu.org>
                   ` (2 preceding siblings ...)
  2020-02-15 14:32 ` leahneukirchen
@ 2020-03-03 10:53 ` xtraeme
  2020-03-03 12:16 ` NeelChotai
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 7+ messages in thread
From: xtraeme @ 2020-03-03 10:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/19013#issuecomment-593889025

Comment:
I agree with @leahneukirchen 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Update Manual.md
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19013@inbox.vuxu.org>
                   ` (3 preceding siblings ...)
  2020-03-03 10:53 ` xtraeme
@ 2020-03-03 12:16 ` NeelChotai
  2020-07-23 18:08 ` Chocimier
  2020-07-23 18:08 ` [PR PATCH] [Closed]: " Chocimier
  6 siblings, 0 replies; 7+ messages in thread
From: NeelChotai @ 2020-03-03 12:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

New comment by NeelChotai on void-packages repository

https://github.com/void-linux/void-packages/pull/19013#issuecomment-593921488

Comment:
It's inconsistent that the commit message for updating a package has an explicit trailing full stop whereas new, removed and modified package commits don't. Either all of them should have a full stop or none should.

However, this rule isn't stringent so it's more of a nitpick.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Update Manual.md
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19013@inbox.vuxu.org>
                   ` (4 preceding siblings ...)
  2020-03-03 12:16 ` NeelChotai
@ 2020-07-23 18:08 ` Chocimier
  2020-07-23 18:08 ` [PR PATCH] [Closed]: " Chocimier
  6 siblings, 0 replies; 7+ messages in thread
From: Chocimier @ 2020-07-23 18:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/19013#issuecomment-663153875

Comment:
The current way is as good.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Closed]: Update Manual.md
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19013@inbox.vuxu.org>
                   ` (5 preceding siblings ...)
  2020-07-23 18:08 ` Chocimier
@ 2020-07-23 18:08 ` Chocimier
  6 siblings, 0 replies; 7+ messages in thread
From: Chocimier @ 2020-07-23 18:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

There's a closed pull request on the void-packages repository

Update Manual.md
https://github.com/void-linux/void-packages/pull/19013

Description:
annoying dot in commit message. different from the general style

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Update Manual.md
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19013@inbox.vuxu.org>
@ 2020-02-14  7:49 ` voidlinux-github
  2020-02-15  2:22 ` NeelChotai
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 7+ messages in thread
From: voidlinux-github @ 2020-02-14  7:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/19013#issuecomment-586139445

Comment:
xbump adds an ending dot by default, I don't agree with this PR.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-07-23 18:08 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19013@inbox.vuxu.org>
2020-02-14  7:49 ` Update Manual.md voidlinux-github
2020-02-15  2:22 ` NeelChotai
2020-02-15 14:32 ` leahneukirchen
2020-03-03 10:53 ` xtraeme
2020-03-03 12:16 ` NeelChotai
2020-07-23 18:08 ` Chocimier
2020-07-23 18:08 ` [PR PATCH] [Closed]: " Chocimier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).