From: q66 <q66@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: xbps-src -o does not seem to work anymore
Date: Tue, 25 Feb 2020 14:55:25 +0100 [thread overview]
Message-ID: <20200225135525.J7F72r5ZcUiSb3sVFTlF2X_x-S6KZzlpwJ_hTRo9jR8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19495@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 713 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/issues/19495#issuecomment-590878464
Comment:
My proposed fix would be something like...
1) run that line in `setup` pkg only if `$IN_CHROOT`; the main point of it seems to be that inside chroot, the generated `xbps-src.conf` is run
2) change generation of `xbps-src.conf` so that it doesn't just `grep` out variables from the real config file, as that's not very good - if you have any sort of conditional logic in your conf, or e.g. sourcing other confs, that will break - instead take a list of `XBPS_` variables that are set and actually set them for the generated config.
that should probably fix it for real
next prev parent reply other threads:[~2020-02-25 13:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 12:42 [ISSUE] " xtraeme
2020-02-25 13:26 ` q66
2020-02-25 13:49 ` q66
2020-02-25 13:55 ` q66 [this message]
2020-02-25 13:55 ` q66
2020-02-25 14:02 ` q66
2020-02-26 7:32 ` xtraeme
2020-02-26 7:44 ` q66
2020-03-02 9:58 ` xtraeme
2020-03-02 18:09 ` q66
2020-03-06 17:19 ` [ISSUE] [CLOSED] " xtraeme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225135525.J7F72r5ZcUiSb3sVFTlF2X_x-S6KZzlpwJ_hTRo9jR8@z \
--to=q66@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).