Github messages for voidlinux
 help / color / mirror / Atom feed
From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: mstflint-4.13.3
Date: Wed, 04 Mar 2020 02:04:05 +0100	[thread overview]
Message-ID: <20200304010405.VPsNRhU7wIHl6VPVDlQ8DJ30HMSMWL7Q2VpwYwhMB5U@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19569@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/19569#issuecomment-594251448

Comment:
I would do this instead:
```diff
diff --git a/srcpkgs/mstflint/template b/srcpkgs/mstflint/template
index 7ebe2bcd27..2a449956a4 100644
--- a/srcpkgs/mstflint/template
+++ b/srcpkgs/mstflint/template
@@ -1,8 +1,9 @@
 # Template file for 'mstflint'
 pkgname=mstflint
-version=4.13.3
+version=4.13.3r2
 revision=1
-subvers="-2"
+_version=${version/r/-}
+wrksrc=mstflint-${version%r*}
 build_style=gnu-configure
 configure_args="--enable-cs --enable-fw-mgr --enable-xml2"
 makedepends="boost-devel libcurl-devel libibmad-devel liblzma-devel libxml2-devel zlib-devel"
@@ -10,7 +11,7 @@ short_desc="Open source version of Mellanox Firmware Tools"
 maintainer="Rich Gannon <rich@richgannon.net>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/Mellanox/mstflint"
-distfiles="https://github.com/Mellanox/mstflint/releases/download/v${version}${subvers}/${pkgname}-${version}${subvers}.tar.gz"
+distfiles="https://github.com/Mellanox/mstflint/releases/download/v${_version}/${pkgname}-${_version}.tar.gz"
 checksum=3abc918311fc07e4add7564879bd4a8def8ccfed40962f31682c75f2ee8a58d1
 
 mstflint-devel_package() {
```

Anyway, cross-compile and musl build are broken.

  parent reply	other threads:[~2020-03-04  1:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19569@inbox.vuxu.org>
2020-03-04  1:03 ` sgn
2020-03-04  1:04 ` sgn [this message]
2020-03-04  1:33 ` sgn
2020-03-04  1:56 ` ArmedAviator
2020-04-03  0:34 ` [PR PATCH] [Closed]: " ArmedAviator

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200304010405.VPsNRhU7wIHl6VPVDlQ8DJ30HMSMWL7Q2VpwYwhMB5U@z \
    --to=sgn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).