Github messages for voidlinux
 help / color / mirror / Atom feed
From: avoidr <avoidr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: srain-1.0.1
Date: Sun, 15 Mar 2020 18:26:37 +0100	[thread overview]
Message-ID: <20200315172637.oJWhQFriJEVn4b1X1LpoZRDtlhr3rLfi2cp2l43VE-4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19928@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

New comment by avoidr on void-packages repository

https://github.com/void-linux/void-packages/pull/19928#issuecomment-599239766

Comment:
I was confused about the meaning of `-e` in make. I thought it is necessary for it to use environment variables, but it is only about precedence. The CFLAGS didn't get used because `-e` overrode them. `make` worked correctly without `-e`, using the env var and having flags appended from the Makefile.

The actual problem I had was being unable to set CC by environment, because the Makefile already set CC explicitly. The fix was to set CC conditionally based on whether it has its default value, or it has been redefined — basically falling back to a default if not otherwise specified.

  parent reply	other threads:[~2020-03-15 17:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19928@inbox.vuxu.org>
2020-03-14  7:51 ` New package: srain-1.0.0 travankor
2020-03-14  8:17 ` avoidr
2020-03-14  8:28 ` travankor
2020-03-14  8:30 ` avoidr
2020-03-14  8:33 ` travankor
2020-03-14  8:56 ` New package: srain-1.0.1 travankor
2020-03-14  8:57 ` avoidr
2020-03-14  8:57 ` avoidr
2020-03-14  9:07 ` travankor
2020-03-14  9:08 ` travankor
2020-03-14  9:09 ` travankor
2020-03-14  9:11 ` avoidr
2020-03-14  9:21 ` travankor
2020-03-14  9:24 ` avoidr
2020-03-14  9:36 ` travankor
2020-03-14  9:39 ` avoidr
2020-03-14 21:19 ` avoidr
2020-03-14 22:09 ` avoidr
2020-03-15  6:15 ` avoidr
2020-03-15 16:42 ` xtraeme
2020-03-15 17:26 ` avoidr [this message]
2020-03-15 17:27 ` avoidr
2020-03-18 17:04 ` avoidr
2020-03-28 21:24 ` [PR PATCH] [Merged]: " jnbr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200315172637.oJWhQFriJEVn4b1X1LpoZRDtlhr3rLfi2cp2l43VE-4@z \
    --to=avoidr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).