* Re: jetbrains-jdk-bin: add profile script to set 'IDEA_JDK'
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20175@inbox.vuxu.org>
@ 2020-03-18 17:21 ` Chocimier
2020-03-19 9:56 ` andrasi-istvan
` (7 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: Chocimier @ 2020-03-18 17:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 356 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/20175#issuecomment-600760395
Comment:
Other IDEs link jbr to own directory. @andrasi-istvan, please check if it works for idea too.
https://github.com/void-linux/void-packages/blob/36e878925bb231a3c2c608f8f94e9984da0c3ebf/srcpkgs/CLion/template#L69
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: jetbrains-jdk-bin: add profile script to set 'IDEA_JDK'
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20175@inbox.vuxu.org>
2020-03-18 17:21 ` jetbrains-jdk-bin: add profile script to set 'IDEA_JDK' Chocimier
@ 2020-03-19 9:56 ` andrasi-istvan
2020-03-19 9:57 ` andrasi-istvan
` (6 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: andrasi-istvan @ 2020-03-19 9:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]
New comment by andrasi-istvan on void-packages repository
https://github.com/void-linux/void-packages/pull/20175#issuecomment-601089446
Comment:
Hi!
Thanks for pointing that out. This package however is a JDK, not an IDE, so let me explain the whole situation.
In order to run a JetBrains IDE, I need a JDK. I for example installed both `openjdk8` and `openjdk11`. The JDK packages install profile scripts:
~~~
> cat /etc/profile.d/10_openjdk11.sh
export JAVA_HOME=${JAVA_HOME=/usr/lib/jvm/openjdk11}
> cat /etc/profile.d/10_openjdk8.sh
export JAVA_HOME=${JAVA_HOME=/usr/lib/jvm/java-1.8-openjdk}
~~~
Note that `10_openjdk8.sh` will override `10_openjdk11`, and IDEA picks up `JAVA_HOME`:
~~~
> cat ./bin/idea.sh
[...]
# Locate a JDK installation directory command -v will be used to run the IDE.
# Try (in order): IDEA_JDK, idea.jdk, ./jbr, ./jre64, JDK_HOME, JAVA_HOME, "java" in PATH.
[...]
~~~
As this package is also a JDK, I followed the same pattern, but instead of `JAVA_HOME` I choose `IDEA_JDK`, because I think most people would installs this package, expects the JetBrains JDK to be use by the IDEs, but not expect every java tool to use it
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: jetbrains-jdk-bin: add profile script to set 'IDEA_JDK'
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20175@inbox.vuxu.org>
2020-03-18 17:21 ` jetbrains-jdk-bin: add profile script to set 'IDEA_JDK' Chocimier
2020-03-19 9:56 ` andrasi-istvan
@ 2020-03-19 9:57 ` andrasi-istvan
2020-03-19 9:57 ` andrasi-istvan
` (5 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: andrasi-istvan @ 2020-03-19 9:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]
New comment by andrasi-istvan on void-packages repository
https://github.com/void-linux/void-packages/pull/20175#issuecomment-601089446
Comment:
Hi!
Thanks for pointing that out. This package however is a JDK, not an IDE, so let me explain the whole situation.
In order to run a JetBrains IDE, I need a JDK. I for example installed both `openjdk8` and `openjdk11`. The JDK packages install profile scripts:
~~~
> cat /etc/profile.d/10_openjdk11.sh
export JAVA_HOME=${JAVA_HOME=/usr/lib/jvm/openjdk11}
> cat /etc/profile.d/10_openjdk8.sh
export JAVA_HOME=${JAVA_HOME=/usr/lib/jvm/java-1.8-openjdk}
~~~
Note that `10_openjdk8.sh` will override `10_openjdk11`, and IDEA picks up `JAVA_HOME`:
~~~
> cat ./bin/idea.sh
[...]
# Locate a JDK installation directory command -v will be used to run the IDE.
# Try (in order): IDEA_JDK, idea.jdk, ./jbr, ./jre64, JDK_HOME, JAVA_HOME, "java" in PATH.
[...]
~~~
As this package is also a JDK, I followed the same pattern, but instead of `JAVA_HOME` I choose `IDEA_JDK`, because I think most people would installs this package, expects the JetBrains JDK to be picked up by their IDE, but not expect other java tools to use it.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: jetbrains-jdk-bin: add profile script to set 'IDEA_JDK'
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20175@inbox.vuxu.org>
` (2 preceding siblings ...)
2020-03-19 9:57 ` andrasi-istvan
@ 2020-03-19 9:57 ` andrasi-istvan
2020-03-19 10:09 ` andrasi-istvan
` (4 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: andrasi-istvan @ 2020-03-19 9:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1184 bytes --]
New comment by andrasi-istvan on void-packages repository
https://github.com/void-linux/void-packages/pull/20175#issuecomment-601089446
Comment:
Hi!
Thanks for pointing that out. This package however is a JDK, not an IDE, so let me explain the whole situation.
In order to run a JetBrains IDE, I need a JDK. I for example installed both `openjdk8` and `openjdk11`. The JDK packages install profile scripts:
~~~
> cat /etc/profile.d/10_openjdk11.sh
export JAVA_HOME=${JAVA_HOME=/usr/lib/jvm/openjdk11}
> cat /etc/profile.d/10_openjdk8.sh
export JAVA_HOME=${JAVA_HOME=/usr/lib/jvm/java-1.8-openjdk}
~~~
Note that `10_openjdk8.sh` will override `10_openjdk11`, and IDEA picks up `JAVA_HOME`:
~~~
> cat ./bin/idea.sh
[...]
# Locate a JDK installation directory command -v will be used to run the IDE.
# Try (in order): IDEA_JDK, idea.jdk, ./jbr, ./jre64, JDK_HOME, JAVA_HOME, "java" in PATH.
[...]
~~~
As this package is also a JDK, I followed the same pattern, but instead of `JAVA_HOME` I choose `IDEA_JDK`, because I think most people who install this package, expect the JetBrains JDK to be picked up by their IDE, but not expect other java tools to use it.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: jetbrains-jdk-bin: add profile script to set 'IDEA_JDK'
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20175@inbox.vuxu.org>
` (3 preceding siblings ...)
2020-03-19 9:57 ` andrasi-istvan
@ 2020-03-19 10:09 ` andrasi-istvan
2020-03-19 10:10 ` andrasi-istvan
` (3 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: andrasi-istvan @ 2020-03-19 10:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
New comment by andrasi-istvan on void-packages repository
https://github.com/void-linux/void-packages/pull/20175#issuecomment-601095009
Comment:
Regarding other IDE packages: They create a symlink, which will be a dangling reference unless the JetBrains SDK is installed, and when that link becomes alive, the IDE will use it because of the precedence in the start script. This link however will break if this package changes the target directory from `/usr/lib/jvm/jbrsdk` to e.g. `/usr/lib/jvm/jetbrains-jdk`. But if you look at it, the link serves the same purpose as the `IDEA_JDK` variable, while the latter is more robust.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: jetbrains-jdk-bin: add profile script to set 'IDEA_JDK'
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20175@inbox.vuxu.org>
` (4 preceding siblings ...)
2020-03-19 10:09 ` andrasi-istvan
@ 2020-03-19 10:10 ` andrasi-istvan
2020-03-19 18:05 ` Chocimier
` (2 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: andrasi-istvan @ 2020-03-19 10:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
New comment by andrasi-istvan on void-packages repository
https://github.com/void-linux/void-packages/pull/20175#issuecomment-601095009
Comment:
Regarding other IDE packages: They create a symlink, which will be a dangling reference unless the JetBrains JDK is installed, and when that link becomes alive, the IDEs will use it because of the precedence in the start script (`./jbr` > `JAVA_HOME`). This link however will break if this package changes the target directory from `/usr/lib/jvm/jbrsdk` to e.g. `/usr/lib/jvm/jetbrains-jdk`. But if you look at it, the link serves the same purpose as the `IDEA_JDK` variable, while the latter is more robust.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: jetbrains-jdk-bin: add profile script to set 'IDEA_JDK'
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20175@inbox.vuxu.org>
` (5 preceding siblings ...)
2020-03-19 10:10 ` andrasi-istvan
@ 2020-03-19 18:05 ` Chocimier
2020-03-19 20:06 ` 2asoft
2020-03-19 20:54 ` [PR PATCH] [Merged]: " Chocimier
8 siblings, 0 replies; 9+ messages in thread
From: Chocimier @ 2020-03-19 18:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/20175#issuecomment-601332140
Comment:
Ok, the point about defining location of jbr by jbr, not its clients makes sense.
@2asoft, how do you like it?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: jetbrains-jdk-bin: add profile script to set 'IDEA_JDK'
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20175@inbox.vuxu.org>
` (6 preceding siblings ...)
2020-03-19 18:05 ` Chocimier
@ 2020-03-19 20:06 ` 2asoft
2020-03-19 20:54 ` [PR PATCH] [Merged]: " Chocimier
8 siblings, 0 replies; 9+ messages in thread
From: 2asoft @ 2020-03-19 20:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]
New comment by 2asoft on void-packages repository
https://github.com/void-linux/void-packages/pull/20175#issuecomment-601391442
Comment:
I think that's a great idea! Certainly seems more robust.
I have had trouble with pointing IDEA at the JDK, because it expects to be
looking at a slightly different subdirectory than their other IDEs.
So we'll need to test this out before merging changes to the IDE packages,
but the jbr change can be done now.
Thanks for making this better!
On Thu, Mar 19, 2020, 11:05 Piotr <notifications@github.com> wrote:
> Ok, the point about defining location of jbr by jbr, not its clients makes
> sense.
> @2asoft <https://github.com/2asoft>, how do you like it?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/void-linux/void-packages/pull/20175#issuecomment-601332140>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAI2RAE6K2EQ254HJB7EBQTRIJNIFANCNFSM4LN6UTDQ>
> .
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Merged]: jetbrains-jdk-bin: add profile script to set 'IDEA_JDK'
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20175@inbox.vuxu.org>
` (7 preceding siblings ...)
2020-03-19 20:06 ` 2asoft
@ 2020-03-19 20:54 ` Chocimier
8 siblings, 0 replies; 9+ messages in thread
From: Chocimier @ 2020-03-19 20:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
There's a merged pull request on the void-packages repository
jetbrains-jdk-bin: add profile script to set 'IDEA_JDK'
https://github.com/void-linux/void-packages/pull/20175
Description:
Hi!
I think it is reasonable for this package to configure `IDEA_JDK` to point to the newly installed JDK. This env var is picked up by IDEA (before checking `JAVA_HOME`), and I don't expect others to read it.
What do you think?
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-03-19 20:54 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20175@inbox.vuxu.org>
2020-03-18 17:21 ` jetbrains-jdk-bin: add profile script to set 'IDEA_JDK' Chocimier
2020-03-19 9:56 ` andrasi-istvan
2020-03-19 9:57 ` andrasi-istvan
2020-03-19 9:57 ` andrasi-istvan
2020-03-19 10:09 ` andrasi-istvan
2020-03-19 10:10 ` andrasi-istvan
2020-03-19 18:05 ` Chocimier
2020-03-19 20:06 ` 2asoft
2020-03-19 20:54 ` [PR PATCH] [Merged]: " Chocimier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).