Re: fscrypt: change build_style to gnu-makefile

Re: fscrypt: change build_style to gnu-makefile

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/20272#issuecomment-602237667

Comment:
Don't add `INSTALL.msg` this is reserved for important things.

Re: fscrypt: change build_style to gnu-makefile

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/20272#issuecomment-604249022

Comment:
@Duncaen I have reverted back to a go build style, because the aarch64 build was failing due to Go not knowing what kind of arch it was targetting. I just defined the do_* functions inside the template file itself, to use the Makefile provided by the project.

I also had to unset LDFLAGS when building, because otherwise it errored out with an `undefined reference to main`, which I suppose came from some weird interaction with LDFLAGS that led it to try building an executable instead of a shared library. I copied this fix from the go template file itself.

Right now it's building for all 64-bit targets on CI, which is actually better than what we previously had! I hope this makes it adequate for merging :)

Re: fscrypt: change build_style to gnu-makefile

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/20272#issuecomment-602391438

Comment:
Well, according to voidlinux.org/packages, this package was only succesfully built for aarch64, both glibc and musl, and x86_64, only glibc. So it doesn't have the best history in cross-compilation. Right now both x86_64 targets are working (which is better than before), but aarch64 isn't. That wouldn't make for a great update, I think.

What do you think about creating a separate package for the pam module and rule? Something like pam_fscrypt? This way the packages might get too fragmented, though.

Overall I feel like adding the pam module in some way is pretty important, because it enables what I feel is the most useful part of fscrypt.

Re: fscrypt: change build_style to gnu-makefile

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/20272#issuecomment-602298302

Comment:
So... yeah, this seems to have quite a few issues going on ith the build. Both with 32-bit systems and arch-specific compiler flags. What do you think would be the best way of resolving this kind of stuff? Making a few arch-dependent switches? I'm going to try and cross-compile the package locally to see what I can figure out.

Re: fscrypt: change build_style to gnu-makefile

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/20272#issuecomment-602251174

Comment:
I've fixed the issues you pointed out, and I will see if travis manages to build these now. Thanks for the help!

Re: fscrypt: change build_style to gnu-makefile

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/20272#issuecomment-602238234

Comment:
> I added nostrip because it didn't build with nopie, and then failed during one of the lints.

Then the build is wrong and doesn't respect the distributions `CFLAGS` and `LDFLAGS` if its not just the golang binaries.