Github messages for voidlinux
 help / color / mirror / Atom feed
* Re: fscrypt: change build_style to gnu-makefile
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20272@inbox.vuxu.org>
  2020-03-22 16:46 ` fscrypt: change build_style to gnu-makefile Duncaen
@ 2020-03-22 16:50 ` Duncaen
  2020-03-22 18:25 ` ericonr
                   ` (10 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: Duncaen @ 2020-03-22 16:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/20272#issuecomment-602238234

Comment:
> I added nostrip because it didn't build with nopie, and then failed during one of the lints.

Then the build is wrong and doesn't respect the distributions `CFLAGS` and `LDFLAGS` if its not just the golang binaries.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: fscrypt: change build_style to gnu-makefile
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20272@inbox.vuxu.org>
  2020-03-22 16:46 ` fscrypt: change build_style to gnu-makefile Duncaen
  2020-03-22 16:50 ` Duncaen
@ 2020-03-22 18:25 ` ericonr
  2020-03-22 23:37 ` ericonr
                   ` (9 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2020-03-22 18:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/20272#issuecomment-602251174

Comment:
I've fixed the issues you pointed out, and I will see if travis manages to build these now. Thanks for the help!

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: fscrypt: change build_style to gnu-makefile
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20272@inbox.vuxu.org>
                   ` (2 preceding siblings ...)
  2020-03-22 18:25 ` ericonr
@ 2020-03-22 23:37 ` ericonr
  2020-03-23  5:20 ` ericonr
                   ` (8 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2020-03-22 23:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/20272#issuecomment-602298302

Comment:
So... yeah, this seems to have quite a few issues going on ith the build. Both with 32-bit systems and arch-specific compiler flags. What do you think would be the best way of resolving this kind of stuff? Making a few arch-dependent switches? I'm going to try and cross-compile the package locally to see what I can figure out.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: fscrypt: change build_style to gnu-makefile
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20272@inbox.vuxu.org>
                   ` (3 preceding siblings ...)
  2020-03-22 23:37 ` ericonr
@ 2020-03-23  5:20 ` ericonr
  2020-03-26  6:10 ` ericonr
                   ` (7 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2020-03-23  5:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/20272#issuecomment-602391438

Comment:
Well, according to voidlinux.org/packages, this package was only succesfully built for aarch64, both glibc and musl, and x86_64, only glibc. So it doesn't have the best history in cross-compilation. Right now both x86_64 targets are working (which is better than before), but aarch64 isn't. That wouldn't make for a great update, I think.

What do you think about creating a separate package for the pam module and rule? Something like pam_fscrypt? This way the packages might get too fragmented, though.

Overall I feel like adding the pam module in some way is pretty important, because it enables what I feel is the most useful part of fscrypt.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: fscrypt: change build_style to gnu-makefile
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20272@inbox.vuxu.org>
                   ` (4 preceding siblings ...)
  2020-03-23  5:20 ` ericonr
@ 2020-03-26  6:10 ` ericonr
  2020-04-10 19:59 ` [PR PATCH] [Updated] fscrypt: also include pam module in package ericonr
                   ` (6 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2020-03-26  6:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/20272#issuecomment-604249022

Comment:
@Duncaen I have reverted back to a go build style, because the aarch64 build was failing due to Go not knowing what kind of arch it was targetting. I just defined the do_* functions inside the template file itself, to use the Makefile provided by the project.

I also had to unset LDFLAGS when building, because otherwise it errored out with an `undefined reference to main`, which I suppose came from some weird interaction with LDFLAGS that led it to try building an executable instead of a shared library. I copied this fix from the go template file itself.

Right now it's building for all 64-bit targets on CI, which is actually better than what we previously had! I hope this makes it adequate for merging :)

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Updated] fscrypt: also include pam module in package 
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20272@inbox.vuxu.org>
                   ` (5 preceding siblings ...)
  2020-03-26  6:10 ` ericonr
@ 2020-04-10 19:59 ` ericonr
  2020-04-10 20:04 ` ericonr
                   ` (5 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2020-04-10 19:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2139 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages master
https://github.com/void-linux/void-packages/pull/20272

fscrypt: also include pam module in package 
The previous build style used for fscrypt, go, meant that the fscrypt PAM module, pam_fscrypt.so, wasn't included in the package. This makes PAM integration impossible if the user doesn't compile and install the module themselves.

The /etc/pam.d/fscrypt config file, which is supposed to be created by packagers to allow fscrypt to use the login password, wasn't included in the package either.

The INSTALL.msg file was added to let users know they'd still need to configure some things if they wanted a fully integrated setup. This configuration information is currently held in the Arch Wiki, where it's formatted a bit better than it is in the projects's github page. I felt it disnecessary to repeat the steps in the message, but I can copy them if you feel it's necessary, or add them to the Void Documentation.

I feel this build script has a few hacks, so I wanted to post it here to see if you have any ideas about what can be done to fix it (or if it's ok as it is).

* I added `nostrip` because it didn't build with `nopie`, and then failed during one of the lints.
* `make_install_args`: I couldn't understand what was going on with the original Makefile, but it didn't work unless I had it exactly like this. Anything I tried with setting `DESTDIR` to something made the whole thing go up in flames.
* `make_install_target`: installing only the library avoids having to remove the binary from DESTDIR, because otherwise it appears in the wrong place. The binary is then copied manually in `post_install`.
 
I don't know what Void's instace on this is, but this isn't a reproducible build. I had noticed it when traipsing through the Makefile, where the buildtime is passed as a "define" to the toolchain. The PKGBUILD used by Arch also adds a patch to make the build reproducible.

A patch file from https://github.com/void-linux/void-packages/pull/20272.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-20272.patch --]
[-- Type: text/x-diff, Size: 2134 bytes --]

From 08204b5d2bb93e930d706647d9e042e5e7f854c6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 22 Mar 2020 01:33:15 -0300
Subject: [PATCH] fscrypt: update to 0.2.6 and include PAM module

The previous template used for fscrypt didn't include the fscrypt PAM
module, pam_fscrypt.so. This commit fixes this issue.

The /etc/pam.d/fscrypt config file, which is supposed to be created by
packagers to allow fscrypt to use the login password, wasn't included in
the package either. This commit also includes that file.
---
 srcpkgs/fscrypt/files/pam_config |  1 +
 srcpkgs/fscrypt/template         | 20 ++++++++++++++++----
 2 files changed, 17 insertions(+), 4 deletions(-)
 create mode 100644 srcpkgs/fscrypt/files/pam_config

diff --git a/srcpkgs/fscrypt/files/pam_config b/srcpkgs/fscrypt/files/pam_config
new file mode 100644
index 00000000000..7e5d75ae45d
--- /dev/null
+++ b/srcpkgs/fscrypt/files/pam_config
@@ -0,0 +1 @@
+auth required pam_unix.so
diff --git a/srcpkgs/fscrypt/template b/srcpkgs/fscrypt/template
index 2d81e8f4eee..8b12c2f55c4 100644
--- a/srcpkgs/fscrypt/template
+++ b/srcpkgs/fscrypt/template
@@ -1,10 +1,9 @@
 # Template file for 'fscrypt'
 pkgname=fscrypt
 version=0.2.6
-revision=1
-build_style=go
-go_import_path=github.com/google/fscrypt
-go_package="${go_import_path}/cmd/fscrypt"
+revision=2
+build_style=gnu-makefile
+hostmakedepends="go m4"
 makedepends="pam-devel"
 short_desc="Tool for managing Linux filesystem encryption"
 maintainer="Andrea Brancaleoni <abc@pomel.me>"
@@ -12,3 +11,16 @@ license="Apache-2.0"
 homepage="https://github.com/google/fscrypt"
 distfiles="https://github.com/google/fscrypt/archive/v${version}.tar.gz"
 checksum=bce54ebb716706150b759052665a29d01963d8df334ad9beb34105ce62d2de94
+conf_files="/etc/pam.d/fscrypt"
+
+make_install_args='PREFIX=${DESTDIR}/usr'
+make_install_target="install-pam"
+nostrip_files="fscrypt"
+
+post_install() {
+	vbin bin/fscrypt
+	# remove Ubuntu specific pam-config files
+	rm -rf ${DESTDIR}/usr/share/pam-configs/
+	# add PAM config file
+	vinstall ${FILESDIR}/pam_config 644 etc/pam.d fscrypt
+}

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Updated] fscrypt: also include pam module in package 
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20272@inbox.vuxu.org>
                   ` (6 preceding siblings ...)
  2020-04-10 19:59 ` [PR PATCH] [Updated] fscrypt: also include pam module in package ericonr
@ 2020-04-10 20:04 ` ericonr
  2020-04-10 20:26 ` ericonr
                   ` (4 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2020-04-10 20:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2139 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages master
https://github.com/void-linux/void-packages/pull/20272

fscrypt: also include pam module in package 
The previous build style used for fscrypt, go, meant that the fscrypt PAM module, pam_fscrypt.so, wasn't included in the package. This makes PAM integration impossible if the user doesn't compile and install the module themselves.

The /etc/pam.d/fscrypt config file, which is supposed to be created by packagers to allow fscrypt to use the login password, wasn't included in the package either.

The INSTALL.msg file was added to let users know they'd still need to configure some things if they wanted a fully integrated setup. This configuration information is currently held in the Arch Wiki, where it's formatted a bit better than it is in the projects's github page. I felt it disnecessary to repeat the steps in the message, but I can copy them if you feel it's necessary, or add them to the Void Documentation.

I feel this build script has a few hacks, so I wanted to post it here to see if you have any ideas about what can be done to fix it (or if it's ok as it is).

* I added `nostrip` because it didn't build with `nopie`, and then failed during one of the lints.
* `make_install_args`: I couldn't understand what was going on with the original Makefile, but it didn't work unless I had it exactly like this. Anything I tried with setting `DESTDIR` to something made the whole thing go up in flames.
* `make_install_target`: installing only the library avoids having to remove the binary from DESTDIR, because otherwise it appears in the wrong place. The binary is then copied manually in `post_install`.
 
I don't know what Void's instace on this is, but this isn't a reproducible build. I had noticed it when traipsing through the Makefile, where the buildtime is passed as a "define" to the toolchain. The PKGBUILD used by Arch also adds a patch to make the build reproducible.

A patch file from https://github.com/void-linux/void-packages/pull/20272.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-20272.patch --]
[-- Type: text/x-diff, Size: 2145 bytes --]

From 224b3725189aea301bcf27a40eaff8cbb1c585a8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 22 Mar 2020 01:33:15 -0300
Subject: [PATCH] fscrypt: update to 0.2.7 and include PAM module

The previous template used for fscrypt didn't include the fscrypt PAM
module, pam_fscrypt.so. This commit fixes this issue.

The /etc/pam.d/fscrypt config file, which is supposed to be created by
packagers to allow fscrypt to use the login password, wasn't included in
the package either. This commit also includes that file.
---
 srcpkgs/fscrypt/files/pam_config |  1 +
 srcpkgs/fscrypt/template         | 17 ++++++++++++++++-
 2 files changed, 17 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/fscrypt/files/pam_config

diff --git a/srcpkgs/fscrypt/files/pam_config b/srcpkgs/fscrypt/files/pam_config
new file mode 100644
index 00000000000..7e5d75ae45d
--- /dev/null
+++ b/srcpkgs/fscrypt/files/pam_config
@@ -0,0 +1 @@
+auth required pam_unix.so
diff --git a/srcpkgs/fscrypt/template b/srcpkgs/fscrypt/template
index 2d81e8f4eee..9ee1fa5a738 100644
--- a/srcpkgs/fscrypt/template
+++ b/srcpkgs/fscrypt/template
@@ -1,10 +1,11 @@
 # Template file for 'fscrypt'
 pkgname=fscrypt
-version=0.2.6
+version=0.2.7
 revision=1
 build_style=go
 go_import_path=github.com/google/fscrypt
 go_package="${go_import_path}/cmd/fscrypt"
+hostmakedepends="m4"
 makedepends="pam-devel"
 short_desc="Tool for managing Linux filesystem encryption"
 maintainer="Andrea Brancaleoni <abc@pomel.me>"
@@ -12,3 +13,17 @@ license="Apache-2.0"
 homepage="https://github.com/google/fscrypt"
 distfiles="https://github.com/google/fscrypt/archive/v${version}.tar.gz"
 checksum=bce54ebb716706150b759052665a29d01963d8df334ad9beb34105ce62d2de94
+conf_files="/etc/pam.d/fscrypt"
+
+if [ "$XBPS_TARGET_WORDSIZE" = "32" ];
+then
+	broken="fscrypt can't be built for 32-bit targets"
+fi
+
+post_install() {
+	LDFLAGS= make PREFIX=/usr DESTDIR=${DESTDIR} install-pam
+	# remove Ubuntu specific pam-config files
+	rm -rf ${DESTDIR}/usr/share/pam-configs/
+	# add PAM config file
+	vinstall ${FILESDIR}/pam_config 644 etc/pam.d fscrypt
+}

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Updated] fscrypt: also include pam module in package 
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20272@inbox.vuxu.org>
                   ` (7 preceding siblings ...)
  2020-04-10 20:04 ` ericonr
@ 2020-04-10 20:26 ` ericonr
  2020-04-10 20:42 ` ericonr
                   ` (3 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2020-04-10 20:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2139 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages master
https://github.com/void-linux/void-packages/pull/20272

fscrypt: also include pam module in package 
The previous build style used for fscrypt, go, meant that the fscrypt PAM module, pam_fscrypt.so, wasn't included in the package. This makes PAM integration impossible if the user doesn't compile and install the module themselves.

The /etc/pam.d/fscrypt config file, which is supposed to be created by packagers to allow fscrypt to use the login password, wasn't included in the package either.

The INSTALL.msg file was added to let users know they'd still need to configure some things if they wanted a fully integrated setup. This configuration information is currently held in the Arch Wiki, where it's formatted a bit better than it is in the projects's github page. I felt it disnecessary to repeat the steps in the message, but I can copy them if you feel it's necessary, or add them to the Void Documentation.

I feel this build script has a few hacks, so I wanted to post it here to see if you have any ideas about what can be done to fix it (or if it's ok as it is).

* I added `nostrip` because it didn't build with `nopie`, and then failed during one of the lints.
* `make_install_args`: I couldn't understand what was going on with the original Makefile, but it didn't work unless I had it exactly like this. Anything I tried with setting `DESTDIR` to something made the whole thing go up in flames.
* `make_install_target`: installing only the library avoids having to remove the binary from DESTDIR, because otherwise it appears in the wrong place. The binary is then copied manually in `post_install`.
 
I don't know what Void's instace on this is, but this isn't a reproducible build. I had noticed it when traipsing through the Makefile, where the buildtime is passed as a "define" to the toolchain. The PKGBUILD used by Arch also adds a patch to make the build reproducible.

A patch file from https://github.com/void-linux/void-packages/pull/20272.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-20272.patch --]
[-- Type: text/x-diff, Size: 2243 bytes --]

From 055569a70c9f6709ab54174c5b0061e33023c613 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 22 Mar 2020 01:33:15 -0300
Subject: [PATCH] fscrypt: update to 0.2.7 and include PAM module

The previous template used for fscrypt didn't include the fscrypt PAM
module, pam_fscrypt.so. This commit fixes this issue.

The /etc/pam.d/fscrypt config file, which is supposed to be created by
packagers to allow fscrypt to use the login password, wasn't included in
the package either. This commit also includes that file.
---
 srcpkgs/fscrypt/files/pam_config |  1 +
 srcpkgs/fscrypt/template         | 20 ++++++++++++++++++--
 2 files changed, 19 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/fscrypt/files/pam_config

diff --git a/srcpkgs/fscrypt/files/pam_config b/srcpkgs/fscrypt/files/pam_config
new file mode 100644
index 00000000000..7e5d75ae45d
--- /dev/null
+++ b/srcpkgs/fscrypt/files/pam_config
@@ -0,0 +1 @@
+auth required pam_unix.so
diff --git a/srcpkgs/fscrypt/template b/srcpkgs/fscrypt/template
index 2d81e8f4eee..23f8112dd6c 100644
--- a/srcpkgs/fscrypt/template
+++ b/srcpkgs/fscrypt/template
@@ -1,14 +1,30 @@
 # Template file for 'fscrypt'
 pkgname=fscrypt
-version=0.2.6
+version=0.2.7
 revision=1
 build_style=go
 go_import_path=github.com/google/fscrypt
 go_package="${go_import_path}/cmd/fscrypt"
+hostmakedepends="m4"
 makedepends="pam-devel"
 short_desc="Tool for managing Linux filesystem encryption"
 maintainer="Andrea Brancaleoni <abc@pomel.me>"
 license="Apache-2.0"
 homepage="https://github.com/google/fscrypt"
 distfiles="https://github.com/google/fscrypt/archive/v${version}.tar.gz"
-checksum=bce54ebb716706150b759052665a29d01963d8df334ad9beb34105ce62d2de94
+checksum=08e7f1bb5481f5ee76a90d79b9d9e2632f167d43100438ba08bd637e2dfb0f22
+conf_files="/etc/pam.d/fscrypt"
+
+if [ "$XBPS_TARGET_WORDSIZE" = "32" ];
+then
+	broken="fscrypt can't be built for 32-bit targets"
+fi
+
+post_install() {
+	# build and install the PAM module
+	LDFLAGS= make PREFIX=/usr DESTDIR=${DESTDIR} install-pam
+	# remove Ubuntu specific pam-config files
+	rm -rf ${DESTDIR}/usr/share/pam-configs/
+	# add PAM config file
+	vinstall ${FILESDIR}/pam_config 644 etc/pam.d fscrypt
+}

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: fscrypt: also include pam module in package 
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20272@inbox.vuxu.org>
                   ` (8 preceding siblings ...)
  2020-04-10 20:26 ` ericonr
@ 2020-04-10 20:42 ` ericonr
  2020-04-10 20:42 ` ericonr
                   ` (2 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2020-04-10 20:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/20272#issuecomment-612207829

Comment:
@Duncaen squashed and cleaned up commits, implemented your suggestions and the package is now building cleanly everywhere it can build cleanly. Any further changes?

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: fscrypt: also include pam module in package 
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20272@inbox.vuxu.org>
                   ` (9 preceding siblings ...)
  2020-04-10 20:42 ` ericonr
@ 2020-04-10 20:42 ` ericonr
  2020-04-11 22:19 ` [PR PATCH] [Merged]: " thypon
  2020-04-11 22:21 ` xtraeme
  12 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2020-04-10 20:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/20272#issuecomment-612207829

Comment:
@Duncaen squashed and cleaned up commits, implemented your suggestions and the package is now building cleanly everywhere it can build. Any further changes?

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Merged]: fscrypt: also include pam module in package 
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20272@inbox.vuxu.org>
                   ` (10 preceding siblings ...)
  2020-04-10 20:42 ` ericonr
@ 2020-04-11 22:19 ` thypon
  2020-04-11 22:21 ` xtraeme
  12 siblings, 0 replies; 13+ messages in thread
From: thypon @ 2020-04-11 22:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]

There's a merged pull request on the void-packages repository

fscrypt: also include pam module in package 
https://github.com/void-linux/void-packages/pull/20272

Description:
The previous build style used for fscrypt, go, meant that the fscrypt PAM module, pam_fscrypt.so, wasn't included in the package. This makes PAM integration impossible if the user doesn't compile and install the module themselves.

The /etc/pam.d/fscrypt config file, which is supposed to be created by packagers to allow fscrypt to use the login password, wasn't included in the package either.

The INSTALL.msg file was added to let users know they'd still need to configure some things if they wanted a fully integrated setup. This configuration information is currently held in the Arch Wiki, where it's formatted a bit better than it is in the projects's github page. I felt it disnecessary to repeat the steps in the message, but I can copy them if you feel it's necessary, or add them to the Void Documentation.

I feel this build script has a few hacks, so I wanted to post it here to see if you have any ideas about what can be done to fix it (or if it's ok as it is).

* I added `nostrip` because it didn't build with `nopie`, and then failed during one of the lints.
* `make_install_args`: I couldn't understand what was going on with the original Makefile, but it didn't work unless I had it exactly like this. Anything I tried with setting `DESTDIR` to something made the whole thing go up in flames.
* `make_install_target`: installing only the library avoids having to remove the binary from DESTDIR, because otherwise it appears in the wrong place. The binary is then copied manually in `post_install`.
 
I don't know what Void's instace on this is, but this isn't a reproducible build. I had noticed it when traipsing through the Makefile, where the buildtime is passed as a "define" to the toolchain. The PKGBUILD used by Arch also adds a patch to make the build reproducible.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: fscrypt: also include pam module in package 
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20272@inbox.vuxu.org>
                   ` (11 preceding siblings ...)
  2020-04-11 22:19 ` [PR PATCH] [Merged]: " thypon
@ 2020-04-11 22:21 ` xtraeme
  12 siblings, 0 replies; 13+ messages in thread
From: xtraeme @ 2020-04-11 22:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/20272#issuecomment-612525207

Comment:
Andrea could you please coordinate what ypu do with the others? Thanks 

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: fscrypt: change build_style to gnu-makefile
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20272@inbox.vuxu.org>
@ 2020-03-22 16:46 ` Duncaen
  2020-03-22 16:50 ` Duncaen
                   ` (11 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: Duncaen @ 2020-03-22 16:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/20272#issuecomment-602237667

Comment:
Don't add `INSTALL.msg` this is reserved for important things.

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2020-04-11 22:21 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20272@inbox.vuxu.org>
2020-03-22 16:46 ` fscrypt: change build_style to gnu-makefile Duncaen
2020-03-22 16:50 ` Duncaen
2020-03-22 18:25 ` ericonr
2020-03-22 23:37 ` ericonr
2020-03-23  5:20 ` ericonr
2020-03-26  6:10 ` ericonr
2020-04-10 19:59 ` [PR PATCH] [Updated] fscrypt: also include pam module in package ericonr
2020-04-10 20:04 ` ericonr
2020-04-10 20:26 ` ericonr
2020-04-10 20:42 ` ericonr
2020-04-10 20:42 ` ericonr
2020-04-11 22:19 ` [PR PATCH] [Merged]: " thypon
2020-04-11 22:21 ` xtraeme

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).