From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: fscrypt: change build_style to gnu-makefile
Date: Thu, 26 Mar 2020 07:10:30 +0100 [thread overview]
Message-ID: <20200326061030.-4eFXH_LaCRNaoTX24-fG-aCTmJR-sWU_lEG7yadXaQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20272@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/20272#issuecomment-604249022
Comment:
@Duncaen I have reverted back to a go build style, because the aarch64 build was failing due to Go not knowing what kind of arch it was targetting. I just defined the do_* functions inside the template file itself, to use the Makefile provided by the project.
I also had to unset LDFLAGS when building, because otherwise it errored out with an `undefined reference to main`, which I suppose came from some weird interaction with LDFLAGS that led it to try building an executable instead of a shared library. I copied this fix from the go template file itself.
Right now it's building for all 64-bit targets on CI, which is actually better than what we previously had! I hope this makes it adequate for merging :)
next prev parent reply other threads:[~2020-03-26 6:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20272@inbox.vuxu.org>
2020-03-22 16:46 ` Duncaen
2020-03-22 16:50 ` Duncaen
2020-03-22 18:25 ` ericonr
2020-03-22 23:37 ` ericonr
2020-03-23 5:20 ` ericonr
2020-03-26 6:10 ` ericonr [this message]
2020-04-10 19:59 ` [PR PATCH] [Updated] fscrypt: also include pam module in package ericonr
2020-04-10 20:04 ` ericonr
2020-04-10 20:26 ` ericonr
2020-04-10 20:42 ` ericonr
2020-04-10 20:42 ` ericonr
2020-04-11 22:19 ` [PR PATCH] [Merged]: " thypon
2020-04-11 22:21 ` xtraeme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326061030.-4eFXH_LaCRNaoTX24-fG-aCTmJR-sWU_lEG7yadXaQ@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).