From: q66 <q66@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: go: add build_style=go to avoid code duplication
Date: Mon, 30 Mar 2020 05:36:07 +0200 [thread overview]
Message-ID: <20200330033607.-afODJSFIug3wHuxmS_DUEwXaHHYovIYeigDLP1ufzs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20435@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 533 bytes --]
There's a closed pull request on the void-packages repository
go: add build_style=go to avoid code duplication
https://github.com/void-linux/void-packages/pull/20435
Description:
The GOARCH selection snippet was duplicated in the go build_style script
for environment variables and in the go template itself. Furthermore,
there were discrepancies between the two snippets, which have been
fixed.
This makes the go template leaner, and makes both cases more robust (changes to GOARCH selection can be done in a single place).
prev parent reply other threads:[~2020-03-30 3:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20435@inbox.vuxu.org>
2020-03-29 22:23 ` Johnnynator
2020-03-30 2:14 ` ericonr
2020-03-30 3:13 ` q66
2020-03-30 3:14 ` q66
2020-03-30 3:36 ` q66
2020-03-30 3:36 ` q66 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330033607.-afODJSFIug3wHuxmS_DUEwXaHHYovIYeigDLP1ufzs@z \
--to=q66@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).