Github messages for voidlinux
 help / color / mirror / Atom feed
From: the-antz <the-antz@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] apparmor: fix dhcpcd profile for dhcpcd version 9
Date: Sat, 11 Apr 2020 17:44:29 +0200	[thread overview]
Message-ID: <20200411154429.f9b4AGqS_7JRBzO2_UMioTAZ-7yuiK0CDeEzCRi5c8E@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20752@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

There is an updated pull request by the-antz against master on the void-packages repository

https://github.com/the-antz/void-packages apparmor
https://github.com/void-linux/void-packages/pull/20752

apparmor: fix dhcpcd profile for dhcpcd version 9
**edit**: this is fixed with the latest update of the dhcpcd package (thx duncaen).

------------

Some filename changes introduced by dhcpcd 9 seem unintended, like using
```
/run/pid
/run/sock
/run/unpriv.sock
```
instead of
```
/run/dhcpcd{-*,}.pid
/run/dhcpcd.sock
/run/dhcpcd.unpriv.sock
```
but the profile works for now.

A patch file from https://github.com/void-linux/void-packages/pull/20752.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-apparmor-20752.patch --]
[-- Type: text/x-diff, Size: 1860 bytes --]

From 7e565912ab852e999122f2d66ae1fd2226f1a907 Mon Sep 17 00:00:00 2001
From: Antz <antzz@protonmail.ch>
Date: Wed, 8 Apr 2020 12:40:03 +0200
Subject: [PATCH] apparmor: fix dhcpcd profile for dhcpcd version 9

---
 srcpkgs/apparmor/files/profiles/usr.bin.dhcpcd | 13 ++++++++++---
 srcpkgs/apparmor/template                      |  2 +-
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/apparmor/files/profiles/usr.bin.dhcpcd b/srcpkgs/apparmor/files/profiles/usr.bin.dhcpcd
index 65c3970ab15..26364f36385 100644
--- a/srcpkgs/apparmor/files/profiles/usr.bin.dhcpcd
+++ b/srcpkgs/apparmor/files/profiles/usr.bin.dhcpcd
@@ -7,9 +7,15 @@ profile dhcpcd /{usr/,}bin/dhcpcd {
   #include <abstractions/nameservice>
 
   capability chown,
+  capability fowner,
+  capability fsetid,
+  capability kill,
   capability net_admin,
   capability net_raw,
+  capability setuid,
+  capability setgid,
   capability sys_admin,
+  capability sys_chroot,
 
   network packet dgram,
   network inet raw,
@@ -26,9 +32,10 @@ profile dhcpcd /{usr/,}bin/dhcpcd {
   /proc/sys/net/ipv{4,6}/neigh/*/retrans_time_ms w,
   /proc/sys/net/ipv{4,6}/neigh/*/base_reachable_time_ms w,
 
-  /{var/,}run/dhcpcd{-*,}.pid rwk,
-  /{var/,}run/dhcpcd.sock rw,
-  /{var/,}run/dhcpcd.unpriv.sock rw,
+  /{var/,}run/dhcpcd/ w,
+  /{var/,}run/dhcpcd/{,*.}pid rwk,
+  /{var/,}run/dhcpcd/{,*.}sock rw,
+  /{var/,}run/dhcpcd/unpriv.sock rw,
   /{var/,}run/udev/data/* r,
 
   /sys/devices/**/net/*/uevent r,
diff --git a/srcpkgs/apparmor/template b/srcpkgs/apparmor/template
index a0e04bf6a61..cd7073fdcfb 100644
--- a/srcpkgs/apparmor/template
+++ b/srcpkgs/apparmor/template
@@ -1,7 +1,7 @@
 # Template file for 'apparmor'
 pkgname=apparmor
 version=2.13.4
-revision=1
+revision=2
 wrksrc="${pkgname}-v${version}"
 build_wrksrc=libraries/libapparmor
 build_style=gnu-configure

  parent reply	other threads:[~2020-04-11 15:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08 10:49 [PR PATCH] " the-antz
2020-04-08 11:29 ` [PR PATCH] [Updated] [NOMERGE] " the-antz
2020-04-09  2:22 ` LamaRaz
2020-04-09 14:54 ` the-antz
2020-04-09 15:37 ` LamaRaz
2020-04-09 17:59 ` the-antz
2020-04-09 18:26 ` LamaRaz
2020-04-09 18:37 ` the-antz
2020-04-11 15:44 ` the-antz [this message]
2020-04-11 15:44 ` the-antz
2020-04-11 16:58 ` CameronNemo
2020-04-13 17:27 ` CameronNemo
2020-04-13 17:32 ` [PR PATCH] [Merged]: " xtraeme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200411154429.f9b4AGqS_7JRBzO2_UMioTAZ-7yuiK0CDeEzCRi5c8E@z \
    --to=the-antz@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).