From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New packages: tageditor, tagparser and c++utilities
Date: Wed, 15 Apr 2020 23:09:17 +0200 [thread overview]
Message-ID: <20200415210917.Dk6f8i6Qn0HlkF54m03GfFbRp5WlJbMH4xX6Oyu0ksE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19844@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/19844#issuecomment-614281242
Comment:
> Tested, works. But please move changes to [proper commits](https://github.com/void-linux/void-packages/pull/19844/commits/1a88641dd9a4aaa4bfdbc4b998ebc6fa03a6badb#diff-816e5624e093eafd5fac2aa7b3b46e83R7), reorder so deps go before package using it, fix commit titles - no revision, remove `wrksrc="${pkgname}-${version}"` that is default.
Thanks for catching these mistakes. I've reworded the commit messages, moved the misplaced change to its proper commit (an artifact of an earlier rebase), and removed the unnecessary `wrksrc` definition (an artifact of the `c++utilities` to `cpp-utilities` rename).
The Github comment thread seems to be sorting the commit messages alphabetically, but the commits are ordered properly in `git log`. If you view history for commit [`926e663`](https://github.com/void-linux/void-packages/commits/926e663ace2a1ab81ae344cd52014115c757bb13/srcpkgs), you should see that the `qtutilities` commit is listed before the `tageditor` commit.
next prev parent reply other threads:[~2020-04-15 21:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-19844@inbox.vuxu.org>
2020-03-30 21:36 ` Chocimier
2020-03-30 22:59 ` [PR PATCH] [Updated] " ahesford
2020-03-30 23:15 ` ahesford
2020-04-06 16:30 ` [PR PATCH] [Updated] " ahesford
2020-04-06 17:40 ` ahesford
2020-04-07 17:34 ` ahesford
2020-04-11 11:31 ` Chocimier
2020-04-11 12:07 ` [PR PATCH] [Updated] " ahesford
2020-04-11 12:08 ` ahesford
2020-04-15 19:05 ` [PR PATCH] [Updated] " ahesford
2020-04-15 20:25 ` Chocimier
2020-04-15 20:54 ` [PR PATCH] [Updated] " ahesford
2020-04-15 21:09 ` ahesford [this message]
2020-04-15 21:11 ` ahesford
2020-04-15 21:19 ` Chocimier
2020-04-15 21:19 ` [PR PATCH] [Merged]: " Chocimier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415210917.Dk6f8i6Qn0HlkF54m03GfFbRp5WlJbMH4xX6Oyu0ksE@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).