From: q66 <q66@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: gcc4ti-0.96b11
Date: Sun, 19 Apr 2020 00:08:54 +0200 [thread overview]
Message-ID: <20200418220854.t-VO33B7gNUsEJI4IDLJ515cFjUW_SEm4-9UnDu1P6k@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-21133@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/21133#issuecomment-615960139
Comment:
you will need to add these changes, too
```
commit 3faa77c1a86b528175bd659b9c9d7f854cae8985
Author: q66 <daniel@octaforge.org>
Date: Sat Apr 18 23:54:53 2020 +0200
gcc4ti: replace platform detection scripts
also stop trying to strip target files
diff --git a/srcpkgs/gcc4ti/template b/srcpkgs/gcc4ti/template
index 0a153a3e19..525f6a6e89 100644
--- a/srcpkgs/gcc4ti/template
+++ b/srcpkgs/gcc4ti/template
@@ -11,6 +11,7 @@ license="GPL-2.0-only"
homepage="https://github.com/debrouxl/gcc4ti"
distfiles="https://github.com/debrouxl/gcc4ti/archive/${_commit}.tar.gz"
checksum=b65eca299c188a1f07887128c4b247363734f1fc44add153c439c07632bfbca1
+nostrip_files="tigcc.a flashos.a fargo.a"
nocross=yes
do_install() {
@@ -22,6 +23,12 @@ do_install() {
export GCC4TIHOST=$XBPS_CROSS_TRIPLET
cd ../gcc4ti-0.96b11/scripts
./Install_step_1
+
+ # override config.guess/sub from 2004 to detect modern targets
+ local cfgdir="${XBPS_COMMONDIR}/environment/configure/automake"
+ cp ${cfgdir}/config.* ../download/gcc-*
+ cp ${cfgdir}/config.* ../download/binutils-*
+
./Install_step_2
./Install_step_3
./Install_step_4
```
otherwise, it won't compile on musl or non-x86_64 targets (it'll fail to detect the target triplet). The nostrip_files bit is not entirely necssary but it'll prevent it from trying.
also, you should find if you can somehow split the build/install steps.
i'll leave the rest to other reviewers
next prev parent reply other threads:[~2020-04-18 22:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 21:23 [PR PATCH] " tibequadorian
2020-04-18 21:25 ` q66
2020-04-18 21:31 ` tibequadorian
2020-04-18 21:32 ` tibequadorian
2020-04-18 21:34 ` q66
2020-04-18 21:37 ` tibequadorian
2020-04-18 21:38 ` [PR PATCH] [Updated] " tibequadorian
2020-04-18 22:08 ` q66 [this message]
2020-04-18 22:11 ` q66
2020-04-21 23:28 ` [PR PATCH] [Closed]: " tibequadorian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200418220854.t-VO33B7gNUsEJI4IDLJ515cFjUW_SEm4-9UnDu1P6k@z \
--to=q66@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).