Re: [PR PATCH] [Updated] gitea: fix INSTALL script

[sineemore <sineemore@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

There is an updated pull request by sineemore against master on the void-packages repository

https://github.com/sineemore/void-packages gitea-fix-install
https://github.com/void-linux/void-packages/pull/18705

gitea: fix INSTALL script
With current INSTALL sed process reveals generated secret key; it can be viewed by monitoring /proc or by using extrace.
Also sed pattern <SECRET_KEY> fails, since there no such substring in provided sample configuration.

A patch file from https://github.com/void-linux/void-packages/pull/18705.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gitea-fix-install-18705.patch --]
[-- Type: text/x-diff, Size: 1616 bytes --]

From b8d32e77b31fc8f3d49ae22196575514f5addafb Mon Sep 17 00:00:00 2001
From: sineemore <sineemore@disroot.org>
Date: Mon, 24 Feb 2020 18:18:54 +0300
Subject: [PATCH] gitea: fix INSTALL script

With current INSTALL sed process reveals generated secret key; it can be viewed by monitoring /proc or by using extrace.
Also sed pattern <SECRET_KEY> fails, since there no such substring in provided sample configuration.

gitea will change all secrets in configuration file right after web based installation process.
---
 srcpkgs/gitea/INSTALL  | 16 ++++------------
 srcpkgs/gitea/template |  2 +-
 2 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/srcpkgs/gitea/INSTALL b/srcpkgs/gitea/INSTALL
index 92e2f390e76..660e7deabaa 100644
--- a/srcpkgs/gitea/INSTALL
+++ b/srcpkgs/gitea/INSTALL
@@ -1,13 +1,5 @@
-case "$ACTION" in
-	post)
-		if [ "$UPDATE" = "yes" ] ; then
-			:
-		else
-			# This sets the secret key which would otherwise be
-			# distributed as a static packaged value
-			secret="$(tr -dc '[:alnum:]' < /dev/urandom | head -c32)"
-			sed -i "s!<SECRET_KEY>!$secret!" etc/gitea.conf
-		fi
-		chown _gitea:_gitea etc/gitea.conf
-		;;
+case "${ACTION}" in
+post)
+	chown _gitea:_gitea etc/gitea.conf
+	;;
 esac
diff --git a/srcpkgs/gitea/template b/srcpkgs/gitea/template
index 5d9a2ad5f06..2b16b3909bc 100644
--- a/srcpkgs/gitea/template
+++ b/srcpkgs/gitea/template
@@ -1,7 +1,7 @@
 # Template file for 'gitea'
 pkgname=gitea
 version=1.10.6
-revision=1
+revision=2
 build_style=go
 go_import_path=code.gitea.io/gitea
 # This could be done with build options, but these are built in with the