Github messages for voidlinux
 help / color / mirror / Atom feed
From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: mu: update to 1.4
Date: Mon, 20 Apr 2020 15:36:35 +0200	[thread overview]
Message-ID: <20200420133635.XhQD8Za5MXaVbFJBX1jguvBuLDfzRoZ39viT4roPvcQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-21131@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1746 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/21131#issuecomment-616556679

Comment:
Here is my final diff on top of your change,
this will enable cross-build for mu and fix the check,
I think you're the maintainer of this package, if it's ok to you,
I'll push this version out.

```diff
diff --git a/srcpkgs/mu/template b/srcpkgs/mu/template
index 51f733e03c..78668f59da 100644
--- a/srcpkgs/mu/template
+++ b/srcpkgs/mu/template
@@ -3,8 +3,9 @@ pkgname=mu
 version=1.4.1
 revision=1
 build_style=gnu-configure
-hostmakedepends="automake libtool pkg-config emacs texinfo"
+hostmakedepends="automake libtool pkg-config texinfo glib-devel"
 makedepends="xapian-core-devel gmime3-devel libuuid-devel"
+checkdepends="tzdata"
 short_desc="Emacs-based tool for dealing with e-mail stored in the Maildir-format"
 maintainer="Benjamin Slade <slade@jnanam.net>"
 license="GPL-3.0-or-later"
@@ -12,16 +13,28 @@ homepage="https://www.djcbsoftware.nl/code/mu/"
 distfiles="https://github.com/djcb/mu/archive/${version}.tar.gz"
 checksum=66ae911abb3d7269514fada08e7a13ad61a205e10209055c41df2f9d17568274
 
+if [ ! "$CROSS_BUILD" ]; then
+	subpackages="mu4e"
+	hostmakedepends+=" emacs"
+else
+	# force subpackages to non-empty value,
+	# else xbps-src will generate it.
+	subpackages=" "
+	configure_args+=" --disable-mu4e"
+fi
+
 pre_configure() {
 	sed -i 's,-I${prefix}/include,,' contrib/Makefile.am
 	autoreconf -fi
 }
 
 mu4e_package() {
+	archs=noarch
 	short_desc+=" - Emacs frontend"
 	depends="${sourcepkg}>=${version}_${revision} emacs"
 	pkg_install() {
 		vmove usr/share/emacs
 		vmove usr/share/info
+		vmove usr/share/doc/mu/mu4e*
 	}
 }
```

  parent reply	other threads:[~2020-04-20 13:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-18 19:25 [PR PATCH] " emacsomancer
2020-04-19 10:58 ` sgn
2020-04-19 15:56 ` emacsomancer
2020-04-19 15:57 ` emacsomancer
2020-04-19 23:49 ` [PR PATCH] [Updated] " emacsomancer
2020-04-20 13:14 ` sgn
2020-04-20 13:34 ` sgn
2020-04-20 13:36 ` sgn [this message]
2020-04-20 15:23 ` emacsomancer
2020-04-20 16:08 ` [PR PATCH] [Closed]: " sgn
  -- strict thread matches above, loose matches on Subject: below --
2020-04-18 15:22 [PR PATCH] " ralsei
2020-04-19  3:02 ` sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200420133635.XhQD8Za5MXaVbFJBX1jguvBuLDfzRoZ39viT4roPvcQ@z \
    --to=sgn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).