Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] corectrl: fix missing svg icons
@ 2020-04-03 17:00 not-chicken
  2020-04-03 19:50 ` xtraeme
                   ` (15 more replies)
  0 siblings, 16 replies; 17+ messages in thread
From: not-chicken @ 2020-04-03 17:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

There is a new pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages core
https://github.com/void-linux/void-packages/pull/20608

corectrl: fix missing svg icons
[ci skip] as only a runtime dependency was added

A patch file from https://github.com/void-linux/void-packages/pull/20608.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-core-20608.patch --]
[-- Type: text/x-diff, Size: 1237 bytes --]

From f90b296292b71a7a8c3936f2ee7d1791fb1747a0 Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Fri, 3 Apr 2020 22:17:49 +0530
Subject: [PATCH] corectrl: fix missing svg icons

[ci skip] as only a runtime dependency was added
---
 srcpkgs/corectrl/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/corectrl/template b/srcpkgs/corectrl/template
index ec31f99b5f2..f092106689f 100644
--- a/srcpkgs/corectrl/template
+++ b/srcpkgs/corectrl/template
@@ -1,14 +1,15 @@
 # Template file for 'corectrl'
 pkgname=corectrl
 version=1.0.8
-revision=1
+revision=2
 wrksrc=${pkgname}-v${version}
 build_style=cmake
 configure_args="-DBUILD_TESTING=OFF"
-hostmakedepends="pkg-config extra-cmake-modules qt5-host-tools qt5-qmake kcoreaddons kauth"
+hostmakedepends="pkg-config extra-cmake-modules qt5-host-tools qt5-qmake
+kcoreaddons kauth"
 makedepends="botan-devel kauth-devel karchive-devel qt5-charts-devel
 qt5-tools-devel libdrm-devel"
-depends="hicolor-icon-theme qt5-quickcontrols2"
+depends="hicolor-icon-theme qt5-quickcontrols2 qt5-svg"
 short_desc="User-friendly hardware control application"
 maintainer="Lorem <notloremipsum@protonmail.com>"
 license="GPL-3.0-or-later"

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: corectrl: fix missing svg icons
  2020-04-03 17:00 [PR PATCH] corectrl: fix missing svg icons not-chicken
@ 2020-04-03 19:50 ` xtraeme
  2020-04-03 23:07 ` not-chicken
                   ` (14 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: xtraeme @ 2020-04-03 19:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/20608#issuecomment-608627602

Comment:
this still does not seem to work on musl, dunno why.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: corectrl: fix missing svg icons
  2020-04-03 17:00 [PR PATCH] corectrl: fix missing svg icons not-chicken
  2020-04-03 19:50 ` xtraeme
@ 2020-04-03 23:07 ` not-chicken
  2020-04-08  6:01 ` [PR PATCH] [Updated] " not-chicken
                   ` (13 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: not-chicken @ 2020-04-03 23:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 688 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/20608#issuecomment-608782018

Comment:
I had some weird experience on musl as well. I was getting something like 
```
can't load Qt5Quick.so.5 Exec error ( required by /usr/lib/libcorectrl.so)
can't load Qt5Qml.so Exec error ( required by /usr/lib/libcorectrl.so)
libcorectrl.so <some random looking string> Symbol not found 
....
....
```

What eventually fixed it for me was  `xbps-install -ff qt5-declarative` as that's what provided those qt shlibs. So I assumed it was just a issue on my system.

Perhaps you are getting similar errors as well or something else?



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] corectrl: fix missing svg icons
  2020-04-03 17:00 [PR PATCH] corectrl: fix missing svg icons not-chicken
  2020-04-03 19:50 ` xtraeme
  2020-04-03 23:07 ` not-chicken
@ 2020-04-08  6:01 ` not-chicken
  2020-04-08  6:19 ` not-chicken
                   ` (12 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: not-chicken @ 2020-04-08  6:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

There is an updated pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages core
https://github.com/void-linux/void-packages/pull/20608

corectrl: fix missing svg icons
[ci skip] as only a runtime dependency was added

A patch file from https://github.com/void-linux/void-packages/pull/20608.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-core-20608.patch --]
[-- Type: text/x-diff, Size: 1193 bytes --]

From 9f7bc62bce0afe93f6b2b00002b71e18db9ee31e Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Fri, 3 Apr 2020 22:17:49 +0530
Subject: [PATCH] corectrl: fix missing svg icons

---
 srcpkgs/corectrl/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/corectrl/template b/srcpkgs/corectrl/template
index ec31f99b5f2..c15a8096de1 100644
--- a/srcpkgs/corectrl/template
+++ b/srcpkgs/corectrl/template
@@ -1,14 +1,15 @@
 # Template file for 'corectrl'
 pkgname=corectrl
 version=1.0.8
-revision=1
+revision=2
 wrksrc=${pkgname}-v${version}
 build_style=cmake
 configure_args="-DBUILD_TESTING=OFF"
-hostmakedepends="pkg-config extra-cmake-modules qt5-host-tools qt5-qmake kcoreaddons kauth"
+hostmakedepends="pkg-config extra-cmake-modules qt5-host-tools qt5-qmake
+kcoreaddons kauth"
 makedepends="botan-devel kauth-devel karchive-devel qt5-charts-devel
 qt5-tools-devel libdrm-devel"
-depends="hicolor-icon-theme qt5-quickcontrols2"
+depends="dbus hicolor-icon-theme qt5-quickcontrols2 qt5-svg"
 short_desc="User-friendly hardware control application"
 maintainer="Lorem <notloremipsum@protonmail.com>"
 license="GPL-3.0-or-later"

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: corectrl: fix missing svg icons
  2020-04-03 17:00 [PR PATCH] corectrl: fix missing svg icons not-chicken
                   ` (2 preceding siblings ...)
  2020-04-08  6:01 ` [PR PATCH] [Updated] " not-chicken
@ 2020-04-08  6:19 ` not-chicken
  2020-04-09 14:06 ` [PR PATCH] [Updated] " not-chicken
                   ` (11 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: not-chicken @ 2020-04-08  6:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/20608#issuecomment-610773282

Comment:
@xtraeme Can you test again and report back the error you are facing on musl? It seems to work fine on musl for me.

I have force pushed to remove `ci skip` to let it build against new qt5 in the repos.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] corectrl: fix missing svg icons
  2020-04-03 17:00 [PR PATCH] corectrl: fix missing svg icons not-chicken
                   ` (3 preceding siblings ...)
  2020-04-08  6:19 ` not-chicken
@ 2020-04-09 14:06 ` not-chicken
  2020-04-09 14:07 ` not-chicken
                   ` (10 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: not-chicken @ 2020-04-09 14:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

There is an updated pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages core
https://github.com/void-linux/void-packages/pull/20608

corectrl: fix missing svg icons
[ci skip] as only a runtime dependency was added

A patch file from https://github.com/void-linux/void-packages/pull/20608.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-core-20608.patch --]
[-- Type: text/x-diff, Size: 1193 bytes --]

From 0c7faa5b3d01368409ba296ccab55daf3c97bc85 Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Fri, 3 Apr 2020 22:17:49 +0530
Subject: [PATCH] corectrl: fix missing svg icons

---
 srcpkgs/corectrl/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/corectrl/template b/srcpkgs/corectrl/template
index 386013e022e..99dff6831fe 100644
--- a/srcpkgs/corectrl/template
+++ b/srcpkgs/corectrl/template
@@ -1,14 +1,15 @@
 # Template file for 'corectrl'
 pkgname=corectrl
 version=1.0.8
-revision=2
+revision=3
 wrksrc=${pkgname}-v${version}
 build_style=cmake
 configure_args="-DBUILD_TESTING=OFF"
-hostmakedepends="pkg-config extra-cmake-modules qt5-host-tools qt5-qmake kcoreaddons kauth"
+hostmakedepends="pkg-config extra-cmake-modules qt5-host-tools qt5-qmake
+kcoreaddons kauth"
 makedepends="botan-devel kauth-devel karchive-devel qt5-charts-devel
 qt5-tools-devel libdrm-devel"
-depends="hicolor-icon-theme qt5-quickcontrols2"
+depends="dbus hicolor-icon-theme qt5-quickcontrols2 qt5-svg"
 short_desc="User-friendly hardware control application"
 maintainer="Lorem <notloremipsum@protonmail.com>"
 license="GPL-3.0-or-later"

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: corectrl: fix missing svg icons
  2020-04-03 17:00 [PR PATCH] corectrl: fix missing svg icons not-chicken
                   ` (4 preceding siblings ...)
  2020-04-09 14:06 ` [PR PATCH] [Updated] " not-chicken
@ 2020-04-09 14:07 ` not-chicken
  2020-04-22 10:29 ` [PR PATCH] [Updated] corectrl: update to 1.0.9 not-chicken
                   ` (9 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: not-chicken @ 2020-04-09 14:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/20608#issuecomment-610773282

Comment:
@xtraeme Can you test again and report back the error you are facing on musl? It seems to work fine on musl for me.

I have force pushed to remove `ci skip` to let it build against new qt5 in the repos.

Edit: Sneaky revbump as it's already set to revision 2 by botan rebuild.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] corectrl: update to 1.0.9
  2020-04-03 17:00 [PR PATCH] corectrl: fix missing svg icons not-chicken
                   ` (5 preceding siblings ...)
  2020-04-09 14:07 ` not-chicken
@ 2020-04-22 10:29 ` not-chicken
  2020-05-31 23:43 ` [PR PATCH] [Updated] corectrl: update to 1.1.0; fix dependencies not-chicken
                   ` (8 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: not-chicken @ 2020-04-22 10:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

There is an updated pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages core
https://github.com/void-linux/void-packages/pull/20608

corectrl: update to 1.0.9
[ci skip] as only a runtime dependency was added

A patch file from https://github.com/void-linux/void-packages/pull/20608.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-core-20608.patch --]
[-- Type: text/x-diff, Size: 2736 bytes --]

From 9a14334bfb023b8fede61bc8a8381fd05e1332fc Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Fri, 3 Apr 2020 22:17:49 +0530
Subject: [PATCH] corectrl: update to 1.0.9

And fix depends
---
 .../patches/add-include-qbuspendingcall.patch | 25 -------------------
 srcpkgs/corectrl/template                     | 12 ++++-----
 2 files changed, 6 insertions(+), 31 deletions(-)
 delete mode 100644 srcpkgs/corectrl/patches/add-include-qbuspendingcall.patch

diff --git a/srcpkgs/corectrl/patches/add-include-qbuspendingcall.patch b/srcpkgs/corectrl/patches/add-include-qbuspendingcall.patch
deleted file mode 100644
index d2138460e06..00000000000
--- a/srcpkgs/corectrl/patches/add-include-qbuspendingcall.patch
+++ /dev/null
@@ -1,25 +0,0 @@
-From 17ad9c9262927a3897352162de8fe2222a2d0b24 Mon Sep 17 00:00:00 2001
-From: Artem Polishchuk <ego.cordatus@gmail.com>
-Date: Mon, 23 Mar 2020 12:06:29 +0200
-Subject: [PATCH] Add 'include <QDBusPendingCall>'
-
-Fix #62
----
- src/helper/helpersysctl.cpp | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/src/helper/helpersysctl.cpp b/src/helper/helpersysctl.cpp
-index cbdc8a9..bdabd0b 100644
---- a/src/helper/helpersysctl.cpp
-+++ b/src/helper/helpersysctl.cpp
-@@ -24,6 +24,7 @@
- #include <QByteArray>
- #include <QDBusConnection>
- #include <QDBusInterface>
-+#include <QDBusPendingCall>
- #include <QStringLiteral>
- #include <stdexcept>
- #include <utility>
--- 
-2.24.1
-
diff --git a/srcpkgs/corectrl/template b/srcpkgs/corectrl/template
index 386013e022e..e1b14a36179 100644
--- a/srcpkgs/corectrl/template
+++ b/srcpkgs/corectrl/template
@@ -1,21 +1,21 @@
 # Template file for 'corectrl'
 pkgname=corectrl
-version=1.0.8
-revision=2
+version=1.0.9
+revision=1
 wrksrc=${pkgname}-v${version}
 build_style=cmake
 configure_args="-DBUILD_TESTING=OFF"
-hostmakedepends="pkg-config extra-cmake-modules qt5-host-tools qt5-qmake kcoreaddons kauth"
+hostmakedepends="pkg-config extra-cmake-modules qt5-host-tools qt5-qmake
+kcoreaddons kauth"
 makedepends="botan-devel kauth-devel karchive-devel qt5-charts-devel
 qt5-tools-devel libdrm-devel"
-depends="hicolor-icon-theme qt5-quickcontrols2"
+depends="dbus hicolor-icon-theme qt5-quickcontrols2 qt5-svg"
 short_desc="User-friendly hardware control application"
 maintainer="Lorem <notloremipsum@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://gitlab.com/corectrl/corectrl"
 distfiles="${homepage}/-/archive/v${version}/corectrl-v${version}.tar.gz"
-checksum=050f1b4f105615c26dcb23d09bbdadbc619c9b9782197cae482fb6921f5e3cf2
-patch_args="-Np1"
+checksum=a788dec045fe237dc6dac11698f0038743f1de0c15ce9350ee907c152af19dd4
 
 if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
 	makedepends+=" libatomic-devel"

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] corectrl: update to 1.1.0; fix dependencies
  2020-04-03 17:00 [PR PATCH] corectrl: fix missing svg icons not-chicken
                   ` (6 preceding siblings ...)
  2020-04-22 10:29 ` [PR PATCH] [Updated] corectrl: update to 1.0.9 not-chicken
@ 2020-05-31 23:43 ` not-chicken
  2020-06-02  3:15 ` not-chicken
                   ` (7 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: not-chicken @ 2020-05-31 23:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

There is an updated pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages core
https://github.com/void-linux/void-packages/pull/20608

corectrl: update to 1.1.0; fix dependencies
[ci skip] as only a runtime dependency was added

A patch file from https://github.com/void-linux/void-packages/pull/20608.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-core-20608.patch --]
[-- Type: text/x-diff, Size: 2738 bytes --]

From 6632cc7a605f2c62cd0116f58ecd92b717ca917f Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Fri, 3 Apr 2020 22:17:49 +0530
Subject: [PATCH] corectrl: update to 1.1.0; fix dependencies

---
 .../patches/add-include-qbuspendingcall.patch | 25 -------------------
 srcpkgs/corectrl/template                     | 12 ++++-----
 2 files changed, 6 insertions(+), 31 deletions(-)
 delete mode 100644 srcpkgs/corectrl/patches/add-include-qbuspendingcall.patch

diff --git a/srcpkgs/corectrl/patches/add-include-qbuspendingcall.patch b/srcpkgs/corectrl/patches/add-include-qbuspendingcall.patch
deleted file mode 100644
index d2138460e06..00000000000
--- a/srcpkgs/corectrl/patches/add-include-qbuspendingcall.patch
+++ /dev/null
@@ -1,25 +0,0 @@
-From 17ad9c9262927a3897352162de8fe2222a2d0b24 Mon Sep 17 00:00:00 2001
-From: Artem Polishchuk <ego.cordatus@gmail.com>
-Date: Mon, 23 Mar 2020 12:06:29 +0200
-Subject: [PATCH] Add 'include <QDBusPendingCall>'
-
-Fix #62
----
- src/helper/helpersysctl.cpp | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/src/helper/helpersysctl.cpp b/src/helper/helpersysctl.cpp
-index cbdc8a9..bdabd0b 100644
---- a/src/helper/helpersysctl.cpp
-+++ b/src/helper/helpersysctl.cpp
-@@ -24,6 +24,7 @@
- #include <QByteArray>
- #include <QDBusConnection>
- #include <QDBusInterface>
-+#include <QDBusPendingCall>
- #include <QStringLiteral>
- #include <stdexcept>
- #include <utility>
--- 
-2.24.1
-
diff --git a/srcpkgs/corectrl/template b/srcpkgs/corectrl/template
index 386013e022e..f4a6453629c 100644
--- a/srcpkgs/corectrl/template
+++ b/srcpkgs/corectrl/template
@@ -1,21 +1,21 @@
 # Template file for 'corectrl'
 pkgname=corectrl
-version=1.0.8
-revision=2
+version=1.1.0
+revision=1
 wrksrc=${pkgname}-v${version}
 build_style=cmake
 configure_args="-DBUILD_TESTING=OFF"
-hostmakedepends="pkg-config extra-cmake-modules qt5-host-tools qt5-qmake kcoreaddons kauth"
+hostmakedepends="pkg-config extra-cmake-modules qt5-host-tools qt5-qmake
+kcoreaddons kauth"
 makedepends="botan-devel kauth-devel karchive-devel qt5-charts-devel
 qt5-tools-devel libdrm-devel"
-depends="hicolor-icon-theme qt5-quickcontrols2"
+depends="dbus hicolor-icon-theme qt5-quickcontrols2 qt5-svg"
 short_desc="User-friendly hardware control application"
 maintainer="Lorem <notloremipsum@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://gitlab.com/corectrl/corectrl"
 distfiles="${homepage}/-/archive/v${version}/corectrl-v${version}.tar.gz"
-checksum=050f1b4f105615c26dcb23d09bbdadbc619c9b9782197cae482fb6921f5e3cf2
-patch_args="-Np1"
+checksum=d73a02ee66e8572ff2a436cc608c2901a6eaf603d094a25aeab8c842696f399c
 
 if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
 	makedepends+=" libatomic-devel"

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] corectrl: update to 1.1.0; fix dependencies
  2020-04-03 17:00 [PR PATCH] corectrl: fix missing svg icons not-chicken
                   ` (7 preceding siblings ...)
  2020-05-31 23:43 ` [PR PATCH] [Updated] corectrl: update to 1.1.0; fix dependencies not-chicken
@ 2020-06-02  3:15 ` not-chicken
  2020-08-25 14:57 ` not-chicken
                   ` (6 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: not-chicken @ 2020-06-02  3:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

There is an updated pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages core
https://github.com/void-linux/void-packages/pull/20608

corectrl: update to 1.1.0; fix dependencies
[ci skip] as only a runtime dependency was added

A patch file from https://github.com/void-linux/void-packages/pull/20608.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-core-20608.patch --]
[-- Type: text/x-diff, Size: 2738 bytes --]

From 13a793aaaf73522f5b86f60ee5316a70ce9219c3 Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Fri, 3 Apr 2020 22:17:49 +0530
Subject: [PATCH] corectrl: update to 1.1.0; fix dependencies

---
 .../patches/add-include-qbuspendingcall.patch | 25 -------------------
 srcpkgs/corectrl/template                     | 12 ++++-----
 2 files changed, 6 insertions(+), 31 deletions(-)
 delete mode 100644 srcpkgs/corectrl/patches/add-include-qbuspendingcall.patch

diff --git a/srcpkgs/corectrl/patches/add-include-qbuspendingcall.patch b/srcpkgs/corectrl/patches/add-include-qbuspendingcall.patch
deleted file mode 100644
index d2138460e06..00000000000
--- a/srcpkgs/corectrl/patches/add-include-qbuspendingcall.patch
+++ /dev/null
@@ -1,25 +0,0 @@
-From 17ad9c9262927a3897352162de8fe2222a2d0b24 Mon Sep 17 00:00:00 2001
-From: Artem Polishchuk <ego.cordatus@gmail.com>
-Date: Mon, 23 Mar 2020 12:06:29 +0200
-Subject: [PATCH] Add 'include <QDBusPendingCall>'
-
-Fix #62
----
- src/helper/helpersysctl.cpp | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/src/helper/helpersysctl.cpp b/src/helper/helpersysctl.cpp
-index cbdc8a9..bdabd0b 100644
---- a/src/helper/helpersysctl.cpp
-+++ b/src/helper/helpersysctl.cpp
-@@ -24,6 +24,7 @@
- #include <QByteArray>
- #include <QDBusConnection>
- #include <QDBusInterface>
-+#include <QDBusPendingCall>
- #include <QStringLiteral>
- #include <stdexcept>
- #include <utility>
--- 
-2.24.1
-
diff --git a/srcpkgs/corectrl/template b/srcpkgs/corectrl/template
index 386013e022e..f4a6453629c 100644
--- a/srcpkgs/corectrl/template
+++ b/srcpkgs/corectrl/template
@@ -1,21 +1,21 @@
 # Template file for 'corectrl'
 pkgname=corectrl
-version=1.0.8
-revision=2
+version=1.1.0
+revision=1
 wrksrc=${pkgname}-v${version}
 build_style=cmake
 configure_args="-DBUILD_TESTING=OFF"
-hostmakedepends="pkg-config extra-cmake-modules qt5-host-tools qt5-qmake kcoreaddons kauth"
+hostmakedepends="pkg-config extra-cmake-modules qt5-host-tools qt5-qmake
+kcoreaddons kauth"
 makedepends="botan-devel kauth-devel karchive-devel qt5-charts-devel
 qt5-tools-devel libdrm-devel"
-depends="hicolor-icon-theme qt5-quickcontrols2"
+depends="dbus hicolor-icon-theme qt5-quickcontrols2 qt5-svg"
 short_desc="User-friendly hardware control application"
 maintainer="Lorem <notloremipsum@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://gitlab.com/corectrl/corectrl"
 distfiles="${homepage}/-/archive/v${version}/corectrl-v${version}.tar.gz"
-checksum=050f1b4f105615c26dcb23d09bbdadbc619c9b9782197cae482fb6921f5e3cf2
-patch_args="-Np1"
+checksum=d73a02ee66e8572ff2a436cc608c2901a6eaf603d094a25aeab8c842696f399c
 
 if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
 	makedepends+=" libatomic-devel"

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] corectrl: update to 1.1.0; fix dependencies
  2020-04-03 17:00 [PR PATCH] corectrl: fix missing svg icons not-chicken
                   ` (8 preceding siblings ...)
  2020-06-02  3:15 ` not-chicken
@ 2020-08-25 14:57 ` not-chicken
  2020-09-29  1:52 ` corectrl: update to 1.1.1; " ericonr
                   ` (5 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: not-chicken @ 2020-08-25 14:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

There is an updated pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages core
https://github.com/void-linux/void-packages/pull/20608

corectrl: update to 1.1.0; fix dependencies
[ci skip] as only a runtime dependency was added

A patch file from https://github.com/void-linux/void-packages/pull/20608.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-core-20608.patch --]
[-- Type: text/x-diff, Size: 2785 bytes --]

From 0ef5fd6733a3a254ea9d086f19b6b788475f745d Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Fri, 3 Apr 2020 22:17:49 +0530
Subject: [PATCH] corectrl: update to 1.1.1; fix dependencies

---
 .../patches/add-include-qbuspendingcall.patch | 25 -------------------
 srcpkgs/corectrl/template                     | 14 +++++------
 2 files changed, 7 insertions(+), 32 deletions(-)
 delete mode 100644 srcpkgs/corectrl/patches/add-include-qbuspendingcall.patch

diff --git a/srcpkgs/corectrl/patches/add-include-qbuspendingcall.patch b/srcpkgs/corectrl/patches/add-include-qbuspendingcall.patch
deleted file mode 100644
index d2138460e06..00000000000
--- a/srcpkgs/corectrl/patches/add-include-qbuspendingcall.patch
+++ /dev/null
@@ -1,25 +0,0 @@
-From 17ad9c9262927a3897352162de8fe2222a2d0b24 Mon Sep 17 00:00:00 2001
-From: Artem Polishchuk <ego.cordatus@gmail.com>
-Date: Mon, 23 Mar 2020 12:06:29 +0200
-Subject: [PATCH] Add 'include <QDBusPendingCall>'
-
-Fix #62
----
- src/helper/helpersysctl.cpp | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/src/helper/helpersysctl.cpp b/src/helper/helpersysctl.cpp
-index cbdc8a9..bdabd0b 100644
---- a/src/helper/helpersysctl.cpp
-+++ b/src/helper/helpersysctl.cpp
-@@ -24,6 +24,7 @@
- #include <QByteArray>
- #include <QDBusConnection>
- #include <QDBusInterface>
-+#include <QDBusPendingCall>
- #include <QStringLiteral>
- #include <stdexcept>
- #include <utility>
--- 
-2.24.1
-
diff --git a/srcpkgs/corectrl/template b/srcpkgs/corectrl/template
index 386013e022e..75b5fea7722 100644
--- a/srcpkgs/corectrl/template
+++ b/srcpkgs/corectrl/template
@@ -1,21 +1,21 @@
 # Template file for 'corectrl'
 pkgname=corectrl
-version=1.0.8
-revision=2
+version=1.1.1
+revision=1
 wrksrc=${pkgname}-v${version}
 build_style=cmake
 configure_args="-DBUILD_TESTING=OFF"
-hostmakedepends="pkg-config extra-cmake-modules qt5-host-tools qt5-qmake kcoreaddons kauth"
+hostmakedepends="pkg-config extra-cmake-modules qt5-host-tools qt5-qmake
+kcoreaddons kauth"
 makedepends="botan-devel kauth-devel karchive-devel qt5-charts-devel
-qt5-tools-devel libdrm-devel"
-depends="hicolor-icon-theme qt5-quickcontrols2"
+qt5-tools-devel libdrm-devel qt5-svg-devel"
+depends="dbus hicolor-icon-theme qt5-quickcontrols2 qt5-svg"
 short_desc="User-friendly hardware control application"
 maintainer="Lorem <notloremipsum@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://gitlab.com/corectrl/corectrl"
 distfiles="${homepage}/-/archive/v${version}/corectrl-v${version}.tar.gz"
-checksum=050f1b4f105615c26dcb23d09bbdadbc619c9b9782197cae482fb6921f5e3cf2
-patch_args="-Np1"
+checksum=dbeb3bb167ef9e7c17f16aed2aa5cc05e480d4765665408f678b3314f0ae8ab4
 
 if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
 	makedepends+=" libatomic-devel"

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: corectrl: update to 1.1.1; fix dependencies
  2020-04-03 17:00 [PR PATCH] corectrl: fix missing svg icons not-chicken
                   ` (9 preceding siblings ...)
  2020-08-25 14:57 ` not-chicken
@ 2020-09-29  1:52 ` ericonr
  2020-09-29  9:24 ` not-chicken
                   ` (4 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: ericonr @ 2020-09-29  1:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/20608#issuecomment-700377118

Comment:
On musl, if it matters:

```
[28-09-20 22:51:36.301][W] glxinfo command failed
[28-09-20 22:51:36.365][W] No translation found for locale en_US
[28-09-20 22:51:36.365][W] Using en_EN translation.
QDBusArgument: read from a write-only object
QDBusArgument: read from a write-only object
QDBusArgument: read from a write-only object
[28-09-20 22:51:36.447][W] Cannot start helper
[28-09-20 22:51:36.447][W] Initialization failed
[28-09-20 22:51:36.447][W] Exiting...
```

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: corectrl: update to 1.1.1; fix dependencies
  2020-04-03 17:00 [PR PATCH] corectrl: fix missing svg icons not-chicken
                   ` (10 preceding siblings ...)
  2020-09-29  1:52 ` corectrl: update to 1.1.1; " ericonr
@ 2020-09-29  9:24 ` not-chicken
  2020-09-29 11:57 ` ericonr
                   ` (3 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: not-chicken @ 2020-09-29  9:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/20608#issuecomment-700581908

Comment:
> On musl, if it matters:
> 
> ```
> [28-09-20 22:51:36.301][W] glxinfo command failed
> [28-09-20 22:51:36.365][W] No translation found for locale en_US
> [28-09-20 22:51:36.365][W] Using en_EN translation.
> QDBusArgument: read from a write-only object
> QDBusArgument: read from a write-only object
> QDBusArgument: read from a write-only object
> [28-09-20 22:51:36.447][W] Cannot start helper
> [28-09-20 22:51:36.447][W] Initialization failed
> [28-09-20 22:51:36.447][W] Exiting...
> ```

Could you be using a wm without any polkit agent? There's this issue https://gitlab.com/corectrl/corectrl/-/issues/40

I installed sway and ootb I got the same error as you. Then I installed `polkit-gnome` and added `exec /usr/libexec/polkit-gnome-authentication-agent-1` to sway config, then I got the prompt to enter root password.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: corectrl: update to 1.1.1; fix dependencies
  2020-04-03 17:00 [PR PATCH] corectrl: fix missing svg icons not-chicken
                   ` (11 preceding siblings ...)
  2020-09-29  9:24 ` not-chicken
@ 2020-09-29 11:57 ` ericonr
  2020-09-29 12:18 ` not-chicken
                   ` (2 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: ericonr @ 2020-09-29 11:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/20608#issuecomment-700654352

Comment:
hmm, should this depend on `polkit`, then?

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: corectrl: update to 1.1.1; fix dependencies
  2020-04-03 17:00 [PR PATCH] corectrl: fix missing svg icons not-chicken
                   ` (12 preceding siblings ...)
  2020-09-29 11:57 ` ericonr
@ 2020-09-29 12:18 ` not-chicken
  2020-09-29 12:28 ` ericonr
  2020-09-29 12:29 ` [PR PATCH] [Merged]: " ericonr
  15 siblings, 0 replies; 17+ messages in thread
From: not-chicken @ 2020-09-29 12:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/20608#issuecomment-700664264

Comment:
> hmm, should this depend on `polkit`, then?

It already pulls in that via `kauth`. As for an authentication agent, almost all DEs already contain one, so hard dep on a particular one wouldn't be a good idea imo.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: corectrl: update to 1.1.1; fix dependencies
  2020-04-03 17:00 [PR PATCH] corectrl: fix missing svg icons not-chicken
                   ` (13 preceding siblings ...)
  2020-09-29 12:18 ` not-chicken
@ 2020-09-29 12:28 ` ericonr
  2020-09-29 12:29 ` [PR PATCH] [Merged]: " ericonr
  15 siblings, 0 replies; 17+ messages in thread
From: ericonr @ 2020-09-29 12:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/20608#issuecomment-700668825

Comment:
Got it, no problem.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Merged]: corectrl: update to 1.1.1; fix dependencies
  2020-04-03 17:00 [PR PATCH] corectrl: fix missing svg icons not-chicken
                   ` (14 preceding siblings ...)
  2020-09-29 12:28 ` ericonr
@ 2020-09-29 12:29 ` ericonr
  15 siblings, 0 replies; 17+ messages in thread
From: ericonr @ 2020-09-29 12:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

There's a merged pull request on the void-packages repository

corectrl: update to 1.1.1; fix dependencies
https://github.com/void-linux/void-packages/pull/20608

Description:
[ci skip] as only a runtime dependency was added

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2020-09-29 12:29 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-03 17:00 [PR PATCH] corectrl: fix missing svg icons not-chicken
2020-04-03 19:50 ` xtraeme
2020-04-03 23:07 ` not-chicken
2020-04-08  6:01 ` [PR PATCH] [Updated] " not-chicken
2020-04-08  6:19 ` not-chicken
2020-04-09 14:06 ` [PR PATCH] [Updated] " not-chicken
2020-04-09 14:07 ` not-chicken
2020-04-22 10:29 ` [PR PATCH] [Updated] corectrl: update to 1.0.9 not-chicken
2020-05-31 23:43 ` [PR PATCH] [Updated] corectrl: update to 1.1.0; fix dependencies not-chicken
2020-06-02  3:15 ` not-chicken
2020-08-25 14:57 ` not-chicken
2020-09-29  1:52 ` corectrl: update to 1.1.1; " ericonr
2020-09-29  9:24 ` not-chicken
2020-09-29 11:57 ` ericonr
2020-09-29 12:18 ` not-chicken
2020-09-29 12:28 ` ericonr
2020-09-29 12:29 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).