Github messages for voidlinux
 help / color / mirror / Atom feed
From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: foliate: update to 2.1.0
Date: Wed, 22 Apr 2020 14:06:03 +0200	[thread overview]
Message-ID: <20200422120603.Gyvt7XsF2TRjISRYTw3kTBDVlwVijMbT0uFEU_6fsp4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20732@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/20732#issuecomment-617737839

Comment:
On 2020-04-21 23:27:01-0700, Lorem <notifications@github.com> wrote:
> The file has been fixed upstream. Should I create a patch? 
> To be noted that this does not have any effect on the usability of the package.

I don't think it's matter much.
Thanks for looking into it.

One issue, though.

Please rebase against latest master.
And check which `python_version` should this package set.
I think it's safer to use python3, but I haven't tested it, yet.

-- 
Danh


  parent reply	other threads:[~2020-04-22 12:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07 16:57 [PR PATCH] foliate: create symlink to executable not-chicken
2020-04-08  4:02 ` [PR PATCH] [Updated] " not-chicken
2020-04-08 14:31 ` not-chicken
2020-04-08 15:07 ` [PR PATCH] [Updated] foliate: update to 2.1.0 not-chicken
2020-04-09  3:06 ` not-chicken
2020-04-19 14:59 ` sgn
2020-04-22  3:13 ` [WIP] " not-chicken
2020-04-22  6:26 ` not-chicken
2020-04-22 12:06 ` sgn [this message]
2020-04-22 12:26 ` not-chicken
2020-04-22 12:26 ` not-chicken
2020-04-22 12:29 ` [PR PATCH] [Updated] " not-chicken
2020-04-22 12:47 ` [PR PATCH] [Closed]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200422120603.Gyvt7XsF2TRjISRYTw3kTBDVlwVijMbT0uFEU_6fsp4@z \
    --to=sgn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).