Github messages for voidlinux
 help / color / mirror / Atom feed
From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: alot: update to 0.9
Date: Sat, 25 Apr 2020 18:22:15 +0200	[thread overview]
Message-ID: <20200425162215.t882yKTS5-Bqf5-tyKidCpQPeSBK8X-5CnsnQpHH2hU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-21266@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 4420 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/21266#issuecomment-619404330

Comment:
I would love to have this as an addition:
```diff
 ...arning-is-with-a-literal.-from-Python-3.8.patch | 60 ++++++++++++++++++++++
 srcpkgs/alot/template                              | 12 ++++-
 2 files changed, 71 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/alot/patches/0001-Fix-SyntaxWarning-is-with-a-literal.-from-Python-3.8.patch b/srcpkgs/alot/patches/0001-Fix-SyntaxWarning-is-with-a-literal.-from-Python-3.8.patch
new file mode 100644
index 0000000000..6d3aaf514e
--- /dev/null
+++ b/srcpkgs/alot/patches/0001-Fix-SyntaxWarning-is-with-a-literal.-from-Python-3.8.patch
@@ -0,0 +1,60 @@
+From 916b446317980e9794a02bfb79456da4fc2768a4 Mon Sep 17 00:00:00 2001
+From: Jordan Justen <jordan.l.justen@intel.com>
+Date: Thu, 9 Apr 2020 02:26:27 -0700
+Subject: [PATCH] Fix 'SyntaxWarning: "is" with a literal.' from Python 3.8
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+alot/alot/widgets/ansi.py:84: SyntaxWarning: "is" with a literal. Did you mean "=="?
+  if code is 0:
+alot/alot/commands/envelope.py:762: SyntaxWarning: "is" with a literal. Did you mean "=="?
+  if self.action is "txt2html":
+alot/alot/commands/envelope.py:768: SyntaxWarning: "is" with a literal. Did you mean "=="?
+  elif self.action is "html2txt":
+
+Ref: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=955193
+Upstream: https://github.com/pazz/alot/commit/916b446317980e9794a02bfb79456da4fc2768a4 
+Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
+Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
+---
+ alot/commands/envelope.py | 4 ++--
+ alot/widgets/ansi.py      | 2 +-
+ 2 files changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/alot/commands/envelope.py b/alot/commands/envelope.py
+index 9c2fbbc5..ba0b4dbc 100644
+--- a/alot/commands/envelope.py
++++ b/alot/commands/envelope.py
+@@ -759,13 +759,13 @@ class BodyConvertCommand(Command):
+         ebuffer = ui.current_buffer
+         envelope = ebuffer.envelope
+ 
+-        if self.action is "txt2html":
++        if self.action == "txt2html":
+             fallbackcmd = settings.get('envelope_txt2html')
+             cmd = self.cmd or split_commandstring(fallbackcmd)
+             if cmd:
+                 envelope.body_html = self.convert(cmd, envelope.body_txt)
+ 
+-        elif self.action is "html2txt":
++        elif self.action == "html2txt":
+             fallbackcmd = settings.get('envelope_html2txt')
+             cmd = self.cmd or split_commandstring(fallbackcmd)
+             if cmd:
+diff --git a/alot/widgets/ansi.py b/alot/widgets/ansi.py
+index 97a4fb95..4aaf28e7 100644
+--- a/alot/widgets/ansi.py
++++ b/alot/widgets/ansi.py
+@@ -81,7 +81,7 @@ def parse_escapes_to_urwid(text, default_attr=None, default_attr_focus=None,
+             i = 0
+             while i < len(esc_code):
+                 code = esc_code[i]
+-                if code is 0:
++                if code == 0:
+                     attr.update({'bold': default_attr.bold,
+                                  'underline': default_attr.underline,
+                                  'standout': default_attr.standout})
+-- 
+2.26.2.526.g744177e7f7
+
diff --git a/srcpkgs/alot/template b/srcpkgs/alot/template
index 60134d6605..f8fed37163 100644
--- a/srcpkgs/alot/template
+++ b/srcpkgs/alot/template
@@ -4,12 +4,22 @@ version=0.9
 revision=1
 archs=noarch
 build_style=python3-module
-hostmakedepends="python3-setuptools"
+hostmakedepends="python3-setuptools python3-Sphinx"
 depends="python3-setuptools python3-Twisted notmuch-python3 python3-configobj
  python3-gpg python3-magic python3-urwidtrees"
+checkdepends="$depends"
 short_desc="Terminal-based mail user agent based on the notmuch mail indexer"
 maintainer="Felix Van der Jeugt <felix.vanderjeugt@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/pazz/alot"
 distfiles="https://github.com/pazz/${pkgname}/archive/${version}.tar.gz"
 checksum=64bfa2f550d775940348c93532bf5cbdde57b9fcec4bcf2447a72510d2add6cf
+patch_args="-Np1"
+
+post_build() {
+	make -C docs man
+}
+
+post_install() {
+	vman docs/build/man/alot.1
+}
```

The check step is failing, though.
Can you check?

  parent reply	other threads:[~2020-04-25 16:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23 14:26 [PR PATCH] " rien
2020-04-23 20:00 ` [PR PATCH] [Updated] " rien
2020-04-25 16:22 ` sgn [this message]
2020-04-25 16:29 ` rien
2020-04-25 16:33 ` [PR PATCH] [Updated] " rien
2020-04-25 17:38 ` rien
2020-04-25 18:01 ` Piraty
2020-04-26 17:44 ` [PR PATCH] [Updated] " rien
2020-04-26 17:52 ` rien
2020-04-26 23:32 ` Piraty
2020-05-02 18:19 ` rien
2020-05-02 18:19 ` [PR PATCH] [Updated] " rien
2020-05-02 21:18 ` rien
2020-05-02 23:09 ` rien
2020-05-03 10:46 ` rien
2020-05-03 12:41 ` sgn
2020-05-03 14:03 ` rien
2020-05-03 14:39 ` sgn
2020-05-03 16:15 ` rien
2020-05-03 23:24 ` Piraty
2020-05-04  0:35 ` [PR PATCH] [Closed]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200425162215.t882yKTS5-Bqf5-tyKidCpQPeSBK8X-5CnsnQpHH2hU@z \
    --to=sgn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).