Github messages for voidlinux
 help / color / mirror / Atom feed
From: zhengqunkoo <zhengqunkoo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] Avoid overriding do_install() from build-style
Date: Sun, 26 Apr 2020 15:20:32 +0200	[thread overview]
Message-ID: <20200426132032.jAGvNMg1RrEKjSqaVP0xLGSptt3a3DRW3Wq0fCOorQ0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-21343@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

There is an updated pull request by zhengqunkoo against master on the void-packages repository

https://github.com/zhengqunkoo/void-packages kmonad
https://github.com/void-linux/void-packages/pull/21343

Avoid overriding do_install() from build-style
An overrided `do_install()` means `/usr/bin/kmonad` is not installed.

A patch file from https://github.com/void-linux/void-packages/pull/21343.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kmonad-21343.patch --]
[-- Type: text/x-diff, Size: 1018 bytes --]

From 81e8b5dbe95ec170d030c371caaa3fcd94f3400b Mon Sep 17 00:00:00 2001
From: zhengqunkoo <root@zhengqunkoo.com>
Date: Sun, 26 Apr 2020 06:20:09 +0800
Subject: [PATCH] kmonad: avoid overriding do_install() in build-style

An overrided do_install() means /usr/bin/kmonad
is not installed.
---
 srcpkgs/kmonad/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/kmonad/template b/srcpkgs/kmonad/template
index 88584c00607..bfa208d1ce3 100644
--- a/srcpkgs/kmonad/template
+++ b/srcpkgs/kmonad/template
@@ -1,7 +1,7 @@
 # Template file for 'kmonad'
 pkgname=kmonad
 version=0.3.0
-revision=2
+revision=3
 build_style=haskell-stack
 stackage=lts-14.07
 short_desc="Keyboard remapping utility providing qmk-like functionality"
@@ -13,7 +13,7 @@ checksum="3f61c546d456354a15326558eb8025024ab3d51ef2f6ec761da5568e4473f7ec"
 nopie_files="/usr/bin/kmonad"
 nocross=yes
 
-do_install() {
+post_install() {
 	vlicense LICENSE
 	vinstall ${FILESDIR}/60-kmonad.rules 644 usr/lib/udev/rules.d
 }

  parent reply	other threads:[~2020-04-26 13:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-25 22:20 [PR PATCH] Avoid overriding do_install() in haskell-stack build-style zhengqunkoo
2020-04-26  1:15 ` Avoid overriding do_install() from build-style sgn
2020-04-26  8:07 ` [PR PATCH] [Updated] " zhengqunkoo
2020-04-26  8:08 ` zhengqunkoo
2020-04-26 11:15 ` NeelChotai
2020-04-26 13:20 ` zhengqunkoo [this message]
2020-04-27 15:56 ` [PR PATCH] [Merged]: kmonad: avoid overriding do_install() in build-style Hoshpak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200426132032.jAGvNMg1RrEKjSqaVP0xLGSptt3a3DRW3Wq0fCOorQ0@z \
    --to=zhengqunkoo@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).