Re: [PR PATCH] [Merged]: spotifyd: add build_options

[abenson <abenson@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]

There's a merged pull request on the void-packages repository

spotifyd: add build_options
https://github.com/void-linux/void-packages/pull/21446

Description:
Instead of manually altering the Cargo.toml file, we use the feature
flags available in cargo. There are three build options now:

- alsa: ALSA backend
- pulseaudio: Pulseaudio backend
- dbus: D-Bus functionality, both mpris and keyring

This also allows for a greater granularity when specifying dependencies.
All build options are selected as default, both to keep the package the
same as it was before (alsa and pulseaudio) and because the dependency
needed by the dbus option (dbus-libs) is required by pulseaudio already.

This commit allows builders to easily disable D-Bus functionality or
either audio backend without altering the template.

--

Removing the dbus option as a default one would be ok too.

I'd also like to leave the template as an idea for how to start implementing the feature flags straight into the cargo build style.

@abenson can you review this one, please?

Also, the aarch64-musl error still happens, unfortunately, but is supposed to have been fixed in a next version of the `nix` crate. So perhaps when there's a next release we can re-enable the package for that arch as well.