Github messages for voidlinux
 help / color / mirror / Atom feed
From: mobinmob <mobinmob@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] wicd: fix package
Date: Tue, 12 May 2020 12:03:26 +0200	[thread overview]
Message-ID: <20200512100326.PxFULx6KzTG8_7v_tRbudrAeSswC3sk8ZmRgZBVus8Q@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-21665@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 710 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages wicd-fix
https://github.com/void-linux/void-packages/pull/21665

wicd: fix package
- configure to use dhclient and kdesu 
  (the default dhcpcd does not work)
- use included .desktop files instead of providing extra
- allow users in network group to control daemon via dbus

@Gottox : This PR makes wicd use the same group for dbus as connman (https://github.com/void-linux/void-packages/pull/21618) and 
NetworkManager (https://github.com/void-linux/void-packages/pull/21608).

A patch file from https://github.com/void-linux/void-packages/pull/21665.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wicd-fix-21665.patch --]
[-- Type: text/x-diff, Size: 3969 bytes --]

From 82d1919308bfa28ba521f1bca79255164f81580f Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Wed, 6 May 2020 00:11:15 +0300
Subject: [PATCH] wicd: fix package - configure to use dhclient and kdesu by
 default   (the default dhcpcd does not work) - use included .desktop files
 instead of providing extra - allow users in network group to control daemon
 via dbus

---
 srcpkgs/wicd/INSTALL.msg                 |  3 ++-
 srcpkgs/wicd/files/manager-settings.conf |  9 +++++++++
 srcpkgs/wicd/files/wicd.desktop          | 11 -----------
 srcpkgs/wicd/template                    | 19 ++++++++++++-------
 4 files changed, 23 insertions(+), 19 deletions(-)
 create mode 100755 srcpkgs/wicd/files/manager-settings.conf
 delete mode 100644 srcpkgs/wicd/files/wicd.desktop

diff --git a/srcpkgs/wicd/INSTALL.msg b/srcpkgs/wicd/INSTALL.msg
index 223db8a8d11..1665d17053b 100644
--- a/srcpkgs/wicd/INSTALL.msg
+++ b/srcpkgs/wicd/INSTALL.msg
@@ -5,4 +5,5 @@ boot, please disable them before using wicd. You can do that with:
 	# rm -f /var/service/{dhcpcd,wpa_supplicant}
 
 ATTENTION: to make wicd work for your user, it must be a member
-of the 'users' group.
+of the 'network' group.You may need 'kdesu' for priviledge 
+elevation.
diff --git a/srcpkgs/wicd/files/manager-settings.conf b/srcpkgs/wicd/files/manager-settings.conf
new file mode 100755
index 00000000000..8133dea5e8d
--- /dev/null
+++ b/srcpkgs/wicd/files/manager-settings.conf
@@ -0,0 +1,9 @@
+[Settings]
+always_show_wired_interface = True
+auto_reconnect = True
+wired_connect_mode = 0
+dhcp_client = 1
+sudo_app = 2
+prefer_wired = True
+show_never_connect = True
+
diff --git a/srcpkgs/wicd/files/wicd.desktop b/srcpkgs/wicd/files/wicd.desktop
deleted file mode 100644
index 2c8f6de1f31..00000000000
--- a/srcpkgs/wicd/files/wicd.desktop
+++ /dev/null
@@ -1,11 +0,0 @@
-[Desktop Entry]
-Categories=Application;Network;Internet;
-Encoding=UTF-8
-Exec=/usr/bin/wicd-client -n
-GenericName=Network Manager
-Icon=wicd-gtk.png
-Comment=Manage Wired/Wireless Networks
-Name=Wicd
-Terminal=false
-Type=Application
-Version=1.0
diff --git a/srcpkgs/wicd/template b/srcpkgs/wicd/template
index 151c326c721..b3b5db26586 100644
--- a/srcpkgs/wicd/template
+++ b/srcpkgs/wicd/template
@@ -1,22 +1,21 @@
 # Template file for 'wicd'
 pkgname=wicd
 version=1.7.4
-revision=4
+revision=5
 archs=noarch
-pycompile_module="wicd"
-pycompile_dirs="usr/lib/wicd usr/share/wicd"
 hostmakedepends="python python-setuptools python-Babel"
-depends="dbus-glib dhcpcd ethtool net-tools python-dbus python-gobject2 python-urwid
+depends="dbus-glib dhclient ethtool net-tools python-dbus python-gobject2 python-urwid
  util-linux wireless_tools wpa_supplicant"
 conf_files="
 	/etc/dbus-1/system.d/wicd.conf
 	/etc/wicd/encryption/templates/active"
 short_desc="Open source wired and wireless network manager"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2"
+license="GPL-2.0-only"
 homepage="http://wicd.sourceforge.net"
 distfiles="http://launchpad.net/wicd/1.7/${version}/+download/wicd-${version}.tar.gz"
 checksum=67989614004773db349791c37675efb914d084bdb221356a05e4369c35e7eb62
+python_version=2
 
 do_build() {
 	python2 setup.py configure --verbose --no-install-init \
@@ -24,12 +23,18 @@ do_build() {
 		--suspend=/usr/share/wicd/scripts \
 		--python=/usr/bin/python2 --lib=/usr/lib \
 		--sbin=/usr/bin --distro=arch \
-		--no-install-gnome-shell-extensions
+		--no-install-gnome-shell-extensions \
+		--wicdgroup=network
 }
 do_install() {
 	python2 setup.py install --root=${DESTDIR}
 
-	vinstall ${FILESDIR}/wicd.desktop 644 usr/share/applications
+	vinstall other/wicd.desktop 644 usr/share/applications
+	vinstall other/wicd-tray.desktop 644 usr/share/applications
+
+	# Copy configuration to force use of dhclient.
+	vinstall ${FILESDIR}/manager-settings.conf 755 etc/wicd
+
 	vmkdir usr/lib/wicd
 	vcopy "build/lib/wicd/*.py" usr/lib/wicd
 	chmod 755 ${DESTDIR}/usr/lib/wicd/*.py

  parent reply	other threads:[~2020-05-12 10:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 21:16 [PR PATCH] " mobinmob
2020-05-05 21:44 ` [PR PATCH] [Updated] " mobinmob
2020-05-07 18:33 ` mobinmob
2020-05-12 10:03 ` mobinmob [this message]
2020-05-12 10:06 ` mobinmob
2020-05-13 18:44 ` mobinmob
2020-10-17  0:24 ` sgn
2020-10-17 12:50 ` mobinmob
2020-10-17 12:50 ` mobinmob
2020-11-14  2:27 ` sgn
2020-11-14  2:27 ` [PR PATCH] [Merged]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200512100326.PxFULx6KzTG8_7v_tRbudrAeSswC3sk8ZmRgZBVus8Q@z \
    --to=mobinmob@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).