New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/21153#issuecomment-628949696

Comment:
The AUR uses `sed` to patch the binary AMD ICD to look for a renamed version of the proprietary backend driver, a fragile hack that could be prone to breakage if the string being replaced has other interpretations in the library. We don't know because we can't see the source. Gentoo uses `patchelf` to adjust the RPATH of the OpenCL ICD to prefer the backend driver as originally named by AMD, placed in a location that won't conflict with system libraries. This is a much more reliable method because the ELF format and method for specifying RPATH are well defined.

Void has standards for packaging that prohibit inclusion of amdgpu-pro as either Gentoo or the AUR do. Both methods of altering amdgpu-pro expressly violate the [AMD EULA](https://www.amd.com/en/support/gpu-pro-eula) and, as such, are almost certain never to be allowed in the repos, even as a restricted, non-free package.

I won't say you shouldn't adapt the AMD software as you see fit to make it work with your hardware and operating environment. I won't even dispute that the amdgpu-pro runtime offers some advantages over ROCm. However, in the context of Void packaging, I have high confidence that an OpenCL implementation based on amdgpu-pro will never be allowed in the repo. ROCm is not subject to the same restrictions and, as such, supersedes amdgpu-pro as the only packageable option.