Github messages for voidlinux
 help / color / mirror / Atom feed
From: Piraty <Piraty@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: python3-acme: update to 1.4.0.
Date: Tue, 19 May 2020 10:36:10 +0200	[thread overview]
Message-ID: <20200519083610.Ipy0yYylY7TmxyLamoREarBVdOM2IPwZQ_MSnEBDjlo@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-22102@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/22102#issuecomment-630673354

Comment:
just a hint: please think about if such information is a) useful per se or redundant just by looking at the patch b) is really useful and therefore better suited to be included in the commit's text, as github PRs are to be considered volatile whereas the git-log is not, also no one really looks up the relavant information of a patch here after its merged but consults the git-log first, so better put the traces right there 

  parent reply	other threads:[~2020-05-19  8:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-18 20:24 [PR PATCH] " zdykstra
2020-05-18 20:25 ` [PR PATCH] [Updated] " zdykstra
2020-05-19  8:36 ` Piraty [this message]
2020-05-19  8:36 ` [PR PATCH] [Merged]: " Piraty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200519083610.Ipy0yYylY7TmxyLamoREarBVdOM2IPwZQ_MSnEBDjlo@z \
    --to=piraty@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).