From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Package request: grub-btrfs
Date: Thu, 28 May 2020 14:46:00 +0200 [thread overview]
Message-ID: <20200528124600.h96C014xNMLVaG-FX5L5ogD4I4nHrGWbJ7b-PPiau10@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-21581@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/issues/21581#issuecomment-635327844
Comment:
Hi Anjan,
On 2020-05-27 23:32:37-0700, Anjan Momi <notifications@github.com> wrote:
>
> Do you want to maintain this package instead of me? If so, I have no
> problem. Please send a pull request with your patch overwriting my
> grub-btrfs package.
Your template installed `/etc/grub.d/41_snapshots-btrfs`
I don't know why we need to install it in post_install.
Minor problem that I've just recognized:
- /etc/default/grub-btrfs/config should be conf_files
- /usr/lib/systemd/system shouldn't exist
- depends+="btrfs-progs"
I would be happy to have you check it and confirm it's correct.
I'm fine with write the change myself if you can confirm my understand
is correct.
If you create PR for them, I'll merge it.
--
Danh
next prev parent reply other threads:[~2020-05-28 12:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 9:10 [ISSUE] " notramo
2020-05-04 2:32 ` Morgareth99
2020-05-10 2:39 ` ericonr
2020-05-24 8:00 ` anjandev
2020-05-26 0:28 ` [ISSUE] [CLOSED] " sgn
2020-05-27 21:58 ` Morgareth99
2020-05-27 22:05 ` Morgareth99
2020-05-27 22:09 ` Morgareth99
2020-05-28 6:32 ` anjandev
2020-05-28 12:46 ` sgn [this message]
2020-05-28 13:41 ` Morgareth99
2020-05-28 13:41 ` Morgareth99
2020-05-30 9:53 ` anjandev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528124600.h96C014xNMLVaG-FX5L5ogD4I4nHrGWbJ7b-PPiau10@z \
--to=sgn@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).