From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: ncspot-0.1.4
Date: Mon, 06 Jul 2020 15:16:45 +0200 [thread overview]
Message-ID: <20200706131645.H-Jf5e1pZPvRnKGVQz9kf9EJFtMlFQDcakMn-OJQ3xY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23415@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 466 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/23415#discussion_r450212734
Comment:
If it's broken specifically for one arch that's fine, but if it works when compiling natively, but not when cross compiling, it should be marked as nocross. Usually you use archs only when it's a platform or ISA level support thing. If it's broken on all cross compiling cases, the issue is likely with the "cross" part
next prev parent reply other threads:[~2020-07-06 13:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 12:21 [PR PATCH] " rien
2020-07-06 12:57 ` rien
2020-07-06 13:00 ` [PR PATCH] [Updated] " rien
2020-07-06 13:00 ` rien
2020-07-06 13:06 ` [PR REVIEW] " ericonr
2020-07-06 13:06 ` ericonr
2020-07-06 13:06 ` ericonr
2020-07-06 13:07 ` ericonr
2020-07-06 13:10 ` rien
2020-07-06 13:16 ` ericonr [this message]
2020-07-06 18:33 ` Chocimier
2020-07-06 19:36 ` [PR PATCH] [Updated] " rien
2020-07-06 19:37 ` rien
2020-07-07 8:15 ` rien
2020-07-07 8:23 ` rien
2020-07-07 11:58 ` [PR REVIEW] " rien
2020-07-26 1:48 ` fosslinux
2020-07-27 10:30 ` [PR PATCH] [Updated] " rien
2020-07-27 10:31 ` rien
2020-07-27 11:07 ` New package: ncspot-0.2.0 rien
2020-07-27 13:14 ` [PR PATCH] [Updated] " rien
2020-07-27 13:17 ` rien
2022-04-17 2:06 ` github-actions
2022-04-17 18:51 ` [PR PATCH] [Closed]: " rien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706131645.H-Jf5e1pZPvRnKGVQz9kf9EJFtMlFQDcakMn-OJQ3xY@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).