From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] dkms: improvements to post-install hook: run depmod if necessary and better handle DKMS build/install failures
Date: Sat, 11 Jul 2020 03:44:45 +0200 [thread overview]
Message-ID: <20200711014445.GCwg3cwUBMscfTC_QBmw_Ekq7DrikUR0TOg7UC4mItU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23392@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 359 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/23392#discussion_r453139977
Comment:
I don't think we should reach this condition, right? Two shifts per iteration and an even number of arguments should mean that at one point the number of arguments will reach zero, and the while simply won't run.
next prev parent reply other threads:[~2020-07-11 1:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 20:51 [PR PATCH] dkms: run depmod if necessary in kernel post-install hook ahesford
2020-07-05 1:19 ` [PR PATCH] [Updated] " ahesford
2020-07-05 1:20 ` ahesford
2020-07-11 1:34 ` [PR PATCH] [Updated] dkms: improvements to post-install hook: run depmod if necessary and better handle DKMS build/install failures ahesford
2020-07-11 1:44 ` ericonr [this message]
2020-07-11 1:50 ` ahesford
2020-07-11 2:00 ` ahesford
2020-07-11 2:01 ` [PR REVIEW] " ahesford
2020-07-11 2:18 ` [PR PATCH] [Updated] " ahesford
2020-07-11 2:21 ` [PR PATCH] [Merged]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200711014445.GCwg3cwUBMscfTC_QBmw_Ekq7DrikUR0TOg7UC4mItU@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).