From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] [RFC] New numpy build_helper to support cross compilation
Date: Sat, 11 Jul 2020 06:21:58 +0200 [thread overview]
Message-ID: <20200711042158.ii5L5NeZOiuInikPgow1QBvE_YeTjueXhBFTF7LPyK4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23515@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1580 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/23515#discussion_r453153283
Comment:
> Most of the other helpers seem to add stuff unconditionally. Why not here?
This isn't true. The `gir.sh` and `qemu.sh` helpers both do conditional appends to `hostmakedepends` and `makedepends` as is done here. The other helpers, `qmake.sh` and `rust.sh`, don't modify `*depends` at all.
> I would have something like [...]
Switching `makedepends` and `hostmakedepends` would have the same outcome, but I think it breaks with "correct" templating for Python. In many cases, Python packages have to be in `hostmakedepends` so that the host interpreter can run them or at least confirm that they are available at build time. (I actually think there are many templates that get this wrong; the fact that `setuptools` will use `pip` or `easy_install` to download dependencies on the host often hides this mistake by populating `wrksrc` with Python eggs to satisfy missing dependencies.) Often, Python packages (especially pure Python) never need to be in `makedepends` at all.
Packages like `python3-scipy` are special cases because they link C and FORTRAN against a library provided with `python3-numpy`. That needs to be in `makedepends` but, on native builds, we happen to already have provided the needed dependency.
To improve consistency with best practice for other Python dependencies, I think `hostmakedepends` should be the "standard" variable here, with `makedepends` added to fill the hole for cross builds.
next prev parent reply other threads:[~2020-07-11 4:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-11 3:42 [PR PATCH] " ahesford
2020-07-11 3:48 ` [PR REVIEW] " ericonr
2020-07-11 4:02 ` sgn
2020-07-11 4:09 ` [PR PATCH] [Updated] " ahesford
2020-07-11 4:11 ` [PR REVIEW] " ahesford
2020-07-11 4:21 ` ahesford [this message]
2020-07-11 4:29 ` ericonr
2020-07-11 16:14 ` ahesford
2020-07-11 17:03 ` [PR PATCH] [Updated] " ahesford
2020-07-12 18:30 ` ahesford
2020-07-12 18:30 ` ahesford
2020-07-13 2:45 ` [PR PATCH] [Merged]: " ahesford
2020-07-13 4:13 ` ericonr
2020-07-13 4:17 ` ahesford
2020-07-13 4:22 ` ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200711042158.ii5L5NeZOiuInikPgow1QBvE_YeTjueXhBFTF7LPyK4@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).